[Intel-wired-lan] [tnguy-net-queue:40GbE] BUILD SUCCESS 3e7917c0cdad835a5121520fc5686d954b7a61ab

2024-08-07 Thread kernel test robot
allmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240807 gcc-13.2.0 arc

[Intel-wired-lan] [PATCH iwl-next v3] ice: Implement ethtool reset support

2024-08-07 Thread Wojciech Drewek
Enable ethtool reset support. Ethtool reset flags are mapped to the E810 reset type: PF reset: $ ethtool --reset irq dma filter offload CORE reset: $ ethtool --reset irq-shared dma-shared filter-shared \ offload-shared ram-shared GLOBAL reset: $ ethtool --reset irq-shared dma-shared fi

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Implement ethtool reset support

2024-08-07 Thread Wojciech Drewek
On 06.08.2024 16:55, Simon Horman wrote: > On Mon, Aug 05, 2024 at 02:46:51PM +0200, Wojciech Drewek wrote: >> Enable ethtool reset support. Ethtool reset flags are mapped to the >> E810 reset type: >> PF reset: >> $ ethtool --reset irq dma filter offload >> CORE reset: >> $ ethtool --reset

[Intel-wired-lan] [PATCH iwl-net 1/3] ice: fix page reuse when PAGE_SIZE is over 8k

2024-08-07 Thread Maciej Fijalkowski
Architectures that have PAGE_SIZE >= 8192 such as arm64 should act the same as x86 currently, meaning reuse of a page should only take place when no one else is busy with it. Do two things independently of underlying PAGE_SIZE: - store the page count under ice_rx_buf::pgcnt - then act upon its val

[Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix Rx data path for PAGE_SIZE >= 8192

2024-08-07 Thread Maciej Fijalkowski
Hi, These three small fixes addres the following panic reported by Luiz (https://lore.kernel.org/netdev/8f9e2a5c-fd30-4206-9311-946a06d03...@redhat.com/): [ 225.715759] Unable to handle kernel paging request at virtual address 0075e625f68aa42c [ 225.723669] Mem abort info: [ 225.726487] ESR

[Intel-wired-lan] [PATCH iwl-net 2/3] ice: fix ICE_LAST_OFFSET formula

2024-08-07 Thread Maciej Fijalkowski
For bigger PAGE_SIZE archs, ice driver works on 3k Rx buffers. Therefore, ICE_LAST_OFFSET should take into account ICE_RXBUF_3072, not ICE_RXBUF_2048. Fixes: 7237f5b0dba4 ("ice: introduce legacy Rx flag") Suggested-by: Luiz Capitulino Signed-off-by: Maciej Fijalkowski --- drivers/net/ethernet/i

[Intel-wired-lan] [PATCH iwl-net 3/3] ice: fix truesize operations for PAGE_SIZE >= 8192

2024-08-07 Thread Maciej Fijalkowski
When working on multi-buffer packet on arch that has PAGE_SIZE >= 8192, truesize is calculated and stored in xdp_buff::frame_sz per each processed Rx buffer. This means that frame_sz will contain the truesize based on last received buffer, but commit 1dc1a7e7f410 ("ice: Centrallize Rx buffer recycl

Re: [Intel-wired-lan] [PATCH] [PATCH iwl-net] idpf: Acquire the lock before accessing the xn->salt

2024-08-07 Thread Alexander Lobakin
From: Manoj Vishwanathan Date: Mon, 5 Aug 2024 18:21:59 + > The transaction salt was being accessed before acquiring the > idpf_vc_xn_lock when idpf has to forward the virtchnl reply. You need to explain in details here what issue you have faced due to that, how to reproduce it and how this

[Intel-wired-lan] [tnguy-next-queue:main] BUILD SUCCESS 45160cebd6ac84fe8cc2b7f6fec2550398e144cd

2024-08-07 Thread kernel test robot
nsim_700_defconfig gcc-13.2.0 arc randconfig-001-20240807 gcc-13.2.0 arc randconfig-002-20240807 gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm allnoconfig clang-20 arm

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-08-07 Thread Alexander Lobakin
From: Kolacinski, Karol Date: Mon, 5 Aug 2024 18:21:39 +0200 > From: Aleksander Lobakin > Date: Fri, 26 Jul 2024 15:37 +0200 >>> +/** >>> + * ice_ptp_set_funcs_e830 - Set specialized functions for E830 support >>> + * @pf: Board private structure >>> + * >>> + * Assign functions to the PTP capab

Re: [Intel-wired-lan] [PATCH] [PATCH iwl-net] idpf: Acquire the lock before accessing the xn->salt

2024-08-07 Thread Manoj Vishwanathan
Thanks Przemek & Olek for your quick feedback and responses. Hi Olek, I can add more details about the issue we faced in the commit message. The bug we had here was a virtchnl delay leading to the xn->salt mismatch. This could be due to several factors including default CPU bounded kworker workqueu

Re: [Intel-wired-lan] [PATCH] [PATCH iwl-net] idpf: Acquire the lock before accessing the xn->salt

2024-08-07 Thread Alexander Lobakin
From: Manoj Vishwanathan Date: Wed, 7 Aug 2024 06:58:59 -0700 > Thanks Przemek & Olek for your quick feedback and responses. > Hi Olek, > I can add more details about the issue we faced in the commit message. > The bug we had here was a virtchnl delay leading to the xn->salt > mismatch. This coul

[Intel-wired-lan] [tnguy-net-queue:1GbE] BUILD SUCCESS b3cbeed8351af8b1c41a98f535806e1d47452c19

2024-08-07 Thread kernel test robot
-13.2.0 arc allyesconfig gcc-13.2.0 arc randconfig-001-20240807 gcc-13.2.0 arc randconfig-002-20240807 gcc-13.2.0 arm allmodconfig gcc-14.1.0 arm allnoconfig clang-20 arm

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-08-07 Thread Kolacinski, Karol
From: Aleksander Lobakin Date: Wed, 07 Aug 2024 15:54 +0200 +static void ice_ptp_set_funcs_e830(struct ice_pf *pf) +{ +#ifdef CONFIG_ICE_HWTS + if (pcie_ptm_enabled(pf->pdev) && + boot_cpu_has(X86_FEATURE_ART) && + boot_cpu_has(X86_FEATURE_TSC_KNOW

Re: [Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix Rx data path for PAGE_SIZE >= 8192

2024-08-07 Thread Luiz Capitulino
On 2024-08-07 06:53, Maciej Fijalkowski wrote: Hi, These three small fixes addres the following panic reported by Luiz (https://lore.kernel.org/netdev/8f9e2a5c-fd30-4206-9311-946a06d03...@redhat.com/): Thank you one more time for getting this fixed! I had to return the testbed so I won't be a

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS a6b37ad7bc03ceb4d627f4f1c96ab0ac4060d09c

2024-08-07 Thread kernel test robot
haps_hs_defconfig gcc-13.2.0 arcnsim_700_defconfig gcc-13.2.0 arc randconfig-001-20240807 gcc-13.2.0 arc randconfig-002-20240807 gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm allmodconfig

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/5] igc: Ensure the PTM cycle is reliably triggered

2024-08-07 Thread Corinna Vinschen
Hi Christopher, On Aug 6 17:30, christopher.s.h...@intel.com wrote: > From: Christopher S M Hall > > Writing to clear the PTM status 'valid' bit while the PTM cycle is > triggered results in unreliable PTM operation. To fix this, clear the > PTM 'trigger' and status after each PTM transaction.

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS cd347f613f89c6608839c698d74b6dd6238a4601

2024-08-07 Thread kernel test robot
allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc randconfig-001-20240807 gcc-13.2.0 arc randconfig-002-20240807 gcc-13.2.0 arm allmodconfig gcc-14.1.0 arm

Re: [Intel-wired-lan] [PATCH] [PATCH iwl-net] idpf: Acquire the lock before accessing the xn->salt

2024-08-07 Thread Simon Horman
On Wed, Aug 07, 2024 at 06:58:59AM -0700, Manoj Vishwanathan wrote: > Thanks Przemek & Olek for your quick feedback and responses. > Hi Olek, > I can add more details about the issue we faced in the commit message. > The bug we had here was a virtchnl delay leading to the xn->salt > mismatch. This

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: add E830 HW VF mailbox message limit support

2024-08-07 Thread Greenwalt, Paul
On 8/1/2024 8:56 AM, Alexander Lobakin wrote: > From: Paul Greenwalt > Date: Wed, 31 Jul 2024 21:58:29 -0400 > >> E830 adds hardware support to prevent the VF from overflowing the PF >> mailbox with VIRTCHNL messages. E830 will use the hardware feature >> (ICE_F_MBX_LIMIT) instead of the softw

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS 92f718357de83a718a3f63d19eebc442594340a9

2024-08-07 Thread kernel test robot
arcnsim_700_defconfig gcc-13.2.0 arc randconfig-001-20240807 gcc-13.2.0 arc randconfig-002-20240807 gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm allmodconfig gcc-14.1.0 arm

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/5] igc: Ensure the PTM cycle is reliably triggered

2024-08-07 Thread Hall, Christopher S
Hi Corrina, > > PHC2SYS exits with: > > > > "ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM > transaction > > fails > > It would be great to add the problems encountered with kdump to the > commit message as well, as discussed with Vinicius, wouldn't it? > > If you need a descrip

Re: [Intel-wired-lan] [PATCH iwl-net v2 6/6] ice: do not bring the VSI up, if it was down before the XDP setup

2024-08-07 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Zaremba, Larysa >Sent: Wednesday, July 24, 2024 10:19 PM >To: intel-wired-...@lists.osuosl.org >Cc: Drewek, Wojciech ; Fijalkowski, Maciej >; Jesper Dangaard Brouer ; >Daniel Borkmann ; Zaremba, Larysa >; net...@vger.kernel.org; J

Re: [Intel-wired-lan] [PATCH iwl-net v2 4/6] ice: check ICE_VSI_DOWN under rtnl_lock when preparing for reset

2024-08-07 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Zaremba, Larysa >Sent: Wednesday, July 24, 2024 10:19 PM >To: intel-wired-...@lists.osuosl.org >Cc: Drewek, Wojciech ; Fijalkowski, Maciej >; Jesper Dangaard Brouer ; >Daniel Borkmann ; Zaremba, Larysa >; net...@vger.kernel.org; J

Re: [Intel-wired-lan] [PATCH iwl-net v2 2/6] ice: protect XDP configuration with a mutex

2024-08-07 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Zaremba, Larysa >Sent: Wednesday, July 24, 2024 10:19 PM >To: intel-wired-...@lists.osuosl.org >Cc: Drewek, Wojciech ; Fijalkowski, Maciej >; Jesper Dangaard Brouer ; >Daniel Borkmann ; Zaremba, Larysa >; net...@vger.kernel.org; J

Re: [Intel-wired-lan] [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code

2024-08-07 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Zaremba, Larysa >Sent: Wednesday, July 24, 2024 10:19 PM >To: intel-wired-...@lists.osuosl.org >Cc: Drewek, Wojciech ; Fijalkowski, Maciej >; Jesper Dangaard Brouer ; >Daniel Borkmann ; Zaremba, Larysa >; net...@vger.kernel.org; J

Re: [Intel-wired-lan] [PATCH iwl-net v2 3/6] ice: check for XDP rings instead of bpf program when unconfiguring

2024-08-07 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Zaremba, Larysa >Sent: Wednesday, July 24, 2024 10:19 PM >To: intel-wired-...@lists.osuosl.org >Cc: Drewek, Wojciech ; Fijalkowski, Maciej >; Jesper Dangaard Brouer ; >Daniel Borkmann ; Zaremba, Larysa >; net...@vger.kernel.org; J

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/6] ice: move netif_queue_set_napi to rtnl-protected sections

2024-08-07 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Zaremba, Larysa >Sent: Wednesday, July 24, 2024 10:19 PM >To: intel-wired-...@lists.osuosl.org >Cc: Drewek, Wojciech ; Fijalkowski, Maciej >; Jesper Dangaard Brouer ; >Daniel Borkmann ; Zaremba, Larysa >; net...@vger.kernel.org; J