[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS af65ea42bd1d28d818b74b9b3b4f8da7ada9f88b

2024-07-26 Thread kernel test robot
defconfig gcc-13.2.0 arc haps_hs_defconfig gcc-13.2.0 arc randconfig-001-20240726 gcc-13.2.0 arc randconfig-002-20240726 gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm allmodco

[Intel-wired-lan] [PATCH iwl-net v1] ice: Fix incorrect assigns of FEC counts

2024-07-26 Thread Mateusz Polchlopek
The commit ac21add2540e ("ice: Implement driver functionality to dump fec statistics") introduces obtaining FEC correctable and uncorrectable stats per netdev in ICE driver. Unfortunately the assignment of values to fec_stats structure has been done incorrectly. This commit fixes the assignments.

[Intel-wired-lan] [PATCH v4 iwl-next 0/4] ice: Implement PTP support for E830 devices

2024-07-26 Thread Karol Kolacinski
Add specific functions and definitions for E830 devices to enable PTP support. Refactor processing of timestamping interrupt and cross timestamp to avoid code redundancy. Jacob Keller (1): ice: combine cross timestamp functions for E82x and E830 Karol Kolacinski (2): ice: Process TSYN IRQ in

[Intel-wired-lan] [PATCH v4 iwl-next 1/4] ice: Implement PTP support for E830 devices

2024-07-26 Thread Karol Kolacinski
From: Michal Michalik Add specific functions and definitions for E830 devices to enable PTP support. Introduce new PHY model ICE_PHY_E830. E830 devices support direct write to GLTSYN_ registers without shadow registers and 64 bit read of PHC time. Reviewed-by: Przemek Kitszel Co-developed-by: M

[Intel-wired-lan] [PATCH v4 iwl-next 2/4] ice: Process TSYN IRQ in a separate function

2024-07-26 Thread Karol Kolacinski
Simplify TSYN IRQ processing by moving it to a separate function and having appropriate behavior per PHY model, instead of multiple conditions not related to HW, but to specific timestamping modes. Reviewed-by: Przemek Kitszel Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/i

[Intel-wired-lan] [PATCH v4 iwl-next 3/4] ice: Add timestamp ready bitmap for E830 products

2024-07-26 Thread Karol Kolacinski
E830 PHY supports timestamp ready bitmap. Enable the bitmap by refactoring tx init function. Reviewed-by: Przemek Kitszel Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/ice_ptp.c | 47 +--- drivers/net/ethernet/intel/ice/ice_ptp.h | 3 +- 2 files changed

[Intel-wired-lan] [PATCH v4 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-26 Thread Karol Kolacinski
From: Jacob Keller The E830 and E82x devices use essentially the same logic for performing a crosstimestamp. The only difference is that E830 hardware has different offsets. Instead of having two implementations, combine them into a single ice_capture_crosststamp() function. Also combine the wra

Re: [Intel-wired-lan] [PATCH v3 iwl-next 1/4] ice: Implement PTP support for E830 devices

2024-07-26 Thread Alexander Lobakin
From: Karol Kolacinski Date: Thu, 25 Jul 2024 11:34:48 +0200 > From: Michal Michalik > > Add specific functions and definitions for E830 devices to enable > PTP support. > Introduce new PHY model ICE_PHY_E830. > E830 devices support direct write to GLTSYN_ registers without shadow > registers a

Re: [Intel-wired-lan] [PATCH v3 iwl-next 2/4] ice: Process TSYN IRQ in a separate function

2024-07-26 Thread Alexander Lobakin
From: Karol Kolacinski Date: Thu, 25 Jul 2024 11:34:49 +0200 > Simplify TSYN IRQ processing by moving it to a separate function and > having appropriate behavior per PHY model, instead of multiple > conditions not related to HW, but to specific timestamping modes. > > Reviewed-by: Przemek Kitsze

Re: [Intel-wired-lan] [PATCH v3 iwl-next 3/4] ice: Add timestamp ready bitmap for E830 products

2024-07-26 Thread Alexander Lobakin
From: Karol Kolacinski Date: Thu, 25 Jul 2024 11:34:50 +0200 > E830 PHY supports timestamp ready bitmap. > Enable the bitmap by refactoring tx init function. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Karol Kolacinski [...] > @@ -987,24 +965,25 @@ ice_ptp_init_tx_e82x(struct ice_pf *p

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-26 Thread Alexander Lobakin
From: Karol Kolacinski Date: Thu, 25 Jul 2024 11:34:51 +0200 > From: Jacob Keller > > The E830 and E82x devices use essentially the same logic for performing > a crosstimestamp. The only difference is that E830 hardware has > different offsets. Instead of having two implementations, combine the

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] idpf: fix memory leaks and crashes while performing a soft reset

2024-07-26 Thread Simon Horman
On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote: > The second tagged commit introduced a UAF, as it removed restoring > q_vector->vport pointers after reinitializating the structures. > This is due to that all queue allocation functions are performed here > with the new temporary

Re: [Intel-wired-lan] [PATCH iwl-net 2/3] idpf: fix memleak in vport interrupt configuration

2024-07-26 Thread Simon Horman
On Wed, Jul 24, 2024 at 03:40:23PM +0200, Alexander Lobakin wrote: > From: Michal Kubiak > > The initialization of vport interrupt consists of two functions: > 1) idpf_vport_intr_init() where a generic configuration is done > 2) idpf_vport_intr_req_irq() where the irq for each q_vector is >

Re: [Intel-wired-lan] [PATCH iwl-net 3/3] idpf: fix UAFs when destroying the queues

2024-07-26 Thread Simon Horman
On Wed, Jul 24, 2024 at 03:40:24PM +0200, Alexander Lobakin wrote: > The second tagged commit started sometimes (very rarely, but possible) > throwing WARNs from > net/core/page_pool.c:page_pool_disable_direct_recycling(). > Turned out idpf frees interrupt vectors with embedded NAPIs *before* > fre

Re: [Intel-wired-lan] [PATCH v4 iwl-next 0/4] ice: Implement PTP support for E830 devices

2024-07-26 Thread Simon Horman
On Fri, Jul 26, 2024 at 01:34:42PM +0200, Karol Kolacinski wrote: > Add specific functions and definitions for E830 devices to enable > PTP support. > Refactor processing of timestamping interrupt and cross timestamp > to avoid code redundancy. > > Jacob Keller (1): > ice: combine cross timestam

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-26 Thread Jacob Keller
On 7/26/2024 6:37 AM, Alexander Lobakin wrote: >> diff --git a/drivers/net/ethernet/intel/ice/ice_osdep.h >> b/drivers/net/ethernet/intel/ice/ice_osdep.h >> index a2562f04267f..c03ab0207e0a 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_osdep.h >> +++ b/drivers/net/ethernet/intel/ice/ice_os

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS faf541c50303c89f81dcf62b3921b82b545540be

2024-07-26 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue branch HEAD: faf541c50303c89f81dcf62b3921b82b545540be idpf: fix UAFs when destroying the queues elapsed time: 755m configs tested: 181 configs skipped: 6 The following configs have been built successful