[Intel-wired-lan] [PATCH v3 iwl-next 0/4] ice: Implement PTP support for E830 devices

2024-07-25 Thread Karol Kolacinski
Add specific functions and definitions for E830 devices to enable PTP support. Refactor processing of timestamping interrupt and cross timestamp to avoid code redundancy. Jacob Keller (1): ice: combine cross timestamp functions for E82x and E830 Karol Kolacinski (2): ice: Process TSYN IRQ in

[Intel-wired-lan] [PATCH v3 iwl-next 1/4] ice: Implement PTP support for E830 devices

2024-07-25 Thread Karol Kolacinski
From: Michal Michalik Add specific functions and definitions for E830 devices to enable PTP support. Introduce new PHY model ICE_PHY_E830. E830 devices support direct write to GLTSYN_ registers without shadow registers and 64 bit read of PHC time. Reviewed-by: Przemek Kitszel Co-developed-by: M

[Intel-wired-lan] [PATCH v3 iwl-next 3/4] ice: Add timestamp ready bitmap for E830 products

2024-07-25 Thread Karol Kolacinski
E830 PHY supports timestamp ready bitmap. Enable the bitmap by refactoring tx init function. Reviewed-by: Przemek Kitszel Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/ice_ptp.c | 47 +--- drivers/net/ethernet/intel/ice/ice_ptp.h | 3 +- 2 files changed

[Intel-wired-lan] [PATCH v3 iwl-next 2/4] ice: Process TSYN IRQ in a separate function

2024-07-25 Thread Karol Kolacinski
Simplify TSYN IRQ processing by moving it to a separate function and having appropriate behavior per PHY model, instead of multiple conditions not related to HW, but to specific timestamping modes. Reviewed-by: Przemek Kitszel Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/i

[Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-25 Thread Karol Kolacinski
From: Jacob Keller The E830 and E82x devices use essentially the same logic for performing a crosstimestamp. The only difference is that E830 hardware has different offsets. Instead of having two implementations, combine them into a single ice_capture_crosststamp() function. Also combine the wra

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Introduce netif_device_attach/detach into reset flow

2024-07-25 Thread Michal Schmidt
On Mon, Jul 22, 2024 at 2:30 PM Dawid Osuchowski wrote: > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c > b/drivers/net/ethernet/intel/ice/ice_main.c > index ec636be4d17d..eb199fd3c989 100644 > --- a/drivers/net/ethernet/intel/ice/ice_main.c > +++ b/drivers/net/ethernet/intel/ice/ice_mai

Re: [Intel-wired-lan] [RFC v11 04/14] mm: page_frag: add '_va' suffix to page_frag API

2024-07-25 Thread Yunsheng Lin
On 2024/7/22 4:41, Alexander Duyck wrote: > On Fri, Jul 19, 2024 at 2:37 AM Yunsheng Lin wrote: >> >> Currently the page_frag API is returning 'virtual address' >> or 'va' when allocing and expecting 'virtual address' or >> 'va' as input when freeing. >> >> As we are about to support new use cases

Re: [Intel-wired-lan] [PATCH iwl-next v4 13/13] iavf: add support for offloading tc U32 cls filters

2024-07-25 Thread Ahmed Zaki
On 2024-07-25 2:12 a.m., Hariprasad Kelam wrote: On 2024-07-25 at 03:06:22, Ahmed Zaki (ahmed.z...@intel.com) wrote: Add support for offloading cls U32 filters. Only "skbedit queue_mapping" and "drop" actions are supported. Also, only "ip" and "802_3" tc protocols are allowed. The PF must adv

Re: [Intel-wired-lan] [PATCH v3 iwl-next 4/4] ice: combine cross timestamp functions for E82x and E830

2024-07-25 Thread Jacob Keller
On 7/25/2024 2:34 AM, Karol Kolacinski wrote: > From: Jacob Keller > > The E830 and E82x devices use essentially the same logic for performing > a crosstimestamp. The only difference is that E830 hardware has > different offsets. Instead of having two implementations, combine them > into a sin

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Introduce netif_device_attach/detach into reset flow

2024-07-25 Thread Tony Nguyen
On 7/25/2024 3:30 AM, Michal Schmidt wrote: On Mon, Jul 22, 2024 at 2:30 PM Dawid Osuchowski wrote: diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index ec636be4d17d..eb199fd3c989 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++

[Intel-wired-lan] [PATCH iwl-next v5 00/13] ice: iavf: add support for TC U32 filters on VFs

2024-07-25 Thread Ahmed Zaki
The Intel® Ethernet 800 Series is designed with a pipeline that has an on-chip programmable capability called Dynamic Device Personalization (DDP). A DDP package is loaded by the driver during probe time. The DDP package programs functionality in both the parser and switching blocks in the pipeline

[Intel-wired-lan] [PATCH iwl-next v5 01/13] ice: add parser create and destroy skeleton

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Add new parser module which can parse a packet in binary and generate information like ptype, protocol/offset pairs and flags which can be later used to feed the FXP profile creation directly. Add skeleton of the create and destroy APIs: ice_parser_create() ice_parser_destroy()

[Intel-wired-lan] [PATCH iwl-next v5 02/13] ice: parse and init various DDP parser sections

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Parse the following DDP sections: - ICE_SID_RXPARSER_IMEM into an array of struct ice_imem_item - ICE_SID_RXPARSER_METADATA_INIT into an array of struct ice_metainit_item - ICE_SID_RXPARSER_CAM or ICE_SID_RXPARSER_PG_SPILL into an array of struct ice_pg_cam_item - ICE_SID

[Intel-wired-lan] [PATCH iwl-next v5 03/13] ice: add debugging functions for the parser sections

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Add debug for all parser sections. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahmed Zaki Tested-by: Rafal Romanowski --- drivers/net/ethernet/intel/ice/ice_parser.c | 470 1 file changed, 470 insertion

[Intel-wired-lan] [PATCH iwl-next v5 04/13] ice: add parser internal helper functions

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Add the following internal helper functions: - ice_bst_tcam_match(): to perform ternary match on boost TCAM. - ice_pg_cam_match(): to perform parse graph key match in cam table. - ice_pg_nm_cam_match(): to perform parse graph key no match in cam table. - ice_ptype_mk_t

[Intel-wired-lan] [PATCH iwl-next v5 05/13] ice: add parser execution main loop

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Implement the core work of the runtime parser via: - ice_parser_rt_execute() - ice_parser_rt_reset() - ice_parser_rt_pkt_buf_set() Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahmed Zaki Tested-by: Rafal Romanowski --- drive

[Intel-wired-lan] [PATCH iwl-next v5 06/13] ice: support turning on/off the parser's double vlan mode

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Add API ice_parser_dvm_set() to support turning on/off the parser's double vlan mode. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Co-developed-by: Ahmed Zaki Signed-off-by: Ahmed Zaki Tested-by: Rafal Romanowski --- drivers/net/ethernet/

[Intel-wired-lan] [PATCH iwl-next v5 07/13] ice: add UDP tunnels support to the parser

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Add support for the vxlan, geneve, ecpri UDP tunnels through the following APIs: - ice_parser_vxlan_tunnel_set() - ice_parser_geneve_tunnel_set() - ice_parser_ecpri_tunnel_set() Reviewed-by: Simon Horman Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfe

[Intel-wired-lan] [PATCH iwl-next v5 08/13] ice: add API for parser profile initialization

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Add API ice_parser_profile_init() to init a parser profile based on a parser result and a mask buffer. The ice_parser_profile struct is used by the low level FXP engine to create HW profile/field vectors. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfe

[Intel-wired-lan] [PATCH iwl-next v5 09/13] virtchnl: support raw packet in protocol header

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo The patch extends existing virtchnl_proto_hdrs structure to allow VF to pass a pair of buffers as packet data and mask that describe a match pattern of a filter rule. Then the kernel PF driver is requested to parse the pair of buffer and figure out low level hardware metadata (p

[Intel-wired-lan] [PATCH iwl-next v5 10/13] ice: add method to disable FDIR SWAP option

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo The SWAP Flag in the FDIR Programming Descriptor doesn't work properly, it is always set and cannot be unset (hardware bug). Thus, add a method to effectively disable the FDIR SWAP option by setting the FDSWAP instead of FDINSET registers. Reviewed-by: Marcin Szycik Signed-off

[Intel-wired-lan] [PATCH iwl-next v5 11/13] ice: enable FDIR filters from raw binary patterns for VFs

2024-07-25 Thread Ahmed Zaki
From: Junfeng Guo Enable VFs to create FDIR filters from raw binary patterns. The corresponding processes for raw flow are added in the Parse / Create / Destroy stages. Reviewed-by: Marcin Szycik Signed-off-by: Junfeng Guo Co-developed-by: Ahmed Zaki Signed-off-by: Ahmed Zaki Tested-by: Rafa

[Intel-wired-lan] [PATCH iwl-next v5 12/13] iavf: refactor add/del FDIR filters

2024-07-25 Thread Ahmed Zaki
In preparation for a second type of FDIR filters that can be added by tc-u32, move the add/del of the FDIR logic to be entirely contained in iavf_fdir.c. The iavf_find_fdir_fltr_by_loc() is renamed to iavf_find_fdir_fltr() to be more agnostic to the filter ID parameter (for now @loc, which is rele

[Intel-wired-lan] [PATCH iwl-next v5 13/13] iavf: add support for offloading tc U32 cls filters

2024-07-25 Thread Ahmed Zaki
Add support for offloading cls U32 filters. Only "skbedit queue_mapping" and "drop" actions are supported. Also, only "ip" and "802_3" tc protocols are allowed. The PF must advertise the VIRTCHNL_VF_OFFLOAD_TC_U32 capability flag. Since the filters will be enabled via the FD stage at the PF, a new

Re: [Intel-wired-lan] [PATCH iwl-next v5 00/13] ice: iavf: add support for TC U32 filters on VFs

2024-07-25 Thread Jakub Kicinski
On Thu, 25 Jul 2024 16:07:56 -0600 Ahmed Zaki wrote: > v5: > - Add queue ID validation to iavf_add_cls_u32() (patch 13) Is it really worth reposting after 24h without getting any feedback? I'd say it's not..