[Intel-wired-lan] [PATCH net v3] igb: cope with large MAX_SKB_FRAGS.

2024-07-18 Thread Corinna Vinschen
From: Paolo Abeni Sabrina reports that the igb driver does not cope well with large MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload corruption on TX. An easy reproducer is to run ssh to connect to the machine. With MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails. The r

Re: [Intel-wired-lan] [PATCH net v2] igb: cope with large MAX_SKB_FRAGS

2024-07-18 Thread Corinna Vinschen
Hi Eric, sorry for the very late reply, I was offline for quite some time and then other things took over. On Apr 26 19:54, Eric Dumazet wrote: > On Fri, Apr 26, 2024 at 4:30 PM Corinna Vinschen wrote: > > > > Hi Eric, > > > > On Apr 23 16:10, Eric Dumazet wrote: > > > On Tue, Apr 23, 2024 at 3:

[Intel-wired-lan] [PATCH iwl-next v4 0/5] Replace auxbus with ice_adapter in the PTP support code

2024-07-18 Thread Sergey Temerkhanov
This series replaces multiple aux buses and devices used in the PTP support code with struct ice_adapter holding the necessary shared data Patches 1,2 add convenience wrappers Patch 3 does the main refactoring Patch 4 finalizes the refactoring Previous discussion: https://lists.osuosl.org/piperm

[Intel-wired-lan] [PATCH iwl-next v4 1/5] ice: Introduce ice_get_phy_model() wrapper

2024-07-18 Thread Sergey Temerkhanov
Introduce ice_get_phy_model() to improve code readability Signed-off-by: Sergey Temerkhanov Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman --- drivers/net/ethernet/intel/ice/ice.h| 5 + drivers/net/ethernet/intel/ice/ice_ptp.c| 18 - drivers/net/etherne

[Intel-wired-lan] [PATCH iwl-next v4 2/5] ice: Add ice_get_ctrl_ptp() wrapper to simplify the code

2024-07-18 Thread Sergey Temerkhanov
Add ice_get_ctrl_ptp() wrapper to simplify the PTP support code in the functions that do not use ctrl_pf directly. Add the control PF pointer to struct ice_adapter Rearrange fields in struct ice_adapter Signed-off-by: Sergey Temerkhanov Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman ---

[Intel-wired-lan] [PATCH iwl-next v4 3/5] ice: Initial support for E825C hardware in ice_adapter

2024-07-18 Thread Sergey Temerkhanov
Address E825C devices by PCI ID since dual IP core configurations need 1 ice_adapter for both devices. Signed-off-by: Sergey Temerkhanov --- drivers/net/ethernet/intel/ice/ice_adapter.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/int

[Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Use ice_adapter for PTP shared data instead of auxdev

2024-07-18 Thread Sergey Temerkhanov
Use struct ice_adapter to hold shared PTP data and control PTP related actions instead of auxbus. This allows significant code simplification and faster access to the container fields used in the PTP support code. Move the PTP port list to the ice_adapter container to simplify the code and avoid r

[Intel-wired-lan] [PATCH iwl-next v4 5/5] ice: Drop auxbus use for PTP to finalize ice_adapter move

2024-07-18 Thread Sergey Temerkhanov
Drop unused auxbus/auxdev support from the PTP code due to move to the ice_adapter. Signed-off-by: Sergey Temerkhanov Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman --- drivers/net/ethernet/intel/ice/ice_ptp.c | 252 --- drivers/net/ethernet/intel/ice/ice_ptp.h | 2

Re: [Intel-wired-lan] [PATCH iwl-next v4 3/5] ice: Initial support for E825C hardware in ice_adapter

2024-07-18 Thread Simon Horman
On Thu, Jul 18, 2024 at 12:52:51PM +0200, Sergey Temerkhanov wrote: > Address E825C devices by PCI ID since dual IP core configurations > need 1 ice_adapter for both devices. > > Signed-off-by: Sergey Temerkhanov Reviewed-by: Simon Horman

Re: [Intel-wired-lan] [PATCH iwl-next v3 10/13] ice: add method to disable FDIR SWAP option

2024-07-18 Thread Ahmed Zaki
On 2024-07-17 3:55 a.m., Paul Menzel wrote: Dear Ahmed, Thank you for your reply. Am 15.07.24 um 16:23 schrieb Ahmed Zaki: On 2024-07-10 10:59 p.m., Paul Menzel wrote: Am 10.07.24 um 22:40 schrieb Ahmed Zaki: From: Junfeng Guo The SWAP Flag in the FDIR Programming Descriptor doesn'

[Intel-wired-lan] [PATCH iwl-next v2] i40e: Add support for fw health report

2024-07-18 Thread Kamal Heib
Add support for reporting fw status via the devlink health report. Example: # devlink health show pci/:02:00.0 reporter fw pci/:02:00.0: reporter fw state healthy error 0 recover 0 # devlink health diagnose pci/:02:00.0 reporter fw Mode: normal Signed-off-by: Kamal Heib -

Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: Add support for fw health report

2024-07-18 Thread Paul Menzel
Dear Kamal, Thank you for your patch. Am 18.07.24 um 20:13 schrieb Kamal Heib: Add support for reporting fw status via the devlink health report. I do not know the interface. So, the driver already has some way to communicate with the firmware, and you only need to hook it up to devlink?