[Intel-wired-lan] [PATCH iwl-next] ice: Fix field vector array data type

2024-07-03 Thread Marcin Szycik
Correct the datatype of fv_idx array in struct ice_sw_recipe to be u8 instead of u16. This array contents are used solely to be later passed to lkup_indx in struct ice_aqc_recipe_content, which is u8. Fixes: 6d82b8eda4c7 ("ice: Optimize switch recipe creation") Reviewed-by: Michal Swiatkowski Sig

[Intel-wired-lan] [PATCH iwl-next v1 0/6] Add support for devlink health events

2024-07-03 Thread Mateusz Polchlopek
Reports for two kinds of events are implemented, Malicious Driver Detection (MDD) and Tx hang. Patches 1, 2: minor core improvements (checkpatch.pl and devlink extension) Patches 3, 4, 5: ice devlink health infra + straightforward status reports Patch 6: extension to dump also skb on Tx hang, this

[Intel-wired-lan] [PATCH iwl-next v1 1/6] checkpatch: don't complain on _Generic() use

2024-07-03 Thread Mateusz Polchlopek
From: Przemek Kitszel Improve CamelCase recognition logic to avoid reporting on _Generic() use. Other C keywords, such as _Bool, are intentionally omitted, as those should be rather avoided in new source code. Signed-off-by: Przemek Kitszel Reviewed-by: Wojciech Drewek Signed-off-by: Mateusz

[Intel-wired-lan] [PATCH iwl-next v1 2/6] devlink: add devlink_fmsg_put() macro

2024-07-03 Thread Mateusz Polchlopek
From: Przemek Kitszel Add devlink_fmsg_put() that dispatches based on the type of the value to put, example: bool -> devlink_fmsg_bool_pair_put(). Signed-off-by: Przemek Kitszel Reviewed-by: Wojciech Drewek Signed-off-by: Mateusz Polchlopek --- include/net/devlink.h | 11 +++ 1 file

[Intel-wired-lan] [PATCH iwl-next v1 4/6] ice: print ethtool stats as part of Tx hang devlink health reporter

2024-07-03 Thread Mateusz Polchlopek
From: Przemek Kitszel Print the ethtool stats as part of Tx hang devlink health dump. Move the declarations of ethtool functions that devlink health uses out to a new file: ice_ethtool_common.h To utilize our existing ethtool code in this context, convert it to non-static. Signed-off-by: Przem

[Intel-wired-lan] [PATCH iwl-next v1 3/6] ice: add Tx hang devlink health reporter

2024-07-03 Thread Mateusz Polchlopek
From: Przemek Kitszel Add Tx hang devlink health reporter, see struct ice_tx_hang_event to see what is reported. Subsequent commits will extend it by more info, for now it dumps descriptors with little metadata. Signed-off-by: Przemek Kitszel Reviewed-by: Igor Bagnucki Reviewed-by: Wojciech D

[Intel-wired-lan] [PATCH iwl-next v1 5/6] ice: Add MDD logging via devlink health

2024-07-03 Thread Mateusz Polchlopek
From: Ben Shelton Add a devlink health reporter for MDD events. The 'dump' handler will return the information captured in each call to ice_handle_mdd_event(). A device reset (CORER/PFR) will put the reporter back in healthy state. Signed-off-by: Ben Shelton Co-developed-by: Przemek Kitszel Si

[Intel-wired-lan] [PATCH iwl-next v1 6/6] ice: devlink health: dump also skb on Tx hang

2024-07-03 Thread Mateusz Polchlopek
From: Przemek Kitszel Extend Tx hang devlink health reporter dump by skb content. This commit includes much code copy-pasted from: - net/core/skbuff.c (function skb_dump() - modified to dump into buffer) - lib/hexdump.c (function print_hex_dump()) Signed-off-by: Przemek Kitszel Reviewed-by: Wo

Re: [Intel-wired-lan] [PATCH iwl-net v1 2/4] igc: Fix reset adapter logics when tx mode change

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 12:09:24AM -0400, Faizal Rahim wrote: > Following the "igc: Fix TX Hang issue when QBV Gate is close" changes, > remaining issues with the reset adapter logic in igc_tsn_offload_apply() > have been observed: > > 1. The reset adapter logics for i225 and i226 differ, although

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/4] igc: Fix qbv_config_change_errors logics

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 12:09:23AM -0400, Faizal Rahim wrote: > When user issues these cmds: > 1. Either a) or b) >a) mqprio with hardware offload disabled >b) taprio with txtime-assist feature enabled > 2. etf > 3. tc qdisc delete > 4. taprio with base time in the past > > At step 4, qbv_

Re: [Intel-wired-lan] [PATCH iwl-net v1 3/4] igc: Remove unused qbv_count

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 12:09:25AM -0400, Faizal Rahim wrote: > Removing qbv_count which is now obsolete after these 2 patches: > "igc: Fix reset adapter logics when tx mode change" > "igc: Fix qbv_config_change_errors logics" > > The variable qbv_count serves to indicate whether Taprio is active

Re: [Intel-wired-lan] [PATCH iwl-net v1 4/4] igc: Fix qbv tx latency by setting gtxoffset

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 12:09:26AM -0400, Faizal Rahim wrote: > A large tx latency issue was discovered during testing when only QBV was > enabled. The issue occurs because gtxoffset was not set when QBV is > active, it was only set when launch time is active. > > The patch "igc: Correct the launc

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS 8905a2c7d39b921b8a62bcf80da0f8c45ec0e764

2024-07-03 Thread kernel test robot
lmodconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc haps_hs_defconfig gcc-13.2.0 arc randconfig-00

Re: [Intel-wired-lan] [PATCH iwl-next] net: intel: Remove MODULE_AUTHORs

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 02:38:46PM -0700, Tony Nguyen wrote: > We are moving away from the Sourceforge email address. Rather than > removing or updating the email for the affected entries, remove the > MODULE_AUTHOR altogether as its usage is incorrect [1]. > > Link: > https://lore.kernel.org/net

Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/7] ice: Implement ice_ptp_pin_desc

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:41:30PM +0200, Karol Kolacinski wrote: > Add a new internal structure describing PTP pins. > Use the new structure for all non-E810T products. > > Reviewed-by: Arkadiusz Kubalewski > Signed-off-by: Karol Kolacinski > --- > V1 -> V2: Removed unused err variable Reviewe

Re: [Intel-wired-lan] [PATCH v2 iwl-next 3/7] ice: Align E810T GPIO to other products

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:41:32PM +0200, Karol Kolacinski wrote: > Instead of having separate PTP GPIO implementation for E810T, use > existing one from all other products. > > Reviewed-by: Arkadiusz Kubalewski > Signed-off-by: Karol Kolacinski > --- > V1 -> V2: restored blank line and moved en

Re: [Intel-wired-lan] [PATCH v2 iwl-next 2/7] ice: Add SDPs support for E825C

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:41:31PM +0200, Karol Kolacinski wrote: > Add support of PTP SDPs (Software Definable Pins) for E825C products. > > Reviewed-by: Arkadiusz Kubalewski > Signed-off-by: Karol Kolacinski > --- > V1 -> V2: Removed redundant n_pins assignment and enable and verify move Revi

Re: [Intel-wired-lan] [PATCH v2 iwl-next 4/7] ice: Cache perout/extts requests and check flags

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:41:33PM +0200, Karol Kolacinski wrote: > Cache original PTP GPIO requests instead of saving each parameter in > internal structures for periodic output or external timestamp request. > > Factor out all periodic output register writes from ice_ptp_cfg_clkout > to a separa

Re: [Intel-wired-lan] [PATCH v2 iwl-next 5/7] ice: Disable shared pin on E810 on setfunc

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:41:34PM +0200, Karol Kolacinski wrote: > When setting a new supported function for a pin on E810, disable other > enabled pin that shares the same GPIO. > > Reviewed-by: Arkadiusz Kubalewski > Signed-off-by: Karol Kolacinski > --- > V1 -> V2: Fixed incorrect call to ic

Re: [Intel-wired-lan] [PATCH v2 iwl-next 6/7] ice: Read SDP section from NVM for pin definitions

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:41:35PM +0200, Karol Kolacinski wrote: > From: Yochai Hagvi > > PTP pins assignment and their related SDPs (Software Definable Pins) are > currently hardcoded. > Fix that by reading NVM section instead on products supporting this, > which are E810 products. > If SDP sec

Re: [Intel-wired-lan] [PATCH v2 iwl-next 7/7] ice: Enable 1PPS out from CGU for E825C products

2024-07-03 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:41:36PM +0200, Karol Kolacinski wrote: > From: Sergey Temerkhanov > > Implement configuring 1PPS signal output from CGU. Use maximal amplitude > because Linux PTP pin API does not have any way for user to set signal > level. > > This change is necessary for E825C produ

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS 5197ce65a60ab0fa778afbd8af193977c907960e

2024-07-03 Thread kernel test robot
randconfig-001-20240703 gcc-13.2.0 arc randconfig-002-20240703 gcc-13.2.0 arm allnoconfig clang-19 arm allnoconfig gcc-13.2.0 arm h3600_defconfig gcc-13.2.0 arm randconfig-001

[Intel-wired-lan] [tnguy-net-queue:100GbE] BUILD SUCCESS e5d4098a3e9331df16999d088608c38738bb8c32

2024-07-03 Thread kernel test robot
. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc-13.2.0 alpha defconfig gcc-13.2.0 arc allnoconfig gcc-13.2.0 arc randconfig-001-20240703 gcc-13.2.0

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-07-03 Thread Przemek Kitszel
On 6/28/24 09:48, Dieter Mummenschanz wrote: Hi, any chance we can upstream the patch before 6.10 goes final? At least it would fix suspend on older devices (I219-V [8086:15bc] (rev 10)). Kind Regards, Dieter would be great, do you want to add your Tested-by? On 6/21/2024 10:55 AM, Brandt,