Re: [Intel-wired-lan] [PATCH iwl-next 1/6] ice: Remove unused struct ice_prot_lkup_ext members

2024-06-28 Thread Simon Horman
On Tue, Jun 18, 2024 at 04:11:52PM +0200, Marcin Szycik wrote: > Remove field_off as it's never used. > > Remove done bitmap, as its value is only checked and never assigned. > Reusing sub-recipes while creating new root recipes is currently not > supported in the driver. > > Reviewed-by: Przemek

Re: [Intel-wired-lan] [PATCH iwl-next 2/6] ice: Remove reading all recipes before adding a new one

2024-06-28 Thread Simon Horman
On Tue, Jun 18, 2024 at 04:11:53PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > The content of the first read recipe is used as a template when adding a > recipe. It isn't needed - only prune index is directly set from there. Set > it in the code instead. Also, now there's no need t

Re: [Intel-wired-lan] [PATCH iwl-next 4/6] ice: remove unused recipe bookkeeping data

2024-06-28 Thread Simon Horman
On Tue, Jun 18, 2024 at 04:11:55PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > Remove root_buf from recipe struct. Its only usage was in ice_find_recp(), > where if recipe had an inverse action, it was skipped, but actually the > driver never adds inverse actions, so effectively it

Re: [Intel-wired-lan] [PATCH iwl-next 5/6] ice: Optimize switch recipe creation

2024-06-28 Thread Simon Horman
On Tue, Jun 18, 2024 at 04:11:56PM +0200, Marcin Szycik wrote: > Currently when creating switch recipes, switch ID is always added as the > first word in every recipe. There are only 5 words in a recipe, so one > word is always wasted. This is also true for the last recipe, which stores > result in

Re: [Intel-wired-lan] [PATCH iwl-next 6/6] ice: Remove unused members from switch API

2024-06-28 Thread Simon Horman
On Tue, Jun 18, 2024 at 04:11:57PM +0200, Marcin Szycik wrote: > Remove several members of struct ice_sw_recipe and struct > ice_prot_lkup_ext. Remove struct ice_recp_grp_entry and struct > ice_pref_recipe_group, since they are now unused as well. > > All of the deleted members were only written t

Re: [Intel-wired-lan] [PATCH iwl-next v2] igc: Get rid of spurious interrupts

2024-06-28 Thread Simon Horman
On Fri, Jun 21, 2024 at 08:56:30AM +0200, Kurt Kanzenbach wrote: > When running the igc with XDP/ZC in busy polling mode with deferral of hard > interrupts, interrupts still happen from time to time. That is caused by > the igc task watchdog which triggers Rx interrupts periodically. > > That mech

Re: [Intel-wired-lan] [PATCH iwl-next 5/6] ice: Optimize switch recipe creation

2024-06-28 Thread Marcin Szycik
On 28.06.2024 14:44, Simon Horman wrote: > On Tue, Jun 18, 2024 at 04:11:56PM +0200, Marcin Szycik wrote: >> Currently when creating switch recipes, switch ID is always added as the >> first word in every recipe. There are only 5 words in a recipe, so one >> word is always wasted. This is also t

Re: [Intel-wired-lan] [PATCH iwl-next 5/6] ice: Optimize switch recipe creation

2024-06-28 Thread Przemek Kitszel
On 6/28/24 14:44, Simon Horman wrote: On Tue, Jun 18, 2024 at 04:11:56PM +0200, Marcin Szycik wrote: Currently when creating switch recipes, switch ID is always added as the first word in every recipe. There are only 5 words in a recipe, so one word is always wasted. This is also true for the la

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-28 Thread Dieter Mummenschanz
Hi,   any chance we can upstream the patch before 6.10 goes final? At least it would fix suspend on older devices (I219-V [8086:15bc] (rev 10)).    Kind Regards, Dieter     Gesendet: Sonntag, 23. Juni 2024 um 09:40 Uhr Von: "Lifshits, Vitaly" An: "Brandt, Todd E" , "intel-wired-lan@osuosl.o

[Intel-wired-lan] [tnguy-net-queue:100GbE] BUILD SUCCESS dd4e0107549c7b891871678661cfb90ea2d8a071

2024-06-28 Thread kernel test robot
arc allyesconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240628 gcc-13.2.0 arc randconfig-002-20240628 gcc-13.2.0 arm allmodconfig gcc-13.2.0 arm

Re: [Intel-wired-lan] [PATCH iwl-next 5/6] ice: Optimize switch recipe creation

2024-06-28 Thread Simon Horman
On Fri, Jun 28, 2024 at 03:39:27PM +0200, Marcin Szycik wrote: > > > On 28.06.2024 14:44, Simon Horman wrote: > > On Tue, Jun 18, 2024 at 04:11:56PM +0200, Marcin Szycik wrote: > >> Currently when creating switch recipes, switch ID is always added as the > >> first word in every recipe. There are

Re: [Intel-wired-lan] [PATCH iwl-next 5/6] ice: Optimize switch recipe creation

2024-06-28 Thread Simon Horman
On Fri, Jun 28, 2024 at 03:56:55PM +0200, Przemek Kitszel wrote: > On 6/28/24 14:44, Simon Horman wrote: > > On Tue, Jun 18, 2024 at 04:11:56PM +0200, Marcin Szycik wrote: ... > > I appreciate the detailed description above, it is very helpful. > > After a number of readings of this patch - it is

Re: [Intel-wired-lan] [PATCH iwl-next v3 7/7] ice: Add tracepoint for adding and removing switch rules

2024-06-28 Thread Simon Horman
On Thu, Jun 27, 2024 at 04:55:47PM +0200, Marcin Szycik wrote: > Track the number of rules and recipes added to switch. Add a tracepoint to > ice_aq_sw_rules(), which shows both rule and recipe count. This information > can be helpful when designing a set of rules to program to the hardware, as > i