[Intel-wired-lan] [PATCH iwl-next v3] igc: Add MQPRIO offload support

2024-06-21 Thread Kurt Kanzenbach
Add support for offloading MQPRIO. The hardware has four priorities as well as four queues. Each queue must be a assigned with a unique priority. However, the priorities are only considered in TSN Tx mode. There are two TSN Tx modes. In case of MQPRIO the Qbv capability is not required. Therefore,

[Intel-wired-lan] [RFC PATCH iwl-next v1 1/4] ice: Introduce ice_get_phy_model() wrapper

2024-06-21 Thread Sergey Temerkhanov
Introduce ice_get_phy_model() to improve code readability Reviewed-by: Przemek Kitszel Signed-off-by: Sergey Temerkhanov --- drivers/net/ethernet/intel/ice/ice.h| 5 + drivers/net/ethernet/intel/ice/ice_ptp.c| 18 - drivers/net/ethernet/intel/ice/ice_ptp_hw.c |

[Intel-wired-lan] [RFC PATCH iwl-next v1 0/4] Replace auxbus with ice_adapter in the PTP support code

2024-06-21 Thread Sergey Temerkhanov
This series replaces multiple aux buses and devices used in the PTP support code with struct ice_adapter holding the necessary shared data Patches 1,2 add convenience wrappers Patch 3 does the main refactoring Patch 4 finalizes the refactoring Sergey Temerkhanov (4): ice: Introduce ice_get_phy_

[Intel-wired-lan] [RFC PATCH iwl-next v1 2/4] ice: Add ice_get_ctrl_ptp() wrapper to simplify the code

2024-06-21 Thread Sergey Temerkhanov
Add ice_get_ctrl_ptp() wrapper to simplify the PTP support code in the functions that do not use ctrl_pf directly Reviewed-by: Przemek Kitszel Signed-off-by: Sergey Temerkhanov --- drivers/net/ethernet/intel/ice/ice_ptp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers

[Intel-wired-lan] [RFC PATCH iwl-next v1 3/4] ice: Use ice_adapter for PTP shared data instead of auxdev

2024-06-21 Thread Sergey Temerkhanov
- Use struct ice_adapter to hold shared PTP data and control PTP related actions instead of auxbus. This allows significant code simplification and faster access to the container fields used in the PTP support code. - Move the PTP port list to the ice_adapter container to simplify the code and avo

[Intel-wired-lan] [RFC PATCH iwl-next v1 4/4] ice: Drop auxbus use for PTP to finalize ice_adapter move

2024-06-21 Thread Sergey Temerkhanov
Drop unused auxbus/auxdev support from the PTP code due to move to the ice_adapter. Reviewed-by: Przemek Kitszel Signed-off-by: Sergey Temerkhanov --- drivers/net/ethernet/intel/ice/ice_ptp.c | 265 --- 1 file changed, 265 deletions(-) diff --git a/drivers/net/ethernet/inte

Re: [Intel-wired-lan] [RFC net-next 5/9] ice: apply XDP offloading fixup when building skb

2024-06-21 Thread Alexander Lobakin
From: Yan Zhai Date: Thu, 20 Jun 2024 15:19:22 -0700 > Add a common point to transfer offloading info from XDP context to skb. > > Signed-off-by: Yan Zhai > Signed-off-by: Jesper Dangaard Brouer > --- > drivers/net/ethernet/intel/ice/ice_txrx.c | 2 ++ > drivers/net/ethernet/intel/ice/ice_xsk

Re: [Intel-wired-lan] [PATCH iwl-next v3] igc: Add MQPRIO offload support

2024-06-21 Thread Wojciech Drewek
On 21.06.2024 09:25, Kurt Kanzenbach wrote: > Add support for offloading MQPRIO. The hardware has four priorities as well > as four queues. Each queue must be a assigned with a unique priority. > > However, the priorities are only considered in TSN Tx mode. There are two > TSN Tx modes. In case

Re: [Intel-wired-lan] [PATCH v2 iwl-net 3/3] ice: Reject pin requests with unsupported flags

2024-06-21 Thread Simon Horman
On Thu, Jun 20, 2024 at 02:27:10PM +0200, Karol Kolacinski wrote: > From: Jacob Keller > > The driver receives requests for configuring pins via the .enable > callback of the PTP clock object. These requests come into the driver > with flags which modify the requested behavior from userspace. Cur

Re: [Intel-wired-lan] [PATCH v2 iwl-net 2/3] ice: Don't process extts if PTP is disabled

2024-06-21 Thread Simon Horman
On Thu, Jun 20, 2024 at 02:27:09PM +0200, Karol Kolacinski wrote: > From: Jacob Keller > > The ice_ptp_extts_event() function can race with ice_ptp_release() and > result in a NULL pointer dereference which leads to a kernel panic. > > Panic occurs because the ice_ptp_extts_event() function call

Re: [Intel-wired-lan] [PATCH v2 iwl-net 1/3] ice: Fix improper extts handling

2024-06-21 Thread Simon Horman
On Thu, Jun 20, 2024 at 02:27:08PM +0200, Karol Kolacinski wrote: > From: Milena Olech > > Extts events are disabled and enabled by the application ts2phc. > However, in case where the driver is removed when the application is > running, channel remains enabled. As a result, in the next run of th

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-21 Thread Brandt, Todd E
I just built and tested your patch on the latest 6.10.0-rc3 tip. It seems to have fixed the issue on three of our machines, but the issue still occurs on our Meteor Lake SDV board (otcpl-mtl-s). [ 130.302511] e1000e: EEE TX LPI TIMER: 0011 [ 130.390014] e1000e :80:1f.6: PM: pci_pm_susp

Re: [Intel-wired-lan] [PATCH iwl-next v7 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors

2024-06-21 Thread Alexander Lobakin
From: Alexander Lobakin Date: Wed, 12 Jun 2024 14:33:17 +0200 > From: Jacob Keller > Date: Tue, 11 Jun 2024 13:52:57 -0700 > >> >> >> On 6/11/2024 4:47 AM, Alexander Lobakin wrote: >>> From: Mateusz Polchlopek >>> Date: Tue, 4 Jun 2024 09:13:57 -0400 >>> From: Jacob Keller Usi

Re: [Intel-wired-lan] [PATCH iwl-next v7 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors

2024-06-21 Thread Tony Nguyen
On 6/21/2024 7:21 AM, Alexander Lobakin wrote: From: Alexander Lobakin Date: Wed, 12 Jun 2024 14:33:17 +0200 From: Jacob Keller Date: Tue, 11 Jun 2024 13:52:57 -0700 On 6/11/2024 4:47 AM, Alexander Lobakin wrote: From: Mateusz Polchlopek Date: Tue, 4 Jun 2024 09:13:57 -0400 From:

Re: [Intel-wired-lan] [RFC net-next 5/9] ice: apply XDP offloading fixup when building skb

2024-06-21 Thread Yan Zhai
On Fri, Jun 21, 2024 at 4:22 AM Alexander Lobakin wrote: > > From: Yan Zhai > Date: Thu, 20 Jun 2024 15:19:22 -0700 > > > Add a common point to transfer offloading info from XDP context to skb. > > > > Signed-off-by: Yan Zhai > > Signed-off-by: Jesper Dangaard Brouer > > --- > > drivers/net/et

Re: [Intel-wired-lan] [intel-next 1/2] net/i40e: link NAPI instances to queues and IRQs

2024-06-21 Thread Joe Damato
On Mon, Apr 15, 2024 at 09:37:09AM -0700, Tony Nguyen wrote: > > > On 4/13/2024 12:24 PM, Joe Damato wrote: > > On Thu, Apr 11, 2024 at 04:02:37PM -0700, Nambiar, Amritha wrote: > > > On 4/10/2024 4:43 PM, Joe Damato wrote: > > > > On Wed, Apr 10, 2024 at 02:10:52AM -0700, Nambiar, Amritha wrote:

Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values

2024-06-21 Thread Samal, Anil
Hi Simon, Serdes equalizer parameters are raw hex values and it is not useful to end user. It is only useful to engineer who is familiar with serdes/ physical lane. So we decided not to implement it as new ethtool option. Thanks Anil Kumar Samal -Original Message- From: Simon Horman