Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Rebuild TC queues on VSI queue reconfiguration

2024-06-19 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karen > Ostrowska > Sent: Wednesday, May 29, 2024 12:48 PM > To: intel-wired-...@lists.osuosl.org > Cc: Ostrowska, Karen ; net...@vger.kernel.org; > Sokolowski, Jan ; Drewek, Wojciech > > Subject: [Intel-wired-lan] [PATCH iwl-ne

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix force smbus during suspend flow

2024-06-19 Thread Lifshits, Vitaly
Hi Hui, On 6/14/2024 4:53 AM, Hui Wang wrote: Hi Vitaly I tested the patch on a laptop with the ethernet card [8086:550A], the system suspend and resume worked well with the cable plugged or unplugged. But I still think that reverting 2 regression commits is a better solution. Reverting th

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix force smbus during suspend flow

2024-06-19 Thread Hui Wang
On 6/19/24 20:17, Lifshits, Vitaly wrote: Hi Hui, On 6/14/2024 4:53 AM, Hui Wang wrote: Hi Vitaly I tested the patch on a laptop with the ethernet card [8086:550A], the system suspend and resume worked well with the cable plugged or unplugged. But I still think that reverting 2 regressi

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: do not init struct ice_adapter more times than needed

2024-06-19 Thread Michal Schmidt
On Mon, Jun 17, 2024 at 3:25 PM Przemek Kitszel wrote: > Allocate and initialize struct ice_adapter object only once per physical > card instead of once per port. This is not a big deal by now, but we want > to extend this struct more and more in the near future. Our plans include > PTP stuff and

Re: [Intel-wired-lan] [PATCH iwl-next 3/6] ice: Simplify bitmap setting in adding recipe

2024-06-19 Thread Alexander Lobakin
From: Marcin Szycik Date: Tue, 18 Jun 2024 16:11:54 +0200 > From: Michal Swiatkowski > > Remove unnecessary size checks when copying bitmaps in ice_add_sw_recipe() > and replace them with compile time assert. Check if the bitmaps are equal > size, as they are copied both ways. > > Signed-off-b

Re: [Intel-wired-lan] [RFC net-next (what uAPI?) ice: add support for more than 16 RSS queues for VF

2024-06-19 Thread Przemek Kitszel
On 5/6/24 16:34, Przemek Kitszel wrote: On 4/30/24 03:59, Jakub Kicinski wrote: On Fri, 26 Apr 2024 15:22:02 +0200 Przemek Kitszel wrote: ## devlink resources (with current API) `devlink resource` is compelling, partially given the name sounds like a perfect match. But when we dig just a little

Re: [Intel-wired-lan] [PATCH iwl-net 2/3] ice: Don't process extts if PTP is disabled

2024-06-19 Thread Simon Horman
On Tue, Jun 18, 2024 at 12:41:37PM +0200, Karol Kolacinski wrote: > From: Jacob Keller > > The ice_ptp_extts_event() function can race with ice_ptp_release() and > result in a NULL pointer dereference which leads to a kernel panic. > > Panic occurs because the ice_ptp_extts_event() function call

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: Fix improper extts handling

2024-06-19 Thread Simon Horman
On Tue, Jun 18, 2024 at 12:41:36PM +0200, Karol Kolacinski wrote: > From: Milena Olech > > Extts events are disabled and enabled by the application ts2phc. > However, in case where the driver is removed when the application is > running, channel remains enabled. As a result, in the next run of th

Re: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: Reject pin requests with unsupported flags

2024-06-19 Thread Simon Horman
On Tue, Jun 18, 2024 at 12:41:38PM +0200, Karol Kolacinski wrote: > From: Jacob Keller > > The driver receives requests for configuring pins via the .enable > callback of the PTP clock object. These requests come into the driver > with flags which modify the requested behavior from userspace. Cur

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD REGRESSION 0edf6b789635c79b4c2db5d6bab907d4cb26823e

2024-06-19 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue branch HEAD: 0edf6b789635c79b4c2db5d6bab907d4cb26823e ice: Distinguish driver reset and removal for AQ shutdown Error/Warning ids grouped by kconfigs: clang_recent_errors `-- x86_64-buildonly-randconfig

Re: [Intel-wired-lan] [RFC PATCH iwl-next v1 2/4] ice: Add ice_get_ctrl_ptp() wrapper to simplify the code

2024-06-19 Thread Michal Schmidt
On Tue, Jun 18, 2024 at 3:53 PM Sergey Temerkhanov wrote: > Add ice_get_ctrl_ptp() wrapper to simplify the PTP support code > in the functions that do not use ctrl_pf directly > > Reviewed-by: Przemek Kitszel > Signed-off-by: Sergey Temerkhanov > --- > drivers/net/ethernet/intel/ice/ice_ptp.c |

Re: [Intel-wired-lan] [RFC PATCH iwl-next v1 3/4] ice: Use ice_adapter for PTP shared data instead of auxdev

2024-06-19 Thread Michal Schmidt
On Tue, Jun 18, 2024 at 3:59 PM Sergey Temerkhanov wrote: > - Use struct ice_adapter to hold shared PTP data and control PTP > related actions instead of auxbus. This allows significant code > simplification and faster access to the container fields used in > the PTP support code. > > - Move the P

[Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-19 Thread Vitaly Lifshits
Commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") resolved a PHY access loss during suspend on Meteor Lake consumer platforms, but it affected corporate systems incorrectly. A better fix, working for both consumer and corporate systems, was proposed

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-19 Thread Paul Menzel
Dear Vitaly, Thank you for your patch. For the summary, it’d be great if you could be more specific by saying it’s about limiting the scope. Am 20.06.24 um 08:36 schrieb Vitaly Lifshits: Commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") resolve