Re: [Intel-wired-lan] [PATCH iwl-next 11/12] idpf: convert header split mode to libeth + napi_build_skb()

2024-06-17 Thread Alexander Lobakin
From: Willem De Bruijn Date: Thu, 30 May 2024 09:46:46 -0400 > Alexander Lobakin wrote: >> Currently, idpf uses the following model for the header buffers: >> >> * buffers are allocated via dma_alloc_coherent(); >> * when receiving, napi_alloc_skb() is called and then the header is >> copied to

Re: [Intel-wired-lan] [PATCH iwl-next] ice: Add a per-VF limit on number of FDIR filters

2024-06-17 Thread Wojciech Drewek
On 14.06.2024 15:18, Ahmed Zaki wrote: > While the iavf driver adds a s/w limit (128) on the number of FDIR > filters that the VF can request, a malicious VF driver can request more > than that and exhaust the resources for other VFs. > > Add a similar limit in ice. > > CC: sta...@vger.kernel.

Re: [Intel-wired-lan] [PATCH net v2] ice: use proper macro for testing bit

2024-06-17 Thread Alexander Lobakin
From: Simon Horman Date: Sat, 15 Jun 2024 16:16:41 +0100 > On Fri, Jun 14, 2024 at 11:43:38AM +0200, Petr Oros wrote: >> Do not use _test_bit() macro for testing bit. The proper macro for this >> is one without underline. > > Hi Petr, > > it might be nice to include a brief explanation as to >

[Intel-wired-lan] [PATCH net-next v8 04/13] mm: page_frag: add '_va' suffix to page_frag API

2024-06-17 Thread Yunsheng Lin
Currently the page_frag API is returning 'virtual address' or 'va' when allocing and expecting 'virtual address' or 'va' as input when freeing. As we are about to support new use cases that the caller need to deal with 'struct page' or need to deal with both 'va' and 'struct page'. In order to dif

[Intel-wired-lan] [PATCH iwl-next v1] ice: do not init struct ice_adapter more times than needed

2024-06-17 Thread Przemek Kitszel
Allocate and initialize struct ice_adapter object only once per physical card instead of once per port. This is not a big deal by now, but we want to extend this struct more and more in the near future. Our plans include PTP stuff and a devlink instance representing whole-device/physical card. Tra

Re: [Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset and removal for AQ shutdown

2024-06-17 Thread Simon Horman
On Fri, Jun 14, 2024 at 12:38:11PM +0200, Marcin Szycik wrote: > From: Piotr Gardocki > > Admin queue command for shutdown AQ contains a flag to indicate driver > unload. However, the flag is always set in the driver, even for resets. It > can cause the firmware to consider driver as unloaded onc

Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values

2024-06-17 Thread Simon Horman
On Fri, Jun 14, 2024 at 05:55:59PM -0700, Jakub Kicinski wrote: > On Fri, 14 Jun 2024 05:58:17 -0700 Anil Samal wrote: > > To debug link issues in the field, serdes Tx/Rx equalizer values > > help to determine the health of serdes lane. > > > > Extend 'ethtool -d' option to dump serdes Tx/Rx equal

Re: [Intel-wired-lan] [PATCH iwl-next 11/12] idpf: convert header split mode to libeth + napi_build_skb()

2024-06-17 Thread Willem de Bruijn
Alexander Lobakin wrote: > From: Willem De Bruijn > Date: Thu, 30 May 2024 09:46:46 -0400 > > > Alexander Lobakin wrote: > >> Currently, idpf uses the following model for the header buffers: > >> > >> * buffers are allocated via dma_alloc_coherent(); > >> * when receiving, napi_alloc_skb() is cal

Re: [Intel-wired-lan] [PATCH net v2] ice: use proper macro for testing bit

2024-06-17 Thread Simon Horman
On Mon, Jun 17, 2024 at 02:58:59PM +0200, Alexander Lobakin wrote: > From: Simon Horman > Date: Sat, 15 Jun 2024 16:16:41 +0100 > > > On Fri, Jun 14, 2024 at 11:43:38AM +0200, Petr Oros wrote: > >> Do not use _test_bit() macro for testing bit. The proper macro for this > >> is one without underli

[Intel-wired-lan] [PATCH iwl-next v1] MAINTAINERS: update Intel Ethernet maintainers

2024-06-17 Thread Jesse Brandeburg
Since Jesse has moved to a new role, replace him with a new maintainer to work with Tony on representing Intel networking drivers in the kernel. Cc: Przemek Kitszel Signed-off-by: Jesse Brandeburg --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/

Re: [Intel-wired-lan] [PATCH iwl-next v1] MAINTAINERS: update Intel Ethernet maintainers

2024-06-17 Thread Paul Menzel
Dear Jesse, Am 17.06.24 um 21:07 schrieb Jesse Brandeburg: Since Jesse has moved to a new role, replace him with a new maintainer to work with Tony on representing Intel networking drivers in the kernel. Maybe add the names to the summary/title: MAINTAINERS: Intel Ethernet: Replace Jesse Bra

Re: [Intel-wired-lan] [PATCH iwl-next v1] MAINTAINERS: update Intel Ethernet maintainers

2024-06-17 Thread Jesse Brandeburg
On 6/17/2024 1:29 PM, Paul Menzel wrote: > Dear Jesse, > > > Am 17.06.24 um 21:07 schrieb Jesse Brandeburg: >> Since Jesse has moved to a new role, replace him with a new maintainer >> to work with Tony on representing Intel networking drivers in the >> kernel. > > Maybe add the names to the sum

Re: [Intel-wired-lan] [PATCH iwl-next v1] MAINTAINERS: update Intel Ethernet maintainers

2024-06-17 Thread Paul Menzel
Dear Jesse, Am 17.06.24 um 23:19 schrieb Jesse Brandeburg: On 6/17/2024 1:29 PM, Paul Menzel wrote: Am 17.06.24 um 21:07 schrieb Jesse Brandeburg: Since Jesse has moved to a new role, replace him with a new maintainer to work with Tony on representing Intel networking drivers in the kernel.

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Fix VSI list rule with ICE_SW_LKUP_LAST type

2024-06-17 Thread Buvaneswaran, Sujai
> -Original Message- > From: Intel-wired-lan On Behalf Of > Marcin Szycik > Sent: Wednesday, June 5, 2024 7:48 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Marcin Szycik ; > Kitszel, Przemyslaw ; Michal Swiatkowski > > Subject: [Intel-wired-lan] [PATCH iwl-net]