On Thu, May 09, 2024 at 01:06:52PM +0200, Jiri Pirko wrote:
> Tue, May 07, 2024 at 01:45:04PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >From: Piotr Raczynski
> >
> >Implement devlink port handlers responsible for ethernet type devlink
> >subfunctions. Create subfunction devlink port an
On Thu, May 09, 2024 at 01:13:55PM +0200, Jiri Pirko wrote:
> Tue, May 07, 2024 at 01:45:07PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >From: Piotr Raczynski
> >
> >Implement subfunction driver. It is probe when subfunction port is
> >activated.
> >
> >VSI is already created. During th
On Thu, May 09, 2024 at 01:18:29PM +0200, Jiri Pirko wrote:
> Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >Hi,
> >
> >Currently ice driver does not allow creating more than one networking
> >device per physical function. The only way to have more hardware ba
On Thu, May 09, 2024 at 01:17:26PM +0200, Jiri Pirko wrote:
> Subject does not have verb. Please add it.
>
> Otherwise, the patch looks ok.
Thanks, will add sth like "implement".
>
> Reviewed-by: Jiri Pirko
>
>
>
> Tue, May 07, 2024 at 01:45:12PM CEST, michal.swiatkow...@linux.intel.com
>
On Thu, May 09, 2024 at 01:16:05PM +0200, Jiri Pirko wrote:
> Tue, May 07, 2024 at 01:45:09PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >Store subfunction and VF pointer in port representor structure as an
> >union. Add port representor type to distinguish between each of them.
> >
> >Ke
On Thu, May 09, 2024 at 01:36:13PM +0200, Jiri Pirko wrote:
> Tue, May 07, 2024 at 01:45:15PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >From: Piotr Raczynski
> >
> >Use previously implemented SF aux driver. It is probe during SF
> >activation and remove after deactivation.
> >
> >Signe
On 09/05/2024 16:46, Andrew Lunn wrote:
On Thu, May 09, 2024 at 12:13:27PM +0300, Ruinskiy, Dima wrote:
On 08/05/2024 8:05, Sasha Neftin wrote:
On 07/05/2024 15:31, Andrew Lunn wrote:
On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote:
As described in https://bugzilla.kernel.org/show_bu
On Wed, May 08, 2024 at 08:06:04PM +0800, Hui Wang wrote:
> The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp
> function to avoid PHY loss issue") introduces a regression on
> CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without the referred commit, the
> ethernet works well after suspend
Fri, May 10, 2024 at 09:13:51AM CEST, michal.swiatkow...@linux.intel.com wrote:
>On Thu, May 09, 2024 at 01:06:52PM +0200, Jiri Pirko wrote:
>> Tue, May 07, 2024 at 01:45:04PM CEST, michal.swiatkow...@linux.intel.com
>> wrote:
>> >From: Piotr Raczynski
>> >
>> >Implement devlink port handlers res
Fri, May 10, 2024 at 09:20:51AM CEST, michal.swiatkow...@linux.intel.com wrote:
>On Thu, May 09, 2024 at 01:13:55PM +0200, Jiri Pirko wrote:
>> Tue, May 07, 2024 at 01:45:07PM CEST, michal.swiatkow...@linux.intel.com
>> wrote:
>> >From: Piotr Raczynski
>> >
>> >Implement subfunction driver. It is
Fri, May 10, 2024 at 09:31:15AM CEST, michal.swiatkow...@linux.intel.com wrote:
>On Thu, May 09, 2024 at 01:16:05PM +0200, Jiri Pirko wrote:
>> Tue, May 07, 2024 at 01:45:09PM CEST, michal.swiatkow...@linux.intel.com
>> wrote:
>> >Store subfunction and VF pointer in port representor structure as a
Fri, May 10, 2024 at 09:33:54AM CEST, michal.swiatkow...@linux.intel.com wrote:
>On Thu, May 09, 2024 at 01:36:13PM +0200, Jiri Pirko wrote:
>> Tue, May 07, 2024 at 01:45:15PM CEST, michal.swiatkow...@linux.intel.com
>> wrote:
>> >From: Piotr Raczynski
>> >
>> >Use previously implemented SF aux d
Fri, May 10, 2024 at 09:24:48AM CEST, michal.swiatkow...@linux.intel.com wrote:
>On Thu, May 09, 2024 at 01:18:29PM +0200, Jiri Pirko wrote:
>> Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkow...@linux.intel.com
>> wrote:
>> >Hi,
>> >
>> >Currently ice driver does not allow creating more than
On Fri, May 10, 2024 at 01:05:33PM +0200, Jiri Pirko wrote:
> Fri, May 10, 2024 at 09:13:51AM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >On Thu, May 09, 2024 at 01:06:52PM +0200, Jiri Pirko wrote:
> >> Tue, May 07, 2024 at 01:45:04PM CEST, michal.swiatkow...@linux.intel.com
> >> wrote:
On Fri, May 10, 2024 at 01:07:44PM +0200, Jiri Pirko wrote:
> Fri, May 10, 2024 at 09:31:15AM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >On Thu, May 09, 2024 at 01:16:05PM +0200, Jiri Pirko wrote:
> >> Tue, May 07, 2024 at 01:45:09PM CEST, michal.swiatkow...@linux.intel.com
> >> wrote:
On Fri, May 10, 2024 at 01:09:20PM +0200, Jiri Pirko wrote:
> Fri, May 10, 2024 at 09:24:48AM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >On Thu, May 09, 2024 at 01:18:29PM +0200, Jiri Pirko wrote:
> >> Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkow...@linux.intel.com
> >> wrote:
> > It would be interesting to see what the link partner sees. What does
> > it think the I219-LM is advertising? Is it advertising 1000BaseT_Half?
>
> i219 parts come with LSI PHY. 1000BASE-T half-duplex is not supported.
> 1000BASET half-duplex not advertised in IEEE 1000BASE-T Control Register
defconfig clang
i386 allmodconfig gcc
i386 allnoconfig gcc
i386 allyesconfig gcc
i386 buildonly-randconfig-001-20240510 clang
i386 buildonly-randconfig-002
On Thu, May 09, 2024 at 04:38:49AM +, D, Lakshmi Sowjanya wrote:
> Will update as suggested.
Just a side note: Since the series most likely missed v6.10, don't forget to
bump dates and versions in ABI documentation in the next version.
--
With Best Regards,
Andy Shevchenko
Implementation to dump PHY configuration and FEC statistics to
facilitate link level debugging of customer issues. Implementation has
two parts
a. Serdes equalization
# ethtool -d eth0
Output:
Offset Values
-- --
0x:
Current driver implementation for Sideband Queue supports a
fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from
firmware, Sideband Queue command is used with a different flag.
Extend API for Sideband Queue command to use 'flag' as input
argument.
Reviewed-by: Anthony L Nguyen
Reviewed-b
To debug link issues in the field, it is paramount to
dump fec corrected/uncorrected block counts from firmware.
Firmware requires PCS quad number and PCS port number to
read FEC statistics. Current driver implementation does
not maintain above physical properties of a port.
Add new driver API to
To debug link issues in the field, serdes Tx/Rx equalizer values
help to determine the health of serdes lane.
Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer.
The following list of equalizer param is supported
a. rx_equalization_pre2
b. rx_equalization_pre1
c. rx_equalization
Applies on top of "idpf: don't enable NAPI and interrupts prior to
allocating Rx buffers" from Tony's tree.
Sent as RFC as we're at the end of the development cycle and several
kdocs are messed up. I'll fix them when sending non-RFC after the window
opens.
XDP for idpf is currently 5 chapters:
* c
Following the latest netdev trend, i.e. effective and usage-based field
cacheline placement, add helpers to group and then assert struct fields
by cachelines.
For 64-bit with 64-byte cachelines, the assertions are more strict as
the size can then be easily predicted. For the rest, just make sure
th
In C, we have structures and unions.
Casting `void *` via macros is not only error-prone, but also looks
confusing and awful in general.
In preparation for splitting the queue structs, replace it with a
union and direct array dereferences.
Signed-off-by: Alexander Lobakin
---
drivers/net/etherne
With CONFIG_MAXSMP, sizeof(cpumask_t) is 1 Kb. The queue vector
structure has them embedded, which means 1 additional Kb of not
really hotpath data.
We have cpumask_var_t, which is either an embedded cpumask or a pointer
for allocating it dynamically when it's big. Use it instead of plain
cpumasks
Now that the queue and queue vector structures are separated and layed
out optimally, group the fields as read-mostly, read-write, and cold
cachelines and add size assertions to make sure new features won't push
something out of its place and provoke perf regression.
Despite looking innocent, this
It makes no sense to have a second &net_device_ops struct (800 bytes of
rodata) with only one difference in .ndo_start_xmit, which can easily
be just one `if`. This `if` is a drop in the ocean and you won't see
any difference.
Define unified idpf_xmit_start(). The preparation for sending is the
sam
Currently, there's no HW supporting idpf in the singleq model. Still,
this dead code is supported by the driver and often times add hotpath
branches and redundant cacheline accesses.
While it can't currently be removed, add CONFIG_IDPF_SINGLEQ and build
the singleq code only when it's enabled manua
Page Pool Ethtool stats are deprecated since the Netlink Page Pool
interface introduction.
idpf receives big changes in Rx buffer management, including &page_pool
layout, so keeping these deprecated stats does only harm, not speaking
of that CONFIG_IDPF selects CONFIG_PAGE_POOL_STATS unconditionall
idpf's in-kernel parsed ptype structure is almost identical to the one
used in the previous Intel drivers, which means it can be converted to
use libeth's definitions and even helpers. The only difference is that
it doesn't use a constant table (libie), rather than one obtained from
the device.
Rem
Unlike previous generations, idpf requires more buffer types for optimal
performance. This includes: header buffers, short buffers, and
no-overhead buffers (w/o headroom and tailroom, for TCP zerocopy when
the header split is enabled).
Introduce libeth Rx buffer type and calculate page_pool params
Currently, idpf uses the following model for the header buffers:
* buffers are allocated via dma_alloc_coherent();
* when receiving, napi_alloc_skb() is called and then the header is
copied to the newly allocated linear part.
This is far from optimal as DMA coherent zone is slow on many systems
idpf uses Page Pool for data buffers with hardcoded buffer lengths of
4k for "classic" buffers and 2k for "short" ones. This is not flexible
and does not ensure optimal memory usage. Why would you need 4k buffers
when the MTU is 1500?
Use libeth for the data buffers and don't hardcode any buffer si
Currently, sizeof(struct idpf_queue) is 32 Kb.
This is due to the 12-bit hashtable declaration at the end of the queue.
This HT is needed only for Tx queues when the flow scheduling mode is
enabled. But &idpf_queue is unified for all of the queue types,
provoking excessive memory usage.
The unified
On Fri, May 10, 2024 at 8:30 AM Alexander Lobakin
wrote:
>
> idpf's in-kernel parsed ptype structure is almost identical to the one
> used in the previous Intel drivers, which means it can be converted to
> use libeth's definitions and even helpers. The only difference is that
> it doesn't use a c
37 matches
Mail list logo
