[Intel-wired-lan] [PATCH net-next v4 0/7] i40e: cleanups & refactors

2024-04-27 Thread Ivan Vecera
This series do following: Patch 1 - Removes write-only flags field from i40e_veb structure and from i40e_veb_setup() parameters Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes() and i40e_notify_client_of_netdev_close() Patch 3 - Refactors parameter of i40

[Intel-wired-lan] [PATCH net-next v4 1/7] i40e: Remove flags field from i40e_veb

2024-04-27 Thread Ivan Vecera
The field is initialized always to zero and it is never read. Remove it. Reviewed-by: Michal Schmidt Reviewed-by: Aleksandr Loktionov Reviewed-by: Kalesh AP Reviewed-by: Tony Nguyen Tested-by: Pucha Himasekhar Reddy Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h

[Intel-wired-lan] [PATCH net-next v4 2/7] i40e: Refactor argument of several client notification functions

2024-04-27 Thread Ivan Vecera
Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified the client interface so in practice it supports only one client per i40e netdev. But we have still 2 notification functions that uses as parameter a pointer to VSI of netdevice associated with the client. After the mentioned commit

[Intel-wired-lan] [PATCH net-next v4 3/7] i40e: Refactor argument of i40e_detect_recover_hung()

2024-04-27 Thread Ivan Vecera
Commit 07d44190a389 ("i40e/i40evf: Detect and recover hung queue scenario") changes i40e_detect_recover_hung() argument type from i40e_pf* to i40e_vsi* to be shareable by both i40e and i40evf. Because the i40evf does not exist anymore and the function is exclusively used by i40e we can revert this

[Intel-wired-lan] [PATCH net-next v4 4/7] i40e: Add helper to access main VSI

2024-04-27 Thread Ivan Vecera
Add simple helper i40e_pf_get_main_vsi(pf) to access main VSI that replaces pattern 'pf->vsi[pf->lan_vsi]' Reviewed-by: Michal Schmidt Reviewed-by: Tony Nguyen Tested-by: Pucha Himasekhar Reddy Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 11 ++ drivers/net/

[Intel-wired-lan] [PATCH net-next v4 5/7] i40e: Consolidate checks whether given VSI is main

2024-04-27 Thread Ivan Vecera
In the driver code there are 3 types of checks whether given VSI is main or not: 1. vsi->type ==/!= I40E_VSI_MAIN 2. vsi ==/!= pf->vsi[pf->lan_vsi] 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid All of them are equivalent and can be consolidated. Convert cases 2 and 3 to case 1. Reviewed-by: Micha

[Intel-wired-lan] [PATCH net-next v4 7/7] i40e: Add and use helper to reconfigure TC for given VSI

2024-04-27 Thread Ivan Vecera
Add helper i40e_vsi_reconfig_tc(vsi) that configures TC for given VSI using previously stored TC bitmap. Effectively replaces open-coded patterns: enabled_tc = vsi->tc_config.enabled_tc; vsi->tc_config.enabled_tc = 0; i40e_vsi_config_tc(vsi, enabled_tc); Reviewed-by: Michal Schmidt Reviewed-by:

[Intel-wired-lan] [PATCH net-next v4 6/7] i40e: Add helper to access main VEB

2024-04-27 Thread Ivan Vecera
Add a helper to access main VEB: i40e_pf_get_main_veb(pf) replaces 'pf->veb[pf->lan_veb]' Reviewed-by: Michal Schmidt Reviewed-by: Aleksandr Loktionov Reviewed-by: Tony Nguyen Tested-by: Pucha Himasekhar Reddy Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 11

Re: [Intel-wired-lan] [BUG] e1000e, scheduling while atomic (stable)

2024-04-27 Thread Greg KH
On Sat, Apr 27, 2024 at 10:54:23AM +, Artem S. Tashkinov wrote: > Hello, > > This fix is still not queued in 6.8 stable: What fix? > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.8 > > Why? What is the git id of the change in Linus's tree? thanks, g

Re: [Intel-wired-lan] [PATCH net-next v4 1/7] i40e: Remove flags field from i40e_veb

2024-04-27 Thread Simon Horman
On Sat, Apr 27, 2024 at 09:26:02AM +0200, Ivan Vecera wrote: > The field is initialized always to zero and it is never read. > Remove it. > > Reviewed-by: Michal Schmidt > Reviewed-by: Aleksandr Loktionov > Reviewed-by: Kalesh AP > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy

Re: [Intel-wired-lan] [PATCH net-next v4 2/7] i40e: Refactor argument of several client notification functions

2024-04-27 Thread Simon Horman
On Sat, Apr 27, 2024 at 09:26:03AM +0200, Ivan Vecera wrote: > Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified > the client interface so in practice it supports only one client > per i40e netdev. But we have still 2 notification functions that > uses as parameter a pointer to VSI

Re: [Intel-wired-lan] [PATCH net-next v4 3/7] i40e: Refactor argument of i40e_detect_recover_hung()

2024-04-27 Thread Simon Horman
On Sat, Apr 27, 2024 at 09:26:04AM +0200, Ivan Vecera wrote: > Commit 07d44190a389 ("i40e/i40evf: Detect and recover hung queue > scenario") changes i40e_detect_recover_hung() argument type from > i40e_pf* to i40e_vsi* to be shareable by both i40e and i40evf. > Because the i40evf does not exist any

Re: [Intel-wired-lan] [PATCH net-next v4 5/7] i40e: Consolidate checks whether given VSI is main

2024-04-27 Thread Simon Horman
On Sat, Apr 27, 2024 at 09:26:06AM +0200, Ivan Vecera wrote: > In the driver code there are 3 types of checks whether given > VSI is main or not: > 1. vsi->type ==/!= I40E_VSI_MAIN > 2. vsi ==/!= pf->vsi[pf->lan_vsi] > 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid > > All of them are equivalent an

Re: [Intel-wired-lan] [PATCH net-next v4 4/7] i40e: Add helper to access main VSI

2024-04-27 Thread Simon Horman
On Sat, Apr 27, 2024 at 09:26:05AM +0200, Ivan Vecera wrote: > Add simple helper i40e_pf_get_main_vsi(pf) to access main VSI > that replaces pattern 'pf->vsi[pf->lan_vsi]' > > Reviewed-by: Michal Schmidt > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy > Signed-off-by: Ivan Vecera

Re: [Intel-wired-lan] [PATCH net-next v4 6/7] i40e: Add helper to access main VEB

2024-04-27 Thread Simon Horman
On Sat, Apr 27, 2024 at 09:26:07AM +0200, Ivan Vecera wrote: > Add a helper to access main VEB: > > i40e_pf_get_main_veb(pf) replaces 'pf->veb[pf->lan_veb]' > > Reviewed-by: Michal Schmidt > Reviewed-by: Aleksandr Loktionov > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy > Sign

Re: [Intel-wired-lan] [PATCH net-next v4 7/7] i40e: Add and use helper to reconfigure TC for given VSI

2024-04-27 Thread Simon Horman
On Sat, Apr 27, 2024 at 09:26:08AM +0200, Ivan Vecera wrote: > Add helper i40e_vsi_reconfig_tc(vsi) that configures TC > for given VSI using previously stored TC bitmap. > > Effectively replaces open-coded patterns: > > enabled_tc = vsi->tc_config.enabled_tc; > vsi->tc_config.enabled_tc = 0; > i4

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 1bede0a12d3a45bd366d3cf9e1c7611d86f1bc1f

2024-04-27 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240427 gcc arc randconfig-002-20240427 gcc arm allmodconfig gcc

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS 6a30653b604aaad1bf0f2e74b068ceb8b6fc7aea

2024-04-27 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240427 gcc arc randconfig-002-20240427 gcc arm

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 5603fbcb2f5f02b7fb6401c13ae9fbc740be6aad

2024-04-27 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240427 gcc arc randconfig-002-20240427 gcc arm

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS ed2dfdd1efd3d02c58a5a8be81b7c305a77ef05e

2024-04-27 Thread kernel test robot
nfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240427 gcc arc randconfig-002-20240427 gcc

Re: [Intel-wired-lan] [PATCH 1/1] net: e1000e & ixgbe: Remove PCI_HEADER_TYPE_MFD duplicates

2024-04-27 Thread Sasha Neftin
On 23/04/2024 17:40, Ilpo Järvinen wrote: PCI_HEADER_TYPE_MULTIFUNC is define by e1000e and ixgbe and both are unused. There is already PCI_HEADER_TYPE_MFD in pci_regs.h anyway which should be used instead so remove the duplicated defines of it. Signed-off-by: Ilpo Järvinen --- drivers/net/et