Re: [Intel-wired-lan] [iwl-next v3 5/7] ice: base subfunction aux driver

2024-04-15 Thread Michal Swiatkowski
On Fri, Apr 12, 2024 at 01:44:45PM +0200, Przemek Kitszel wrote: > On 4/12/24 08:30, Michal Swiatkowski wrote: > > From: Piotr Raczynski > > > > Implement subfunction driver. It is probe when subfunction port is > > activated. > > > > VSI is already created. During the probe VSI is being configu

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-15 Thread Michal Swiatkowski
On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri Pirko wrote: > Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com > wrote: > >From: Piotr Raczynski > > > >Implement devlink port handlers responsible for ethernet type devlink > >subfunctions. Create subfunction devlink port an

Re: [Intel-wired-lan] [iwl-next v3 4/7] ice: allocate devlink for subfunction

2024-04-15 Thread Michal Swiatkowski
On Fri, Apr 12, 2024 at 09:24:15AM +0200, Jiri Pirko wrote: > Fri, Apr 12, 2024 at 08:30:50AM CEST, michal.swiatkow...@linux.intel.com > wrote: > >From: Piotr Raczynski > > > >Make devlink allocation function generic to use it for PF and for SF. > > > >Add function for SF devlink port creation. I

[Intel-wired-lan] [PATCH iwl-next] ice: Deduplicate tc action setup

2024-04-15 Thread Marcin Szycik
ice_tc_setup_redirect_action() and ice_tc_setup_mirror_action() are almost identical, except for setting filter action. Reduce them to one function with an extra param, which handles both cases. Reviewed-by: Mateusz Polchlopek Signed-off-by: Marcin Szycik --- drivers/net/ethernet/intel/ice/ice_

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-15 Thread Jiri Pirko
Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri Pirko wrote: >> Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski [...] >> >+static int >> >+ice_devlink_por

Re: [Intel-wired-lan] [PATCH] e1000e: move force SMBUS near the end of enable_ulp function

2024-04-15 Thread Lifshits, Vitaly
On 4/13/2024 12:27 PM, Hui Wang wrote: The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") introduces a regression on CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without this commit, the ethernet works well after suspend and resume, but after applyin

[Intel-wired-lan] [PATCH iwl-next v2 0/5] ixgbe: Add support for Intel(R) E610 device

2024-04-15 Thread Piotr Kwapulinski
Add initial support for Intel(R) E610 Series of network devices. The E610 is based on X550 but adds firmware managed link, enhanced security capabilities and support for updated server manageability. This patch series adds low level support for the following features and enables link management.

[Intel-wired-lan] [PATCH iwl-next v2 1/5] ixgbe: Add support for E610 FW Admin Command Interface

2024-04-15 Thread Piotr Kwapulinski
Add low level support for Admin Command Interface (ACI). ACI is the Firmware interface used by a driver to communicate with E610 adapter. Add the following ACI features: - data structures, macros, register definitions - commands handling - events handling Co-developed-by: Stefan Wegrzyn Signed-of

[Intel-wired-lan] [PATCH iwl-next v2 2/5] ixgbe: Add support for E610 device capabilities detection

2024-04-15 Thread Piotr Kwapulinski
Add low level support for E610 device capabilities detection. The capabilities are discovered via the Admin Command Interface. Discover the following capabilities: - function caps: vmdq, dcb, rss, rx/tx qs, msix, nvm, orom, reset - device caps: vsi, fdir, 1588 - phy caps Co-developed-by: Stefan We

[Intel-wired-lan] [PATCH iwl-next v2 3/5] ixgbe: Add link management support for E610 device

2024-04-15 Thread Piotr Kwapulinski
Add low level link management support for E610 device. Link management operations are handled via the Admin Command Interface. Add the following link management operations: - get link capabilities - set up link - get media type - get link status, link status events - link power management Co-devel

[Intel-wired-lan] [PATCH iwl-next v2 4/5] ixgbe: Add support for NVM handling in E610 device

2024-04-15 Thread Piotr Kwapulinski
Add low level support for accessing NVM in E610 device. NVM operations are handled via the Admin Command Interface. Add the following NVM specific operations: - acquire, release, read - validate checksum - read shadow ram Co-developed-by: Stefan Wegrzyn Signed-off-by: Stefan Wegrzyn Co-developed

[Intel-wired-lan] [PATCH iwl-next v2 5/5] ixgbe: Enable link management in E610 device

2024-04-15 Thread Piotr Kwapulinski
Add high level link management support for E610 device. Enable the following features: - driver load - bring up network interface - IP address assignment - pass traffic - show statistics (e.g. via ethtool) - disable network interface - driver unload Co-developed-by: Carolyn Wyborny Signed-off-by:

[Intel-wired-lan] [PATCH iwl-net v2] igc: Fix deadlock on module removal

2024-04-15 Thread Kurt Kanzenbach
From: Lukas Wunner The removal of the igc module leads to a deadlock: |[Mon Apr 8 17:38:55 2024] __mutex_lock.constprop.0+0x3e5/0x7a0 |[Mon Apr 8 17:38:55 2024] ? preempt_count_add+0x85/0xd0 |[Mon Apr 8 17:38:55 2024] __mutex_lock_slowpath+0x13/0x20 |[Mon Apr 8 17:38:55 2024] mutex_lock+

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix deadlock on module removal

2024-04-15 Thread Kurt Kanzenbach
Lukas, >> I would have been happy to submit a patch myself, I was waiting >> for a Tested-by from Roman or you. > > Perfect. I was wondering why you are not submitting the patch > yourself. Then, please go ahead and submit the patch. Feel free to add > my Tested-by. Scratch that. I've sent v2 wit

[Intel-wired-lan] [PATCH net-next v2 07/15] mm: page_frag: add '_va' suffix to page_frag API

2024-04-15 Thread Yunsheng Lin
Currently most of the API for page_frag API is returning 'virtual address' as output or expecting 'virtual address' as input, in order to differentiate the API handling between 'virtual address' and 'struct page', add '_va' suffix to the corresponding API mirroring the page_pool_alloc_va() API of t

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix deadlock on module removal

2024-04-15 Thread Lukas Wunner
On Sun, Apr 14, 2024 at 11:15:26AM +0200, Kurt Kanzenbach wrote: > Perfect. I was wondering why you are not submitting the patch > yourself. Then, please go ahead and submit the patch. Here you go: https://lore.kernel.org/netdev/2f1be6b1cf2b3346929b0049f2ac7d7d79acb5c9.1713188539.git.lu...@wunner

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix deadlock on module removal

2024-04-15 Thread Lukas Wunner
On Mon, Apr 15, 2024 at 01:02:14PM +0200, Kurt Kanzenbach wrote: > > > I would have been happy to submit a patch myself, I was waiting > > > for a Tested-by from Roman or you. > > > > Perfect. I was wondering why you are not submitting the patch > > yourself. Then, please go ahead and submit the pa

[Intel-wired-lan] [PATCH net] igc: Fix LED-related deadlock on driver unbind

2024-04-15 Thread Lukas Wunner
Roman reports a deadlock on unplug of a Thunderbolt docking station containing an Intel I225 Ethernet adapter. The root cause is that led_classdev's for LEDs on the adapter are registered such that they're device-managed by the netdev. That results in recursive acquisition of the rtnl_lock() mute

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix deadlock on module removal

2024-04-15 Thread Kurt Kanzenbach
Hi Lukas, On Mon Apr 15 2024, Lukas Wunner wrote: > On Mon, Apr 15, 2024 at 01:02:14PM +0200, Kurt Kanzenbach wrote: >> > > I would have been happy to submit a patch myself, I was waiting >> > > for a Tested-by from Roman or you. >> > >> > Perfect. I was wondering why you are not submitting the pa

Re: [Intel-wired-lan] [intel-next 1/2] net/i40e: link NAPI instances to queues and IRQs

2024-04-15 Thread Tony Nguyen
On 4/13/2024 12:24 PM, Joe Damato wrote: On Thu, Apr 11, 2024 at 04:02:37PM -0700, Nambiar, Amritha wrote: On 4/10/2024 4:43 PM, Joe Damato wrote: On Wed, Apr 10, 2024 at 02:10:52AM -0700, Nambiar, Amritha wrote: On 4/9/2024 9:39 PM, Joe Damato wrote: Make i40e compatible with the newly ad

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-15 Thread Andrew Lunn
On Fri, Apr 12, 2024 at 03:21:24PM +0200, Wojciech Drewek wrote: > > > On 09.04.2024 15:39, Andrew Lunn wrote: > >> This is something my current design supports I think. Using > >> ETHTOOL_A_MODULE_MAX_POWER_SET user can get what cage supports > >> and change it. > > > >> This could be done usi

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 083c113c913223a4e979bb8c2fe8bce15cea65ca

2024-04-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue branch HEAD: 083c113c913223a4e979bb8c2fe8bce15cea65ca ice: Fix checking for unsupported keys on non-tunnel device elapsed time: 723m configs tested: 129 configs skipped: 3 The following configs have be

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS f09e2aecf1b59a6f9347be39d545cdcf30b61c83

2024-04-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue branch HEAD: f09e2aecf1b59a6f9347be39d545cdcf30b61c83 ice: Fix checking for unsupported keys on non-tunnel device elapsed time: 723m configs tested: 144 configs skipped: 3 The following configs have bee

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-15 Thread Michal Swiatkowski
On Mon, Apr 15, 2024 at 11:10:50AM +0200, Jiri Pirko wrote: > Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com > wrote: > >On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri Pirko wrote: > >> Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com > >> wrote:

Re: [Intel-wired-lan] [PATCH iwl-next v2 0/5] ixgbe: Add support for Intel(R) E610 device

2024-04-15 Thread Kwapulinski, Piotr
>-Original Message- >From: Kwapulinski, Piotr >Sent: Monday, April 15, 2024 12:35 PM >To: intel-wired-...@lists.osuosl.org >Cc: net...@vger.kernel.org; ho...@kernel.org; Gomes, Vinicius >; Kwapulinski, Piotr >Subject: [PATCH iwl-next v2 0/5] ixgbe: Add support for Intel(R) E610 device >

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-15 Thread Michal Swiatkowski
On Tue, Apr 16, 2024 at 07:14:43AM +0200, Michal Swiatkowski wrote: > On Mon, Apr 15, 2024 at 11:10:50AM +0200, Jiri Pirko wrote: > > Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com > > wrote: > > >On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri Pirko wrote: > > >> Fri, Apr