Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Implement devlink port handlers responsible for ethernet type devlink >subfunctions. Create subfunction devlink port and setup all resources >needed for a subfunction netdev to operate. Config

Re: [Intel-wired-lan] [iwl-next v3 5/7] ice: base subfunction aux driver

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:51AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Implement subfunction driver. It is probe when subfunction port is >activated. > >VSI is already created. During the probe VSI is being configured. >MAC unicast and broadcast filter is added t

Re: [Intel-wired-lan] [iwl-next v3 6/7] ice: implement netdev for subfunction

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:52AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Configure netdevice for subfunction usecase. Mostly it is reusing ops >from the PF netdevice. > >SF netdev is linked to devlink port registered after SF activation. > >Signed-off-by: Piotr Rac

Re: [Intel-wired-lan] [iwl-next v3 4/7] ice: allocate devlink for subfunction

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:50AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Make devlink allocation function generic to use it for PF and for SF. > >Add function for SF devlink port creation. It will be used in next >patch. > >Create header file for subfunction device

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS 4e1ad31ce3205d9400816e08cf14b7c96295d22e

2024-04-12 Thread kernel test robot
gcc i386 allyesconfig gcc i386 buildonly-randconfig-001-20240412 gcc i386 buildonly-randconfig-002-20240412 clang i386 buildonly-randconfig-003-20240412 gcc i386 buildonly-randconfig-004-20240412 gcc i386 buildonly-rand

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS f990a8a3833acaeb38f976ffa8fd90d136a9d810

2024-04-12 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue branch HEAD: f990a8a3833acaeb38f976ffa8fd90d136a9d810 ice: Fix checking for unsupported keys on non-tunnel device elapsed time: 998m configs tested: 95 configs skipped: 3 The following configs have been

Re: [Intel-wired-lan] [iwl-next v1] ice: Remove ndo_get_phys_port_name

2024-04-12 Thread Buvaneswaran, Sujai
> -Original Message- > From: Intel-wired-lan On Behalf Of > Dariusz Aftanski > Sent: Friday, March 8, 2024 4:29 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Dariusz Aftanski > ; Michal Swiatkowski > > Subject: [Intel-wired-lan] [iwl-next v1] ice: Remove > ndo_ge

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 0e36c21d7640ddbfa9233c692db905e0848c6f44

2024-04-12 Thread kernel test robot
allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240412 gcc arc randconfig-002-20240412 gcc

Re: [Intel-wired-lan] [iwl-next v3 5/7] ice: base subfunction aux driver

2024-04-12 Thread Przemek Kitszel
On 4/12/24 08:30, Michal Swiatkowski wrote: From: Piotr Raczynski Implement subfunction driver. It is probe when subfunction port is activated. VSI is already created. During the probe VSI is being configured. MAC unicast and broadcast filter is added to allow traffic to pass. Signed-off-by:

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS df238859a090c8e9eae88eb58b4cb267304f7988

2024-04-12 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240412 gcc arc randconfig-002-20240412 gcc arm

[Intel-wired-lan] [PATCH v8 iwl-next 00/12] Introduce ETH56G PHY model for E825C products

2024-04-12 Thread Karol Kolacinski
E825C products have a different PHY model than E822, E823 and E810 products. This PHY is ETH56G and its support is necessary to have functional PTP stack for E825C products. Grzegorz Nitka (2): ice: Add NAC Topology device capability parser ice: Adjust PTP init for 2x50G E825C devices Jacob K

[Intel-wired-lan] [PATCH v8 iwl-next 01/12] ice: Introduce ice_ptp_hw struct

2024-04-12 Thread Karol Kolacinski
Create new ice_ptp_hw struct and use it for all HW and PTP-related fields from struct ice_hw. Replace definitions with struct fields, which values are set accordingly to a specific device. Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V4 -> V

[Intel-wired-lan] [PATCH v8 iwl-next 02/12] ice: Introduce helper to get tmr_cmd_reg values

2024-04-12 Thread Karol Kolacinski
From: Jacob Keller Multiple places in the driver code need to convert enum ice_ptp_tmr_cmd values into register bits for both the main timer and the PHY port timers. The main MAC register has one bit scheme for timer commands, while the PHY commands use a different scheme. The E810 and E830 devi

[Intel-wired-lan] [PATCH v8 iwl-next 06/12] ice: Introduce ice_get_base_incval() helper

2024-04-12 Thread Karol Kolacinski
From: Jacob Keller Add a new helper for getting base clock increment value for specific HW. Signed-off-by: Jacob Keller Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V4 -> V5: Removed unused UNKNOWN_INCVAL_E82X drivers/net/ethernet/intel

[Intel-wired-lan] [PATCH v8 iwl-next 03/12] ice: Implement Tx interrupt enablement functions

2024-04-12 Thread Karol Kolacinski
From: Sergey Temerkhanov Introduce functions enabling/disabling Tx TS interrupts for the E822 and ETH56G PHYs Signed-off-by: Sergey Temerkhanov Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V5 -> V6: Adjusted return in ice_phy_cfg_intr_e82

[Intel-wired-lan] [PATCH v8 iwl-next 05/12] ice: Move CGU block

2024-04-12 Thread Karol Kolacinski
From: Sergey Temerkhanov Move CGU block to the beginning of ice_ptp_hw.c Signed-off-by: Sergey Temerkhanov Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V7 -> V8: brought back P_REG_40B_HIGH_S due to 32 bit compatibility issue V6 -> V7: -

[Intel-wired-lan] [PATCH v8 iwl-next 04/12] ice: Add PHY OFFSET_READY register clearing

2024-04-12 Thread Karol Kolacinski
Add a possibility to mark all transmitted/received timestamps as invalid by clearing PHY OFFSET_READY registers. Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/ice_ptp.c| 11 --- drivers/net/ethernet/int

[Intel-wired-lan] [PATCH v8 iwl-next 07/12] ice: Introduce ETH56G PHY model for E825C products

2024-04-12 Thread Karol Kolacinski
From: Sergey Temerkhanov E825C products feature a new PHY model - ETH56G. Introduces all necessary PHY definitions, functions etc. for ETH56G PHY, analogous to E82X and E810 ones with addition of a few HW-specific functionalities for ETH56G like one-step timestamping. It ensures correct PTP ini

[Intel-wired-lan] [PATCH v8 iwl-next 08/12] ice: Change CGU regs struct to anonymous

2024-04-12 Thread Karol Kolacinski
Simplify the code by using anonymous struct in CGU registers instead of naming each structure 'field'. Suggested-by: Przemek Kitszel Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/ice_cgu_regs.h | 12 ++--- dri

[Intel-wired-lan] [PATCH v8 iwl-next 09/12] ice: Add support for E825-C TS PLL handling

2024-04-12 Thread Karol Kolacinski
From: Michal Michalik The CGU layout of E825-C is a little different than E822/E823. Add support the new hardware adding relevant functions. Signed-off-by: Michal Michalik Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V4 -> V5: added UL to

[Intel-wired-lan] [PATCH v8 iwl-next 10/12] ice: Add NAC Topology device capability parser

2024-04-12 Thread Karol Kolacinski
From: Grzegorz Nitka Add new device capability ICE_AQC_CAPS_NAC_TOPOLOGY which allows to determine the mode of operation (1 or 2 NAC). Define a new structure to store data from new capability and corresponding parser code. Co-developed-by: Prathisna Padmasanan Signed-off-by: Prathisna Padmasana

[Intel-wired-lan] [PATCH v8 iwl-next 11/12] ice: Support 2XNAC configuration using auxbus

2024-04-12 Thread Karol Kolacinski
There are E825C products featuring 2 NACs. Those have only one source clock on the primary NAC. For those devices, there should be only one clock controller on the primary NAC. All PFs from both NACs should connect as auxiliary devices to the auxiliary driver on the primary NAC. Reviewed-by: Igor

[Intel-wired-lan] [PATCH v8 iwl-next 12/12] ice: Adjust PTP init for 2x50G E825C devices

2024-04-12 Thread Karol Kolacinski
From: Grzegorz Nitka >From FW/HW perspective, 2 port topology in E825C devices requires merging of 2 port mapping internally and breakout mapping externally. As a consequence, it requires different port numbering from PTP code perspective. For that topology, pf_id can not be used to index PTP por

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-12 Thread Wojciech Drewek
On 09.04.2024 15:39, Andrew Lunn wrote: >> This is something my current design supports I think. Using >> ETHTOOL_A_MODULE_MAX_POWER_SET user can get what cage supports >> and change it. > >> This could be done using ethtool_module_power_mode_policy I think. > > All these 'I think' don't give

Re: [Intel-wired-lan] [PATCH iwl-next v2 7/7] i40e: Add and use helper to reconfigure TC for given VSI

2024-04-12 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Wednesday, March 27, 2024 1:28 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; Loktionov, > Aleksandr ; eduma...@google.com; Nguyen, > Anthony L ; k...@k

Re: [Intel-wired-lan] [iwl-next v1] ice: Remove ndo_get_phys_port_name

2024-04-12 Thread Jiri Pirko
Fri, Mar 08, 2024 at 11:58:42AM CET, dariusz.aftan...@linux.intel.com wrote: >ndo_get_phys_port_name is never actually used, as in switchdev >devklink is always being created. > >Reviewed-by: Michal Swiatkowski >Signed-off-by: Dariusz Aftanski Reviewed-by: Jiri Pirko

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS bda416f88bbe13bc92705bf546ebda88100f47c3

2024-04-12 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240412 gcc arc randconfig-002-20240412 gcc

Re: [Intel-wired-lan] [PATCH iwl-next v2 0/7] i40e: cleanups & refactors

2024-04-12 Thread Tony Nguyen
On 3/27/2024 12:57 AM, Ivan Vecera wrote: This series do following: Patch 1 - Removes write-only flags field from i40e_veb structure and from i40e_veb_setup() parameters Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes() and i40e_notify_client_of_ne

[Intel-wired-lan] [PATCH iwl-next 0/4]ice:Support to dump PHY config, FEC stats

2024-04-12 Thread Anil Samal
Implementation to dump PHY configuration and FEC statistics to facilitate link level debugging of customer issues. Implementation has two parts a. Serdes equalization # ethtool -d eth0 Output: Offset Values -- -- 0x:

[Intel-wired-lan] [PATCH iwl-next 2/4] ice: Extend Sideband Queue command to support dynamic flag

2024-04-12 Thread Anil Samal
Current driver implementation for Sideband Queue supports a fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from firmware Sideband Queue command is used with a different flag. Extend API for Sideband Queue command to use 'flag' as input argument. Reviewed-by: Jesse Brandeburg Signed-off-

[Intel-wired-lan] [PATCH iwl-next 1/4] ice: Implement new API to derive physical topology of input port

2024-04-12 Thread Anil Samal
Some phy configurations such as serdes equalizer parameters, are applied per serdes lane. Hence firmware requires serdes lane number to read serdes equalizer values. Similarly firmware requires PCS quad number and PCS port number to read FEC statistics. Current driver implementation does not mainta

[Intel-wired-lan] [PATCH iwl-next 3/4] ice: Implement driver functionality to dump fec statistics

2024-04-12 Thread Anil Samal
To debug link issues in the field, it is paramount to dump fec corrected/uncorrected block counts from firmware. Extend ethtool option '--show-fec' to support fec statistics. The IEEE standard mandates two sets of counters: - 30.5.1.1.17 aFECCorrectedBlocks - 30.5.1.1.18 aFECUncorrectableBlocks

[Intel-wired-lan] [PATCH iwl-next 4/4] ice: Implement driver functionality to dump serdes equalizer values

2024-04-12 Thread Anil Samal
To debug link issues in the field, serdes Tx/Rx equalizer values help to determine the health of serdes lane. Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer. The following list of equalizer param is supported a. rx_equalization_pre2 b. rx_equalization_pre1 c. rx_equalization_post1 d. rx