Re: [Intel-wired-lan] [PATCH iwl-net v4] i40e: fix livelocks in i40e_reset_subtask()

2024-01-31 Thread Ivan Vecera
On 26. 07. 23 22:43, Aleksandr Loktionov wrote: Fix livelocks by acquiring rtnl_lock() before any reset related operations. Add rtnl_lock()/rtnl_unlock() at top/bottom of i40e_reset_subtask() Add check for __I40E_RESET_INTR_RECEIVED bit. Add re-entry guard by fast return in case reset is alread

Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix 32bit FW gtime wrapping issue

2024-01-31 Thread Ivan Vecera
On 17. 08. 23 21:28, Aleksandr Loktionov wrote: Before the i40e_nvm code didn't take into account that 32bit FW gtime wraps ~70minutes, timeout was calculated as 64bit gtime + NVM_TIMEOUT , so when gtime was ~70minutes, then gtime could not become greater than 64bit timeout value and the semaphor

Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread Jiri Pirko
Wed, Jan 31, 2024 at 09:08:47AM CET, ksund...@redhat.com wrote: >Changing the mac address of the VF representor ports are not >available via devlink. Add the function handlers to set and get >the HW address for the VF representor ports. Wait a sec. The API is there to change the mac of the actual

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS dd5cddbfd781d93df1e301ba4a3a57411e2ba326

2024-01-31 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc axs101_defconfig gcc arc defconfig gcc arc randconfig-001-20240131 gcc arc randconfig-002-20240131 gcc

Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread Michal Swiatkowski
On Wed, Jan 31, 2024 at 01:38:47PM +0530, karthiksundaravel wrote: > Changing the mac address of the VF representor ports are not > available via devlink. Add the function handlers to set and get > the HW address for the VF representor ports. > > Signed-off-by: karthiksundaravel > --- > drivers/

[Intel-wired-lan] [PATCH iwl-next v5 2/3] ixgbe: Rearrange args to fix reverse Christmas tree

2024-01-31 Thread Jedrzej Jagielski
Clean up the code touched during type conversion by the previous patch of the series. Suggested-by: Tony Nguyen Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman Signed-off-by: Jedrzej Jagielski --- .../net/ethernet/intel/ixgbe/ixgbe_82598.c| 14 ++-- .../net/ethernet/intel/ixgbe/ixg

[Intel-wired-lan] [PATCH iwl-next v5 3/3] ixgbe: Clarify the values of the returning status

2024-01-31 Thread Jedrzej Jagielski
Converting s32 functions to regular int in the previous patch of the series caused triggering smatch warnings about missing error code. New smatch warnings: drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status' drivers/net/ethernet/intel/ix

Re: [Intel-wired-lan] [PATCH net-next v5] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread Marcin Szycik
On 31.01.2024 02:37, Takeru Hayasaka wrote: > This is a patch that enables RSS functionality for GTP packets using ethtool. > > A user can include TEID and make RSS work for GTP-U over IPv4 by doing the > following:`ethtool -N ens3 rx-flow-hash gtpu4 sde` > > In addition to gtpu(4|6), we now s

[Intel-wired-lan] [PATCH net] ice: fix unaligned access in ice_create_lag_recipe

2024-01-31 Thread Michal Schmidt
new_rcp->recipe_bitmap was written to as if it were an aligned bitmap. It is an 8-byte array, but aligned only to 4. Use put_unaligned to set its value. Additionally, values in ice commands are typically in little-endian. I assume the recipe bitmap should be too, so use the *_le64 conversion. I do

Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread Jiri Pirko
Wed, Jan 31, 2024 at 11:43:44AM CET, michal.swiatkow...@linux.intel.com wrote: >On Wed, Jan 31, 2024 at 01:38:47PM +0530, karthiksundaravel wrote: >> Changing the mac address of the VF representor ports are not >> available via devlink. Add the function handlers to set and get >> the HW address for

Re: [Intel-wired-lan] [PATCH net] ice: fix unaligned access in ice_create_lag_recipe

2024-01-31 Thread Jiri Pirko
Wed, Jan 31, 2024 at 12:58:23PM CET, mschm...@redhat.com wrote: >new_rcp->recipe_bitmap was written to as if it were an aligned bitmap. >It is an 8-byte array, but aligned only to 4. >Use put_unaligned to set its value. > >Additionally, values in ice commands are typically in little-endian. >I assu

[Intel-wired-lan] [PATCH net] i40e: Do not allow untrusted VF to remove administratively set MAC

2024-01-31 Thread Ivan Vecera
Currently when PF administratively sets VF's MAC address and the VF is put down (VF tries to delete all MACs) then the MAC is removed from MAC filters and primary VF MAC is zeroed. Do not allow untrusted VF to remove primary MAC when it was set administratively by PF. Reproducer: 1) Create VF 2)

Re: [Intel-wired-lan] [PATCH net-next v5] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread takeru hayasaka
Hi Marcin-san > LGTM Thanks for your review! > Still removing this line :c Oh! Sorry for the oversight. I will fix it in the next patch. Could you please take another look at the patch? Thanks Takeru 2024年1月31日(水) 20:53 Marcin Szycik : > > > > On 31.01.2024 02:37, Takeru Hayasaka wrote: > > T

[Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread Takeru Hayasaka
This is a patch that enables RSS functionality for GTP packets using ethtool. A user can include TEID and make RSS work for GTP-U over IPv4 by doing the following:`ethtool -N ens3 rx-flow-hash gtpu4 sde` In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e, gtpu(4|6)u, and gtp

Re: [Intel-wired-lan] [PATCH iwl-next v4 2/2] ice: Implement 'flow-type ether' rules

2024-01-31 Thread Plachno, Lukasz
On 1/25/2024 12:09 AM, Paul Menzel wrote: Dear Lukasz, dear Jakub, dear Mateusz, Thank you for your patch. Am 24.01.24 um 16:21 schrieb Lukasz Plachno: From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Can you please elaborate on the implementation?

[Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread karthiksundaravel
Changing the mac address of the VF representor ports are not available via devlink. Add the function handlers to set and get the HW address for the VF representor ports. Signed-off-by: karthiksundaravel --- drivers/net/ethernet/intel/ice/ice_devlink.c | 134 ++- 1 file changed, 1

Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread Paul Menzel
Dear karthiksundaravel, Thank you for your patch. Am 31.01.24 um 09:08 schrieb karthiksundaravel: Changing the mac address of the VF representor ports are not Do you mean “is not possible”? available via devlink. Add the function handlers to set and get the HW address for the VF represent

Re: [Intel-wired-lan] i40e XDP program stops transmitting after link down/up

2024-01-31 Thread Seth Forshee
On Tue, Jan 30, 2024 at 11:06:07PM +0100, Maciej Fijalkowski wrote: > On Tue, Jan 30, 2024 at 08:28:24PM +0100, Maciej Fijalkowski wrote: > > On Tue, Jan 30, 2024 at 10:59:13AM -0600, Seth Forshee wrote: > > > On Tue, Jan 30, 2024 at 05:14:23PM +0100, Paul Menzel wrote: > > > > Dear Seth, > > > >

Re: [Intel-wired-lan] i40e XDP program stops transmitting after link down/up

2024-01-31 Thread Maciej Fijalkowski
On Wed, Jan 31, 2024 at 10:26:07AM -0600, Seth Forshee wrote: > On Tue, Jan 30, 2024 at 11:06:07PM +0100, Maciej Fijalkowski wrote: > > On Tue, Jan 30, 2024 at 08:28:24PM +0100, Maciej Fijalkowski wrote: > > > On Tue, Jan 30, 2024 at 10:59:13AM -0600, Seth Forshee wrote: > > > > On Tue, Jan 30, 202

Re: [Intel-wired-lan] [PATCH net] ice: fix unaligned access in ice_create_lag_recipe

2024-01-31 Thread Alexander Lobakin
From: Jiri Pirko Date: Wed, 31 Jan 2024 13:17:44 +0100 > Wed, Jan 31, 2024 at 12:58:23PM CET, mschm...@redhat.com wrote: >> new_rcp->recipe_bitmap was written to as if it were an aligned bitmap. >> It is an 8-byte array, but aligned only to 4. >> Use put_unaligned to set its value. >> >> Addition

Re: [Intel-wired-lan] [PATCH iwl-net v4] i40e: fix livelocks in i40e_reset_subtask()

2024-01-31 Thread Tony Nguyen
On 1/31/2024 12:08 AM, Ivan Vecera wrote: Tony, why this is marked in IWL patchwork as ChangesRequested? There were no comments and the patch disappeared from dev-queue. Are you planning to process it? Hi Ivan, Our validation found that issues still existed even with these patches applie

Re: [Intel-wired-lan] [PATCH v2 0/7 iwl-next] idpf: refactor virtchnl messages

2024-01-31 Thread Alan Brady
On 1/29/2024 7:43 AM, Alexander Lobakin wrote: From: Brady, Alan Date: Mon, 29 Jan 2024 16:12:06 +0100 -Original Message- From: Lobakin, Aleksander Sent: Monday, January 29, 2024 5:24 AM To: Brady, Alan Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; willemdebruijn.ker.

Re: [Intel-wired-lan] [PATCH v3 0/7 iwl-next] idpf: refactor virtchnl messages

2024-01-31 Thread Alexander Lobakin
From: Alan Brady Date: Mon, 29 Jan 2024 16:59:16 -0800 > The motivation for this series has two primary goals. We want to enable > support of multiple simultaneous messages and make the channel more > robust. The way it works right now, the driver can only send and receive > a single message at a

Re: [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread Jakub Kicinski
On Wed, 31 Jan 2024 13:46:22 + Takeru Hayasaka wrote: > .../device_drivers/ethernet/intel/ice.rst | 21 - > drivers/net/ethernet/intel/ice/ice_ethtool.c | 82 +++ > drivers/net/ethernet/intel/ice/ice_flow.h | 31 +-- > drivers/net/ethernet/intel/ice/ice_lib.c

[Intel-wired-lan] [PATCH iwl-net] ice: virtchnl: stop pretending to support RSS over AQ or registers

2024-01-31 Thread Jacob Keller
The E800 series hardware uses the same iAVF driver as older devices, including the virtchnl negotiation scheme. This negotiation scheme includes a mechanism to determine what type of RSS should be supported, including RSS over PF virtchnl messages, RSS over firmware AdminQ messages, and RSS via di

Re: [Intel-wired-lan] [PATCH v3 0/7 iwl-next] idpf: refactor virtchnl messages

2024-01-31 Thread Alan Brady
On 1/31/2024 10:33 AM, Alexander Lobakin wrote: From: Alan Brady Date: Mon, 29 Jan 2024 16:59:16 -0800 The motivation for this series has two primary goals. We want to enable support of multiple simultaneous messages and make the channel more robust. The way it works right now, the driver can

Re: [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread takeru hayasaka
Hi Jakub-san Thank you for your review. I apologize for the delay in resubmitting the patch. > Could you split the uAPI changes and the driver changes to two separate > commits? You should post them as a patch series, but combining them > into a single commit makes the uAPI addition to easy to mis

[Intel-wired-lan] [PATCH net-next v6 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-01-31 Thread Takeru Hayasaka
This is a patch that enables RSS functionality for GTP packets using ethtool. A user can include TEID and make RSS work for GTP-U over IPv4 by doing the following:`ethtool -N ens3 rx-flow-hash gtpu4 sde` In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e, gtpu(4|6)u, and gtp

[Intel-wired-lan] [PATCH net-next v6 2/2] ice: Implement RSS settings for GTP using ethtool

2024-01-31 Thread Takeru Hayasaka
Following the addition of new GTP RSS hash options to ethtool.h, this patch implements the corresponding RSS settings for GTP packets in the Intel ice driver. It enables users to configure RSS for GTP-U and GTP-C traffic over IPv4 and IPv6, utilizing the newly defined hash options. The implementat

[Intel-wired-lan] [PATCH net-next v7 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-01-31 Thread Takeru Hayasaka
This is a patch that enables RSS functionality for GTP packets using ethtool. A user can include TEID and make RSS work for GTP-U over IPv4 by doing the following:`ethtool -N ens3 rx-flow-hash gtpu4 sde` In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e, gtpu(4|6)u, and gtp

[Intel-wired-lan] [PATCH net-next v7 2/2] ice: Implement RSS settings for GTP using ethtool

2024-01-31 Thread Takeru Hayasaka
Following the addition of new GTP RSS hash options to ethtool.h, this patch implements the corresponding RSS settings for GTP packets in the Intel ice driver. It enables users to configure RSS for GTP-U and GTP-C traffic over IPv4 and IPv6, utilizing the newly defined hash options. The implementat

Re: [Intel-wired-lan] [PATCH net-next v7 2/2] ice: Implement RSS settings for GTP using ethtool

2024-01-31 Thread takeru hayasaka
Hi reviews. I made a mistake in sending the patch without increasing the version, so I will send it again as v7. Thanks Takeru 2024年2月1日(木) 12:33 Takeru Hayasaka : > > Following the addition of new GTP RSS hash options to ethtool.h, this patch > implements the corresponding RSS settings for GTP p

Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread Michal Swiatkowski
On Wed, Jan 31, 2024 at 01:00:04PM +0100, Jiri Pirko wrote: > Wed, Jan 31, 2024 at 11:43:44AM CET, michal.swiatkow...@linux.intel.com wrote: > >On Wed, Jan 31, 2024 at 01:38:47PM +0530, karthiksundaravel wrote: > >> Changing the mac address of the VF representor ports are not > >> available via dev

Re: [Intel-wired-lan] [iwl-next v1 4/8] ice: control default Tx rule in lag

2024-01-31 Thread Michal Swiatkowski
On Mon, Jan 29, 2024 at 10:55:41AM +, Simon Horman wrote: > On Thu, Jan 25, 2024 at 01:53:10PM +0100, Michal Swiatkowski wrote: > > Tx rule in switchdev was changed to use PF instead of additional control > > plane VSI. Because of that during lag we should control it. Control > > means to add a

[Intel-wired-lan] [tnguy-net-queue:main] BUILD SUCCESS c9ec85153fea6873c52ed4f5055c87263f1b54f9

2024-01-31 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git main branch HEAD: c9ec85153fea6873c52ed4f5055c87263f1b54f9 selftests: net: add missing config for GENEVE elapsed time: 796m configs tested: 169 configs skipped: 4 The following configs have been built successfull

Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread Jiri Pirko
Wed, Jan 31, 2024 at 05:15:46PM CET, pmen...@molgen.mpg.de wrote: >Dear karthiksundaravel, > > >Thank you for your patch. > > >Am 31.01.24 um 09:08 schrieb karthiksundaravel: >> Changing the mac address of the VF representor ports are not > >Do you mean “is not possible”? > >> available via devlink