Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Remove and readd netdev during devlink reload

2024-01-29 Thread Wojciech Drewek
On 27.01.2024 00:19, Brett Creeley wrote: > > > On 1/25/2024 12:54 AM, Wojciech Drewek wrote: >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> Recent changes to the devlink reload (commit 9b234

Re: [Intel-wired-lan] [iwl-next v1 4/8] ice: control default Tx rule in lag

2024-01-29 Thread Simon Horman
On Thu, Jan 25, 2024 at 01:53:10PM +0100, Michal Swiatkowski wrote: > Tx rule in switchdev was changed to use PF instead of additional control > plane VSI. Because of that during lag we should control it. Control > means to add and remove the default Tx rule during lag active/inactive > switching.

[Intel-wired-lan] [PATCH iwl-next v3] ice: Remove and readd netdev during devlink reload

2024-01-29 Thread Wojciech Drewek
Recent changes to the devlink reload (commit 9b2348e2d6c9 ("devlink: warn about existing entities during reload-reinit")) force the drivers to destroy devlink ports during reinit. Adjust ice driver to this requirement, unregister netdvice, destroy devlink port. ice_init_eth() was removed and all th

Re: [Intel-wired-lan] [PATCH v2 0/7 iwl-next] idpf: refactor virtchnl messages

2024-01-29 Thread Alexander Lobakin
From: Alan Brady Date: Thu, 25 Jan 2024 21:47:40 -0800 > The motivation for this series has two primary goals. We want to enable > support of multiple simultaneous messages and make the channel more > robust. The way it works right now, the driver can only send and receive > a single message at a

Re: [Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-29 Thread Marcin Szycik
On 27.01.2024 15:07, Takeru Hayasaka wrote: > This is a patch that enables RSS functionality for GTP packets using ethtool. > > A user can include her TEID and make RSS work for GTP-U over IPv4 by doing > the following: > `ethtool -N ens3 rx-flow-hash gtpu4 sde` > > In addition to gtpu(4|6),

Re: [Intel-wired-lan] [PATCH v2 0/7 iwl-next] idpf: refactor virtchnl messages

2024-01-29 Thread Brady, Alan
> -Original Message- > From: Lobakin, Aleksander > Sent: Monday, January 29, 2024 5:24 AM > To: Brady, Alan > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; > willemdebruijn.ker...@gmail.com; Bagnucki, Igor > ; Kitszel, Przemyslaw > > Subject: Re: [Intel-wired-lan] [PATCH

Re: [Intel-wired-lan] [PATCH v2 0/7 iwl-next] idpf: refactor virtchnl messages

2024-01-29 Thread Alexander Lobakin
From: Brady, Alan Date: Mon, 29 Jan 2024 16:12:06 +0100 >> -Original Message- >> From: Lobakin, Aleksander >> Sent: Monday, January 29, 2024 5:24 AM >> To: Brady, Alan >> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; >> willemdebruijn.ker...@gmail.com; Bagnucki, Igor >>

Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: Remove and readd netdev during devlink reload

2024-01-29 Thread Brett Creeley
On 1/29/2024 4:32 AM, Wojciech Drewek wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Recent changes to the devlink reload (commit 9b2348e2d6c9 ("devlink: warn about existing entities during reload-

[Intel-wired-lan] [PATCH v3 0/7 iwl-next] idpf: refactor virtchnl messages

2024-01-29 Thread Alan Brady
The motivation for this series has two primary goals. We want to enable support of multiple simultaneous messages and make the channel more robust. The way it works right now, the driver can only send and receive a single message at a time and if something goes really wrong, it can lead to data cor

[Intel-wired-lan] [PATCH v3 1/7 iwl-next] idpf: implement virtchnl transaction manager

2024-01-29 Thread Alan Brady
This starts refactoring how virtchnl messages are handled by adding a transaction manager (idpf_vc_xn_manager). There are two primary motivations here which are to enable handling of multiple messages at once and to make it more robust in general. As it is right now, the driver may only have one p

[Intel-wired-lan] [PATCH v3 2/7 iwl-next] idpf: refactor vport virtchnl messages

2024-01-29 Thread Alan Brady
This reworks the way vport related virtchnl messages work to take advantage of the added transaction API. It is fairly mechanical as, to use the transaction API, the function just needs to fill out an appropriate idpf_vc_xn_params struct to pass to idpf_vc_xn_exec which will take care of the actual

[Intel-wired-lan] [PATCH v3 3/7 iwl-next] idpf: refactor queue related virtchnl messages

2024-01-29 Thread Alan Brady
This reworks queue specific virtchnl messages to use the added transaction API. It is fairly mechanical and generally makes the functions using it more simple. Functions using transaction API no longer need to take the vc_buf_lock since it's not using it anymore. After filling out an idpf_vc_xn_pa

[Intel-wired-lan] [PATCH v3 4/7 iwl-next] idpf: refactor remaining virtchnl messages

2024-01-29 Thread Alan Brady
This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This again is mostly mechanical. In absence of an async_handler for MAC filters, this will simply generically report any errors from idpf_vc_xn_forward_async. This maintains the existing behavior. Follow up patch will add an async

[Intel-wired-lan] [PATCH v3 5/7 iwl-next] idpf: add async_handler for MAC filter messages

2024-01-29 Thread Alan Brady
There are situations where the driver needs to add a MAC filter but we're explicitly not allowed to sleep so we can wait for a virtchnl message to complete. This adds an async_handler for asynchronously sent messages for MAC filters so that we can better handle if there's an error of some kind. If

[Intel-wired-lan] [PATCH v3 6/7 iwl-next] idpf: refactor idpf_recv_mb_msg

2024-01-29 Thread Alan Brady
Now that all the messages are using the transaction API, we can rework idpf_recv_mb_msg quite a lot to simplify it. Due to this, we remove idpf_find_vport as no longer used and alter idpf_recv_event_msg slightly. Reviewed-by: Przemek Kitszel Reviewed-by: Igor Bagnucki Signed-off-by: Alan Brady

[Intel-wired-lan] [PATCH v3 7/7 iwl-next] idpf: cleanup virtchnl cruft

2024-01-29 Thread Alan Brady
We can now remove a bunch of gross code we don't need anymore like the vc state bits and vc_buf_lock since everything is using transaction API now. Reviewed-by: Przemek Kitszel Reviewed-by: Igor Bagnucki Signed-off-by: Alan Brady --- drivers/net/ethernet/intel/idpf/idpf.h| 86 -

[Intel-wired-lan] [PATCH RESEND iwl-next 0/2] ice: Introduce switch recipe reusing

2024-01-29 Thread Steven Zou
This patch series firstly fix the bitmap casting issue in getting/mapping recipe to profile association that is used in both legacy and recipe reusing mode, then introduce switch recipe reusing feature as new E810 firmware supports the corresponding functionality. Steven Zou (2): ice: Refactor

[Intel-wired-lan] [PATCH RESEND iwl-next 1/2] ice: Refactor FW data type and fix bitmap casting issue

2024-01-29 Thread Steven Zou
According to the datasheet, the recipe association data is an 8-byte little-endian value. It is described as 'Bitmap of the recipe indexes associated with this profile', it is from 24 to 31 byte area in FW. Therefore, it is defined to '__le64 recipe_assoc' in struct ice_aqc_recipe_to_profile. And t

[Intel-wired-lan] [PATCH RESEND iwl-next 2/2] ice: Add switch recipe reusing feature

2024-01-29 Thread Steven Zou
New E810 firmware supports the corresponding functionality, so the driver allows PFs to subscribe the same switch recipes. Then when the PF is done with a switch recipes, the PF can ask firmware to free that switch recipe. When users configure a rule to PFn into E810 switch component, if there is

Re: [Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-29 Thread takeru hayasaka
Hi Marcin-san Thanks for your review! > Do I understand correctly that all gtpu* include TEID? Maybe write it here. Yes, that's correct. > It would be nice to see a link to the patch that added GTP and 'e' flag > support to ethtool itself ("ethtool: add support for rx-flow-hash gtp"). I will sen

[Intel-wired-lan] [tnguy-net-queue:1GbE] BUILD SUCCESS bbc404d20d1b46d89b461918bc44587620eda200

2024-01-29 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 1GbE branch HEAD: bbc404d20d1b46d89b461918bc44587620eda200 ixgbe: Fix an error handling path in ixgbe_read_iosf_sb_reg_x550() elapsed time: 727m configs tested: 190 configs skipped: 3 The following configs have b

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS f2aae2089368d8e5abb4ec01542c31bc4d011a74

2024-01-29 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue branch HEAD: f2aae2089368d8e5abb4ec01542c31bc4d011a74 igc: Unify filtering rule fields elapsed time: 729m configs tested: 163 configs skipped: 3 The following configs have been built successfully. More