Recent changes to the devlink reload (commit 9b2348e2d6c9
("devlink: warn about existing entities during reload-reinit"))
force the drivers to destroy devlink ports during reinit.
Adjust ice driver to this requirement, unregister netdvice, destroy
devlink port. ice_init_eth() was removed and all th
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karol
> Kolacinski
> Sent: Tuesday, January 23, 2024 4:22 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E ; net...@vger.kernel.org;
> Kolacinski, Karol ; Nguyen, Anthony L
> ; Brandeburg, Jesse
> Subject: [Intel
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karol
> Kolacinski
> Sent: Tuesday, January 23, 2024 4:22 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E ; net...@vger.kernel.org;
> Kolacinski, Karol ; Nguyen, Anthony L
> ; Brandeburg, Jesse
> Subject: [Intel-
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karol
> Kolacinski
> Sent: Tuesday, January 23, 2024 4:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E ; net...@vger.kernel.org;
> Kolacinski, Karol ; Nguyen, Anthony L
> ; Brandeburg, Jesse
> Subject: [Intel-
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karol
> Kolacinski
> Sent: Tuesday, January 23, 2024 4:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E ; net...@vger.kernel.org;
> Kolacinski, Karol ; Nguyen, Anthony L
> ; Brandeburg, Jesse
> Subject: [Intel-
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karol
> Kolacinski
> Sent: Tuesday, January 23, 2024 4:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E ; net...@vger.kernel.org;
> Kolacinski, Karol ; Nguyen, Anthony L
> ; Brandeburg, Jesse
> Subject: [Intel-
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karol
> Kolacinski
> Sent: Tuesday, January 23, 2024 4:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E ; net...@vger.kernel.org;
> Kolacinski, Karol ; Nguyen, Anthony L
> ; Brandeburg, Jesse
> Subject: [Intel-
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karol
> Kolacinski
> Sent: Tuesday, January 23, 2024 4:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E ; net...@vger.kernel.org;
> Kolacinski, Karol ; Nguyen, Anthony L
> ; Brandeburg, Jesse
> Subject: [Intel-
From: Nguyen, Anthony L
Sent: Monday, January 22, 2024 10:19 PM
>On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
>> Currently big amount of the functions returning standard error codes
>> are of type s32. Convert them to regular ints as typdefs here are not
>> necessary to return standard error c
On Tue, Jan 23, 2024 at 12:18:49PM +0100, Wojciech Drewek wrote:
> Recent changes to the devlink reload (commit 9b2348e2d6c9
> ("devlink: warn about existing entities during reload-reinit"))
> force the drivers to destroy devlink ports during reinit.
> Adjust ice driver to this requirement, unregis
+ Dan Carpenter
On Thu, Jan 25, 2024 at 08:20:40AM +0100, Kurt Kanzenbach wrote:
> On Wed Jan 24 2024, Simon Horman wrote:
> > On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote:
> >
> > ...
> >
> >> +static int igc_led_hw_control_set(struct led_classdev *led_cdev,
> >> +
On Wed, Jan 24, 2024 at 09:55:30AM +0100, Kurt Kanzenbach wrote:
> Use reverse xmas tree coding style convention in igc_add_flex_filter().
>
> Signed-off-by: Kurt Kanzenbach
> Acked-by: Vinicius Costa Gomes
Reviewed-by: Simon Horman
On Wed, Jan 24, 2024 at 09:55:31AM +0100, Kurt Kanzenbach wrote:
> All igc filter implementations use netdev_*() printing functions except for
> the flex filters. Unify it.
>
> Signed-off-by: Kurt Kanzenbach
> Acked-by: Vinicius Costa Gomes
Reviewed-by: Simon Horman
On Wed, Jan 24, 2024 at 09:55:32AM +0100, Kurt Kanzenbach wrote:
> All filtering parameters such as EtherType and VLAN TCI are stored in host
> byte order except for the VLAN EtherType. Unify it.
>
> Signed-off-by: Kurt Kanzenbach
> Acked-by: Vinicius Costa Gomes
Reviewed-by: Simon Horman
On 25/01/2024 08:54, Wojciech Drewek wrote:
Recent changes to the devlink reload (commit 9b2348e2d6c9
("devlink: warn about existing entities during reload-reinit"))
force the drivers to destroy devlink ports during reinit.
Adjust ice driver to this requirement, unregister netdvice, destroy
devli
Hi,
Switchdev is using one queue per created port representor. This can
quickly lead to Rx queue shortage, as with subfunction support user
can create high number of PRs.
Save one MSI-X and 'number of PRs' * 1 queues.
Refactor switchdev slow-path to use less resources (even no additional
resource
Changing queues used by eswitch will be done through PF netdev.
There is no need to reserve queues if the number of used queues
is known.
Reviewed-by: Wojciech Drewek
Reviewed-by: Marcin Szycik
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice.h | 6
driver
Tx can be done using PF netdev.
Checks before Tx are unnecessary. Checking if switchdev mode is set
seems too defensive (there is no PR netdev in legacy mode). If
corresponding VF is disabled or during reset, PR netdev also should be
down.
Reviewed-by: Marcin Szycik
Signed-off-by: Michal Swiatko
Steer all packets that miss other rules to PF VSI. Previously in
switchdev mode, PF VSI received missed packets, but only ones marked
as Rx. Now it is receiving all missed packets.
To queue rule per PR isn't needed, because we use PF VSI instead of
control VSI now, and it's already correctly confi
Tx rule in switchdev was changed to use PF instead of additional control
plane VSI. Because of that during lag we should control it. Control
means to add and remove the default Tx rule during lag active/inactive
switching.
It can be done the same way as default Rx rule.
Reviewed-by: Wojciech Drew
For slow-path Rx and Tx PF VSI is used. There is no need to have control
plane VSI. Remove all code related to it.
Eswitch rebuild can't fail without rebuilding control plane VSI. Return
void from ice_eswitch_rebuild().
Reviewed-by: Marcin Szycik
Signed-off-by: Michal Swiatkowski
---
drivers/n
Instead of getting repr::id from xa_alloc() value, set it to the
src_vsi::num_vsi value. It is unique for each PR.
Reviewed-by: Przemek Kitszel
Reviewed-by: Marcin Szycik
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_eswitch.c | 5 ++---
drivers/net/ethernet/intel/ic
Add an ICE_RX_FLAG_MULTIDEV flag to Rx ring.
If it is set try to find correct port representor. Do it based on
src_vsi value stored in flex descriptor. Ids of representor pointers
stored in xarray are equal to corresponding src_vsi value. Thanks to
that we can directly get correct representor if w
Removing control plane VSI result in no information about slow-path
statistic. In current solution statistics need to be counted in driver.
Patch is based on similar implementation done by Simon Horman in nfp:
commit eadfa4c3be99 ("nfp: add stats and xmit helpers for representors")
Add const modi
Fix the connection state between source DPLL and output pin, updating the
attribute 'state' of 'parent_device'. Previously, the connection state
was broken, and didn't reflect the correct state.
When 'state_on_dpll_set' is called with the value
'DPLL_PIN_STATE_CONNECTED' (1), the output pin will s
On Thu, Jan 25, 2024 at 08:31:54AM +0100, Kurt Kanzenbach wrote:
> On Wed Jan 24 2024, Andrew Lunn wrote:
> > On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote:
> >> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
> >> from user space using the netdev trigger.
On 1/24/2024 7:17 PM, Willem de Bruijn wrote:
Alan Brady wrote:
This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This
again is mostly mechanical. There's some added functionality with MAC
filters which makes sure we remove bad filters now that we can better
handle asynchronous
On 1/24/2024 1:26 PM, Simon Horman wrote:
On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote:
From: Paul M Stillwell Jr
Remove a comment that was not correct; this structure has nothing
to do with FW alignment.
Reviewed-by: Przemek Kitszel
Signed-off-by: Paul M Stillwell Jr
Su
On 1/25/2024 2:16 AM, Jagielski, Jedrzej wrote:
From: Nguyen, Anthony L
Sent: Monday, January 22, 2024 10:19 PM
On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
Currently big amount of the functions returning standard error codes
are of type s32. Convert them to regular ints as typdefs here
This is a patch that enables RSS functionality for GTP packets using
ethtool.
A user can include her TEID and make RSS work for GTP-U over IPv4 by
doing the following:
`ethtool -N ens3 rx-flow-hash gtpu4 sde`
In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
gtpu(4|6)u, and
This is a patch that enables RSS functionality for GTP packets using
ethtool.
A user can include her TEID and make RSS work for GTP-U over IPv4 by
doing the following:
`ethtool -N ens3 rx-flow-hash gtpu4 sde`
In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
gtpu(4|6)u, and
This is a patch that enables RSS functionality for GTP packets using
ethtool.
A user can include her TEID and make RSS work for GTP-U over IPv4 by
doing the following:
`ethtool -N ens3 rx-flow-hash gtpu4 sde`
In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
gtpu(4|6)u, and
This is a patch that enables RSS functionality for GTP packets using
ethtool.
A user can include her TEID and make RSS work for GTP-U over IPv4 by
doing the following:
`ethtool -N ens3 rx-flow-hash gtpu4 sde`
In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
gtpu(4|6)u, and
This is a patch that enables RSS functionality for GTP packets using
ethtool.
A user can include her TEID and make RSS work for GTP-U over IPv4 by
doing the following:
`ethtool -N ens3 rx-flow-hash gtpu4 sde`
In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
gtpu(4|6)u, and
The motivation for this series has two primary goals. We want to enable
support of multiple simultaneous messages and make the channel more
robust. The way it works right now, the driver can only send and receive
a single message at a time and if something goes really wrong, it can
lead to data cor
This starts refactoring how virtchnl messages are handled by adding a
transaction manager (idpf_vc_xn_manager).
There are two primary motivations here which are to enable handling of
multiple messages at once and to make it more robust in general. As it
is right now, the driver may only have one p
This reworks the way vport related virtchnl messages work to take
advantage of the added transaction API. It is fairly mechanical as, to
use the transaction API, the function just needs to fill out an
appropriate idpf_vc_xn_params struct to pass to idpf_vc_xn_exec which
will take care of the actual
This reworks queue specific virtchnl messages to use the added
transaction API. It is fairly mechanical and generally makes the
functions using it more simple. Functions using transaction API no
longer need to take the vc_buf_lock since it's not using it anymore.
After filling out an idpf_vc_xn_pa
This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This
again is mostly mechanical.
In absence of an async_handler for MAC filters, this will simply
generically report any errors from idpf_vc_xn_forward_async. This
maintains the existing behavior. Follow up patch will add an async
There are situations where the driver needs to add a MAC filter but
we're explicitly not allowed to sleep so we can wait for a virtchnl
message to complete.
This adds an async_handler for asynchronously sent virtchnl messages for
MAC filters so that we can better handle if there's an error of some
Now that all the messages are using the transaction API, we can rework
idpf_recv_mb_msg quite a lot to simplify it. Due to this, we remove
idpf_find_vport as no longer used and alter idpf_recv_event_msg
slightly.
Reviewed-by: Przemek Kitszel
Reviewed-by: Igor Bagnucki
Signed-off-by: Alan Brady
We can now remove a bunch of gross code we don't need anymore like the
vc state bits and vc_buf_lock since everything is using transaction API
now.
Reviewed-by: Przemek Kitszel
Reviewed-by: Igor Bagnucki
Signed-off-by: Alan Brady
---
drivers/net/ethernet/intel/idpf/idpf.h| 86 -
42 matches
Mail list logo
