Converting s32 functions to regular int in the patch 8035560dbfaf caused
trigerring smatch warnings about missing error code. The bug predates
the mentioned patch.
New smatch warnings:
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em()
warn: missing error code? 'status'
d
Clean up code where touched during type convertion by the patch
8035560dbfaf. Rearrange to fix reverse Christmas tree.
Suggested-by: Tony Nguyen
Signed-off-by: Jedrzej Jagielski
---
.../net/ethernet/intel/ixgbe/ixgbe_82598.c| 14 ++--
.../net/ethernet/intel/ixgbe/ixgbe_82599.c| 40 +
Thanks for this patch!
On Thu, Jan 18, 2024 at 02:43:31PM +0100, Jedrzej Jagielski wrote:
> Converting s32 functions to regular int in the patch 8035560dbfaf caused
> trigerring smatch warnings about missing error code. The bug predates
> the mentioned patch.
It's not really a bug, just some susp
Dear Jedrzej,
Thank you for your patch. Two nits regarding the commit message. For the
summary: *Clean up* after type conver*s*ion.
Am 18.01.24 um 14:43 schrieb Jedrzej Jagielski:> Clean up code where
touched during type convertion by the patch
1. Clean up the code, touched during …
2. c
On 1/18/24 14:43, Jedrzej Jagielski wrote:
Clean up code where touched during type convertion by the patch
8035560dbfaf. Rearrange to fix reverse Christmas tree
I don't see this SHA in my copy, please fix it.
Suggested-by: Tony Nguyen
Signed-off-by: Jedrzej Jagielski
---
.../net/ethernet/
allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc haps_hs_smp_defconfig gcc
arc randconfig-001-20240118 gcc
arc randconfig-002-20240118
On Mon, Jan 15, 2024 at 11:39AM +0100, Simon Horman wrote:
> > @@ -2729,11 +2718,41 @@ void ice_ptp_reset(struct ice_pf *pf, enum
> > ice_reset_req reset_type)
> > if (!ice_is_e810(hw)) {
> > /* Enable quad interrupts */
> > err = ice_ptp_cfg_phy_interrupt(pf,
PTP reset process has multiple places where timestamping can end up in
an incorrect state.
This series introduces a proper state machine for PTP and refactors
a large part of the code to ensure that timestamping does not break.
Jacob Keller (6):
ice: pass reset type to PTP reset functions
ice
From: Jacob Keller
The ice_ptp_prepare_for_reset() and ice_ptp_reset() functions currently
check the pf->flags ICE_FLAG_PFR_REQ bit to determine if the current
reset is a PF reset or not.
This is problematic, because it is possible that a PF reset and a higher
level reset (CORE reset, GLOBAL res
Add PTP state machine so that the driver can correctly identify PTP
state around resets.
When the driver got information about ungraceful reset, PTP was not
prepared for reset and it returned error. When this situation occurs,
prepare PTP before rebuilding its structures.
Co-authored-by: Karol Kol
From: Jacob Keller
The tx->verify_cached flag is used to inform the Tx timestamp tracking
code whether it needs to verify the cached Tx timestamp value against
a previous captured value. This is necessary on E810 hardware which does
not have a Tx timestamp ready bitmap.
In addition, we currently
From: Jacob Keller
E810 hardware does not have a Tx timestamp ready bitmap. Don't check
has_ready_bitmap in E810-specific functions.
Add has_ready_bitmap check in ice_ptp_process_tx_tstamp() to stop
relying on the fact that ice_get_phy_tx_tstamp_ready() returns all 1s.
Signed-off-by: Jacob Kelle
From: Jacob Keller
The ice_ptp_tx_cfg_intr() function sends a control queue message to
configure the PHY timestamp interrupt block. This is a very similar name
to a function which is used to configure the MAC Other Interrupt Cause
Enable register.
Rename this function to ice_ptp_cfg_phy_interrup
From: Jacob Keller
The ice_ptp_reset() function uses a goto to skip past clock owner
operations if performing a PF reset or if the device is not the clock
owner. This is a bit confusing. Factor this out into
ice_ptp_rebuild_owner() instead.
The ice_ptp_reset() function is called by ice_rebuild()
From: Jacob Keller
The ice driver currently attempts to destroy and re-initialize the Tx
timestamp tracker during the reset flow. The release of the Tx tracker
only happened during CORE reset or GLOBAL reset. The ice_ptp_rebuild()
function always calls the ice_ptp_init_tx function which will allo
Hello,
I'm migrating some systems that I used to use the 700 series network
adapters to the 800 series and I am noticing quite a bit of issues
regarding sr-iov. i'm using between 8 and 128 VFs, depending on the
machine.
I am currently using ubuntu 22.04.3 with linux-image-generic-hwe-22.04
6
idpf registers multiple netdevs (virtual ports) for one PCI function,
but it does not provide a way for userspace to distinguish them with
sysfs attributes. Per Documentation/ABI/testing/sysfs-class-net, it is
a bug not to set dev_port for independent ports on the same PCI bus,
device and function.
On 11/20/2023 6:50 PM, Yahui Cao wrote:
> This series adds vfio live migration support for Intel E810 VF devices
> based on the v2 migration protocol definition series discussed here[0].
>
> Steps to test:
> 1. Bind one or more E810 VF devices to the module ice-vfio-pci.ko
> 2. Assign the VFs t
On 12/7/2023 5:53 PM, Brett Creeley wrote:
>
>
> On 11/20/2023 6:51 PM, Yahui Cao wrote:
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> From: Lingyu Liu
>>
>> Save the virtual channel messag
On 12/7/2023 6:53 PM, Tian, Kevin wrote:
>> From: Jason Gunthorpe
>> Sent: Thursday, December 7, 2023 10:46 PM
>>
>> On Thu, Dec 07, 2023 at 07:55:17AM +, Tian, Kevin wrote:
From: Cao, Yahui
Sent: Tuesday, November 21, 2023 10:51 AM
+
+ /* Once RX Queue is
On 1/18/2024 12:50 PM, Michal Schmidt wrote:
> idpf registers multiple netdevs (virtual ports) for one PCI function,
> but it does not provide a way for userspace to distinguish them with
> sysfs attributes. Per Documentation/ABI/testing/sysfs-class-net, it is
> a bug not to set dev_port for indepe
On 1/18/24 19:19, Paul Saab wrote:
Hello,
I'm migrating some systems that I used to use the 700 series network
adapters to the 800 series and I am noticing quite a bit of issues
regarding sr-iov. i'm using between 8 and 128 VFs, depending on the
machine.
I am currently using ubuntu 22.04.3
22 matches
Mail list logo
