Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: Convert ret val type from s32 to int

2024-01-10 Thread Jagielski, Jedrzej
From: Nguyen, Anthony L Sent: Friday, January 5, 2024 10:50 PM >On 1/5/2024 2:31 AM, Jedrzej Jagielski wrote: >> Currently big amount of the functions returning standard error codes >> are of type s32. Convert them to regular ints as typdefs here are >> not necessary to return standard error cod

Re: [Intel-wired-lan] [REGRESSION] Intel ICE Ethernet driver in linux >= 6.6.9 triggers extra memory consumption and cause continous kswapd* usage and continuous swapping

2024-01-10 Thread Jaroslav Pulchart
> > Hello > > I would like to report a regression triggered by recent change in > Intel ICE Ethernet driver in the 6.6.9 linux kernel. The problem was > bisected and the regression is triggered by > fc4d6d136d42fab207b3ce20a8ebfd61a13f931f "ice: alter feature support > check for SRIOV and LAG" comm

Re: [Intel-wired-lan] [REGRESSION] Intel ICE Ethernet driver in linux >= 6.6.9 triggers extra memory consumption and cause continous kswapd* usage and continuous swapping

2024-01-10 Thread Jesse Brandeburg
On 1/8/2024 2:49 AM, Jaroslav Pulchart wrote: > Hello First, thank you for your work trying to chase this! > > I would like to report a regression triggered by recent change in > Intel ICE Ethernet driver in the 6.6.9 linux kernel. The problem was > bisected and the regression is triggered by >

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: Convert ret val type from s32 to int

2024-01-10 Thread Tony Nguyen
On 1/10/2024 3:51 AM, Jagielski, Jedrzej wrote: From: Nguyen, Anthony L Sent: Friday, January 5, 2024 10:50 PM On 1/5/2024 2:31 AM, Jedrzej Jagielski wrote: ... @@ -93,11 +93,11 @@ static s32 ixgbe_get_invariants_82598(struct ixgbe_hw *hw) * not known. Perform the SFP init if nece

[Intel-wired-lan] [PATCH iwl-net] i40e: Include types.h to some headers

2024-01-10 Thread Tony Nguyen
Commit 56df345917c0 ("i40e: Remove circular header dependencies and fix headers") redistributed a number of includes from one large header file to the locations they were needed. In some environments, types.h is not included and causing compile issues. The driver should not rely on implicit inclusi