Added a missing curly braces to avoid entering to an if statement
where it is not always required in e1000_shutdown function.
This improves code readability and might prevent a non-deterministic
behaviour in the future.
Signed-off-by: Vitaly Lifshits
---
drivers/net/ethernet/intel/e1000e/netdev.
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Przemek Kitszel
> Sent: Thursday, December 21, 2023 2:49 PM
> To: Staikov, Andrii ;
> intel-wired-...@lists.osuosl.org
> Cc: Ostrowska, Karen ; net...@vger.kernel.org;
> Drewek, Wojciech ; Mateusz Palczewski
>
> Subject: Re: [In
From: Arnd Bergmann
The newly added function fails to build when struct xsk_cb_desc is
not defined:
drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb':
drivers/net/ethernet/intel/ice/ice_base.c:525:16: error: variable 'desc' has
initializer but incomplete type
Hide t
On Wed, Jan 03, 2024 at 11:24:45AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The newly added function fails to build when struct xsk_cb_desc is
> not defined:
>
> drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb':
> drivers/net/ethernet/intel/ice/ice_base.
On Wed, Jan 3, 2024, at 11:54, Maciej Fijalkowski wrote:
> On Wed, Jan 03, 2024 at 11:24:45AM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann
>>
>> The newly added function fails to build when struct xsk_cb_desc is
>> not defined:
>>
>> drivers/net/ethernet/intel/ice/ice_base.c: In function
"Song, Yoong Siang" writes:
> On Tuesday, January 2, 2024 10:51 PM, Gomes, Vinicius
> wrote:
>>Song Yoong Siang writes:
>>
>>> This patch adds support to per-packet Tx hardware timestamp request to
>>> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
>>> user needs to en
From: Aniruddha Paul
HW incorrectly reports EIPE errors on encapsulated packets
with L2 padding inside inner packet. HW shows outer UDP/IPV4
packet checksum errors as part of the EIPE flags of the
Rx descriptor. These are reported only if checksum offload
is enabled and L3/L4 parsed flag is valid
Dear Vitaly,
Thank you for the patch.
In the commit message summary, it’d be great if you used a statement by
adding a verb in imperative mood. Maybe:
Correct flow in e1000_shutdown()
Am 03.01.24 um 09:50 schrieb Vitaly Lifshits:
Added a missing curly braces to avoid entering to an if stat
Dear Arnd,
Thank you for your patch. There is a small typo in the commit message
summary: withouto → without
Kind regards,
Paul
On Wed, Dec 06, 2023 at 12:59:09PM +0100, Heiner Kallweit wrote:
> On 06.12.2023 10:37, Johannes Berg wrote:
> > On Wed, 2023-12-06 at 09:46 +0100, Przemek Kitszel wrote:
> >>
> >> That sounds right too; one could argue if your fix is orthogonal to that
> >> or not. I would say that your fix makes
On Tuesday, January 2, 2024 10:51 PM, Gomes, Vinicius
wrote:
>Song Yoong Siang writes:
>
>> This patch adds support to per-packet Tx hardware timestamp request to
>> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
>> user needs to enable Tx HW timestamp capability via igc
On Wednesday, January 3, 2024 7:47 AM, John Fastabend
wrote:
>Song Yoong Siang wrote:
>> This patch adds support to per-packet Tx hardware timestamp request to
>> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
>> user needs to enable Tx HW timestamp capability via igc_ioc
From: Lakshmi Sowjanya D
The goal of the PPS(Pulse Per Second) hardware/software is to generate a
signal from the system on a wire so that some third-party hardware can
observe that signal and judge how close the system's time is to another
system or piece of hardware.
Existing methods (like par
From: Lakshmi Sowjanya D
Add hardware abstraction, struct clocksource_base in clocksource.
Add clocksource ID for x86 ART(Always Running Timer).
Co-developed-by: Thomas Gleixner
Signed-off-by: Thomas Gleixner
Co-developed-by: Christopher S. Hall
Signed-off-by: Christopher S. Hall
Signed-off
From: Lakshmi Sowjanya D
Introduce an interface ktime_real_to_base_clock(), to convert realtime
to base clock.
Convert base clock to system clock using convert_base_to_cs() in
get_device_system_crosststamp().
Add a helper function to check whether the current clocksource has same
base clock.
C
From: Thomas Gleixner
Remove convert_art_to_tsc() function call, Pass system clock cycles and
clocksource ID as input to get_device_system_crosststamp().
Signed-off-by: Thomas Gleixner
Signed-off-by: Lakshmi Sowjanya D
---
drivers/net/ethernet/intel/igc/igc_ptp.c | 6 +-
1 file changed, 5
From: Thomas Gleixner
Remove convert_art_to_tsc() function call, Pass system clock cycles and
clocksource ID as input to get_device_system_crosststamp().
Signed-off-by: Thomas Gleixner
Signed-off-by: Lakshmi Sowjanya D
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 3 ++-
1 file chan
From: Thomas Gleixner
Remove convert_art_to_tsc() function call, Pass system clock cycles and
clocksource ID as input to get_device_system_crosststamp().
Signed-off-by: Thomas Gleixner
Signed-off-by: Lakshmi Sowjanya D
---
drivers/net/ethernet/intel/e1000e/ptp.c | 3 ++-
1 file changed, 2 ins
From: Thomas Gleixner
Remove convert_art_to_tsc() function call, Pass system clock cycles and
clocksource ID as input to get_device_system_crosststamp().
Signed-off-by: Thomas Gleixner
Signed-off-by: Lakshmi Sowjanya D
---
sound/pci/hda/hda_controller.c | 3 ++-
1 file changed, 2 insertions(+
From: Thomas Gleixner
Remove convert_art_to_tsc() function call, Pass system clock cycles and
clocksource ID as input to get_device_system_crosststamp().
Signed-off-by: Thomas Gleixner
Signed-off-by: Lakshmi Sowjanya D
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +-
1 file changed, 1 ins
From: Lakshmi Sowjanya D
The convert_art_to_tsc() and convert_art_ns_to_tsc() interfaces are no
longer required. This conversion is internally done in
get_device_system_crosststamp() using convert_base_to_cs().
Signed-off-by: Lakshmi Sowjanya D
---
arch/x86/include/asm/tsc.h | 3 --
arch/x86/
From: Lakshmi Sowjanya D
The Intel Timed IO PPS generator driver outputs a PPS signal using
dedicated hardware that is more accurate than software actuated PPS.
The Timed IO hardware generates output events using the ART timer.
The ART timer period varies based on platform type, but is less than
From: Lakshmi Sowjanya D
Add Intel Timed I/O PPS usage instructions.
Co-developed-by: Pandith N
Signed-off-by: Pandith N
Signed-off-by: Lakshmi Sowjanya D
Reviewed-by: Andy Shevchenko
---
Documentation/driver-api/pps.rst | 22 ++
1 file changed, 22 insertions(+)
diff --
From: Lakshmi Sowjanya D
Document sysfs interface for Intel Timed I/O PPS driver
Signed-off-by: Lakshmi Sowjanya D
---
Documentation/ABI/testing/sysfs-platform-pps-tio | 7 +++
1 file changed, 7 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-platform-pps-tio
diff --git
On 1/3/24 03:56, lakshmi.sowjany...@intel.com wrote:
> From: Lakshmi Sowjanya D
>
> Add Intel Timed I/O PPS usage instructions.
>
> Co-developed-by: Pandith N
> Signed-off-by: Pandith N
> Signed-off-by: Lakshmi Sowjanya D
> Reviewed-by: Andy Shevchenko
> ---
> Documentation/driver-api/pp
allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20240103 gcc
arc randconfig-002-20240103 gcc
arm
arc allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20240103 gcc
arc randconfig-002-20240103 gcc
arm
On 12/27/2023 2:33 AM, Vitaly Lifshits wrote:
On some Meteor Lake systems accessing the PHY via the MDIO interface may
result in an MDI error. This issue happens sporadically and in most cases
a second access to the PHY via the MDIO interface results in success.
As a workaround, introduce a r
Dear Lakshmi,
Thank you for your patch.
Am 03.01.24 um 12:56 schrieb lakshmi.sowjany...@intel.com:
From: Lakshmi Sowjanya D
Document sysfs interface for Intel Timed I/O PPS driver
I’d add a dot/period at the end.
Signed-off-by: Lakshmi Sowjanya D
---
Documentation/ABI/testing/sysfs-pl
[Re-sent with diff removed, so message size limit of 90 kB of list
Intel-wired-lan is met.]
Dear Jedrzej,
Thank you for your patch.
Am 03.01.24 um 11:11 schrieb Jedrzej Jagielski:
Currently big amount of the functions returning standard
error codes are of type s32. Convert them to regular
in
30 matches
Mail list logo