[Intel-wired-lan] [PATH iwl-next v1 1/1] e1000e: Minor flow correction in e1000_shutdown function

2024-01-03 Thread Vitaly Lifshits
Added a missing curly braces to avoid entering to an if statement where it is not always required in e1000_shutdown function. This improves code readability and might prevent a non-deterministic behaviour in the future. Signed-off-by: Vitaly Lifshits --- drivers/net/ethernet/intel/e1000e/netdev.

Re: [Intel-wired-lan] [PATCH iwl-net v5] i40e: Restore VF MSI-X state during PCI reset

2024-01-03 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Przemek Kitszel > Sent: Thursday, December 21, 2023 2:49 PM > To: Staikov, Andrii ; > intel-wired-...@lists.osuosl.org > Cc: Ostrowska, Karen ; net...@vger.kernel.org; > Drewek, Wojciech ; Mateusz Palczewski > > Subject: Re: [In

[Intel-wired-lan] [PATCH] ice: fix building withouto XDP

2024-01-03 Thread Arnd Bergmann
From: Arnd Bergmann The newly added function fails to build when struct xsk_cb_desc is not defined: drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb': drivers/net/ethernet/intel/ice/ice_base.c:525:16: error: variable 'desc' has initializer but incomplete type Hide t

Re: [Intel-wired-lan] [PATCH] ice: fix building withouto XDP

2024-01-03 Thread Maciej Fijalkowski
On Wed, Jan 03, 2024 at 11:24:45AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added function fails to build when struct xsk_cb_desc is > not defined: > > drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb': > drivers/net/ethernet/intel/ice/ice_base.

Re: [Intel-wired-lan] [PATCH] ice: fix building withouto XDP

2024-01-03 Thread Arnd Bergmann
On Wed, Jan 3, 2024, at 11:54, Maciej Fijalkowski wrote: > On Wed, Jan 03, 2024 at 11:24:45AM +0100, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The newly added function fails to build when struct xsk_cb_desc is >> not defined: >> >> drivers/net/ethernet/intel/ice/ice_base.c: In function

Re: [Intel-wired-lan] [PATCH iwl-next, v1 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-01-03 Thread Vinicius Costa Gomes
"Song, Yoong Siang" writes: > On Tuesday, January 2, 2024 10:51 PM, Gomes, Vinicius > wrote: >>Song Yoong Siang writes: >> >>> This patch adds support to per-packet Tx hardware timestamp request to >>> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that >>> user needs to en

[Intel-wired-lan] [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors

2024-01-03 Thread Jan Sokolowski
From: Aniruddha Paul HW incorrectly reports EIPE errors on encapsulated packets with L2 padding inside inner packet. HW shows outer UDP/IPV4 packet checksum errors as part of the EIPE flags of the Rx descriptor. These are reported only if checksum offload is enabled and L3/L4 parsed flag is valid

Re: [Intel-wired-lan] [PATH iwl-next v1 1/1] e1000e: Minor flow correction in e1000_shutdown function

2024-01-03 Thread Paul Menzel
Dear Vitaly, Thank you for the patch. In the commit message summary, it’d be great if you used a statement by adding a verb in imperative mood. Maybe: Correct flow in e1000_shutdown() Am 03.01.24 um 09:50 schrieb Vitaly Lifshits: Added a missing curly braces to avoid entering to an if stat

Re: [Intel-wired-lan] [PATCH] ice: fix building withouto XDP

2024-01-03 Thread Paul Menzel
Dear Arnd, Thank you for your patch. There is a small typo in the commit message summary: withouto → without Kind regards, Paul

Re: [Intel-wired-lan] [RFC PATCH] net: ethtool: do runtime PM outside RTNL

2024-01-03 Thread Stanislaw Gruszka
On Wed, Dec 06, 2023 at 12:59:09PM +0100, Heiner Kallweit wrote: > On 06.12.2023 10:37, Johannes Berg wrote: > > On Wed, 2023-12-06 at 09:46 +0100, Przemek Kitszel wrote: > >> > >> That sounds right too; one could argue if your fix is orthogonal to that > >> or not. I would say that your fix makes

Re: [Intel-wired-lan] [PATCH iwl-next, v1 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-01-03 Thread Song, Yoong Siang
On Tuesday, January 2, 2024 10:51 PM, Gomes, Vinicius wrote: >Song Yoong Siang writes: > >> This patch adds support to per-packet Tx hardware timestamp request to >> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that >> user needs to enable Tx HW timestamp capability via igc

Re: [Intel-wired-lan] [PATCH iwl-next, v1 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-01-03 Thread Song, Yoong Siang
On Wednesday, January 3, 2024 7:47 AM, John Fastabend wrote: >Song Yoong Siang wrote: >> This patch adds support to per-packet Tx hardware timestamp request to >> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that >> user needs to enable Tx HW timestamp capability via igc_ioc

[Intel-wired-lan] [RFC PATCH v3 00/11] Add support for Intel PPS Generator

2024-01-03 Thread lakshmi . sowjanya . d
From: Lakshmi Sowjanya D The goal of the PPS(Pulse Per Second) hardware/software is to generate a signal from the system on a wire so that some third-party hardware can observe that signal and judge how close the system's time is to another system or piece of hardware. Existing methods (like par

[Intel-wired-lan] [RFC PATCH v3 01/11] x86/tsc: Add base clock properties in clocksource structure

2024-01-03 Thread lakshmi . sowjanya . d
From: Lakshmi Sowjanya D Add hardware abstraction, struct clocksource_base in clocksource. Add clocksource ID for x86 ART(Always Running Timer). Co-developed-by: Thomas Gleixner Signed-off-by: Thomas Gleixner Co-developed-by: Christopher S. Hall Signed-off-by: Christopher S. Hall Signed-off

[Intel-wired-lan] [RFC PATCH v3 02/11] timekeeping: Add function to convert realtime to base clock

2024-01-03 Thread lakshmi . sowjanya . d
From: Lakshmi Sowjanya D Introduce an interface ktime_real_to_base_clock(), to convert realtime to base clock. Convert base clock to system clock using convert_base_to_cs() in get_device_system_crosststamp(). Add a helper function to check whether the current clocksource has same base clock. C

[Intel-wired-lan] [RFC PATCH v3 04/11] igc: remove convert_art_to_tsc()

2024-01-03 Thread lakshmi . sowjanya . d
From: Thomas Gleixner Remove convert_art_to_tsc() function call, Pass system clock cycles and clocksource ID as input to get_device_system_crosststamp(). Signed-off-by: Thomas Gleixner Signed-off-by: Lakshmi Sowjanya D --- drivers/net/ethernet/intel/igc/igc_ptp.c | 6 +- 1 file changed, 5

[Intel-wired-lan] [RFC PATCH v3 05/11] stmmac: intel: remove convert_art_to_tsc()

2024-01-03 Thread lakshmi . sowjanya . d
From: Thomas Gleixner Remove convert_art_to_tsc() function call, Pass system clock cycles and clocksource ID as input to get_device_system_crosststamp(). Signed-off-by: Thomas Gleixner Signed-off-by: Lakshmi Sowjanya D --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 3 ++- 1 file chan

[Intel-wired-lan] [RFC PATCH v3 03/11] e10002: remove convert_art_to_tsc()

2024-01-03 Thread lakshmi . sowjanya . d
From: Thomas Gleixner Remove convert_art_to_tsc() function call, Pass system clock cycles and clocksource ID as input to get_device_system_crosststamp(). Signed-off-by: Thomas Gleixner Signed-off-by: Lakshmi Sowjanya D --- drivers/net/ethernet/intel/e1000e/ptp.c | 3 ++- 1 file changed, 2 ins

[Intel-wired-lan] [RFC PATCH v3 06/11] ALSA: hda: remove convert_art_to_tsc()

2024-01-03 Thread lakshmi . sowjanya . d
From: Thomas Gleixner Remove convert_art_to_tsc() function call, Pass system clock cycles and clocksource ID as input to get_device_system_crosststamp(). Signed-off-by: Thomas Gleixner Signed-off-by: Lakshmi Sowjanya D --- sound/pci/hda/hda_controller.c | 3 ++- 1 file changed, 2 insertions(+

[Intel-wired-lan] [RFC PATCH v3 07/11] ice/ptp: remove convert_art_to_tsc()

2024-01-03 Thread lakshmi . sowjanya . d
From: Thomas Gleixner Remove convert_art_to_tsc() function call, Pass system clock cycles and clocksource ID as input to get_device_system_crosststamp(). Signed-off-by: Thomas Gleixner Signed-off-by: Lakshmi Sowjanya D --- drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +- 1 file changed, 1 ins

[Intel-wired-lan] [RFC PATCH v3 08/11] x86/tsc: Remove art to tsc conversion functions which are obsolete

2024-01-03 Thread lakshmi . sowjanya . d
From: Lakshmi Sowjanya D The convert_art_to_tsc() and convert_art_ns_to_tsc() interfaces are no longer required. This conversion is internally done in get_device_system_crosststamp() using convert_base_to_cs(). Signed-off-by: Lakshmi Sowjanya D --- arch/x86/include/asm/tsc.h | 3 -- arch/x86/

[Intel-wired-lan] [RFC PATCH v3 09/11] pps: generators: Add PPS Generator TIO Driver

2024-01-03 Thread lakshmi . sowjanya . d
From: Lakshmi Sowjanya D The Intel Timed IO PPS generator driver outputs a PPS signal using dedicated hardware that is more accurate than software actuated PPS. The Timed IO hardware generates output events using the ART timer. The ART timer period varies based on platform type, but is less than

[Intel-wired-lan] [RFC PATCH v3 10/11] Documentation: driver-api: pps: Add Intel Timed I/O PPS generator

2024-01-03 Thread lakshmi . sowjanya . d
From: Lakshmi Sowjanya D Add Intel Timed I/O PPS usage instructions. Co-developed-by: Pandith N Signed-off-by: Pandith N Signed-off-by: Lakshmi Sowjanya D Reviewed-by: Andy Shevchenko --- Documentation/driver-api/pps.rst | 22 ++ 1 file changed, 22 insertions(+) diff --

[Intel-wired-lan] [RFC PATCH v3 11/11] ABI: pps: Add ABI documentation for Intel TIO

2024-01-03 Thread lakshmi . sowjanya . d
From: Lakshmi Sowjanya D Document sysfs interface for Intel Timed I/O PPS driver Signed-off-by: Lakshmi Sowjanya D --- Documentation/ABI/testing/sysfs-platform-pps-tio | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-platform-pps-tio diff --git

Re: [Intel-wired-lan] [RFC PATCH v3 10/11] Documentation: driver-api: pps: Add Intel Timed I/O PPS generator

2024-01-03 Thread Randy Dunlap
On 1/3/24 03:56, lakshmi.sowjany...@intel.com wrote: > From: Lakshmi Sowjanya D > > Add Intel Timed I/O PPS usage instructions. > > Co-developed-by: Pandith N > Signed-off-by: Pandith N > Signed-off-by: Lakshmi Sowjanya D > Reviewed-by: Andy Shevchenko > --- > Documentation/driver-api/pp

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 55f96e8bbea09afbd0ce95cc281ec2597ddafb81

2024-01-03 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240103 gcc arc randconfig-002-20240103 gcc arm

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS 3027e7b15b02d2d37e3f82d6b8404f6d37e3b8cf

2024-01-03 Thread kernel test robot
arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240103 gcc arc randconfig-002-20240103 gcc arm

Re: [Intel-wired-lan] [PATCH iwl-net v3 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

2024-01-03 Thread Tony Nguyen
On 12/27/2023 2:33 AM, Vitaly Lifshits wrote: On some Meteor Lake systems accessing the PHY via the MDIO interface may result in an MDI error. This issue happens sporadically and in most cases a second access to the PHY via the MDIO interface results in success. As a workaround, introduce a r

Re: [Intel-wired-lan] [RFC PATCH v3 11/11] ABI: pps: Add ABI documentation for Intel TIO

2024-01-03 Thread Paul Menzel
Dear Lakshmi, Thank you for your patch. Am 03.01.24 um 12:56 schrieb lakshmi.sowjany...@intel.com: From: Lakshmi Sowjanya D Document sysfs interface for Intel Timed I/O PPS driver I’d add a dot/period at the end. Signed-off-by: Lakshmi Sowjanya D --- Documentation/ABI/testing/sysfs-pl

Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: Convert ret val type from s32 to int

2024-01-03 Thread Paul Menzel
[Re-sent with diff removed, so message size limit of 90 kB of list Intel-wired-lan is met.] Dear Jedrzej, Thank you for your patch. Am 03.01.24 um 11:11 schrieb Jedrzej Jagielski: Currently big amount of the functions returning standard error codes are of type s32. Convert them to regular in