Re: [Intel-wired-lan] [PATCH v4 2/3] e1000e: Use PCI_EXP_LNKSTA_NLW & FIELD_GET() instead of custom defines/code

2023-12-10 Thread naamax.meir
On 11/21/2023 14:34, Ilpo Järvinen wrote: e1000e has own copy of PCI Negotiated Link Width field defines. Use the ones from include/uapi/linux/pci_regs.h instead of the custom ones and remove the custom ones and convert to FIELD_GET(). Suggested-by: Jonathan Cameron Signed-off-by: Ilpo Järvinen

Re: [Intel-wired-lan] [PATCH iwl-net] ice: stop trashing VF VSI aggregator node ID information

2023-12-10 Thread Simon Horman
+ Ivan Vecera On Wed, Dec 06, 2023 at 12:19:05PM -0800, Jacob Keller wrote: > When creating new VSIs, they are assigned into an aggregator node in the > scheduler tree. Information about which aggregator node a VSI is assigned > into is maintained by the vsi->agg_node structure. In ice_vsi_decfg(

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Check VLAN EtherType mask

2023-12-10 Thread Simon Horman
On Wed, Dec 06, 2023 at 03:07:18PM +0100, Kurt Kanzenbach wrote: > Currently the driver accepts VLAN EtherType steering rules regardless of > the configured mask. And things might fail silently or with confusing error > messages to the user. The VLAN EtherType can only be matched by full > mask. Th

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/2] igc: Report VLAN EtherType matching back to user

2023-12-10 Thread Simon Horman
On Fri, Dec 01, 2023 at 08:50:42AM +0100, Kurt Kanzenbach wrote: > Currently the driver allows to configure matching by VLAN EtherType. > However, the retrieval function does not report it back to the user. Add > it. > > Before: > |root@host:~# ethtool -N enp3s0 flow-type ether vlan-etype 0x8100 a

Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] igc: Check VLAN TCI mask

2023-12-10 Thread Simon Horman
On Fri, Dec 01, 2023 at 08:50:43AM +0100, Kurt Kanzenbach wrote: > Currently the driver accepts VLAN TCI steering rules regardless of the > configured mask. And things might fail silently or with confusing error > messages to the user. > > There are two ways to handle the VLAN TCI mask: > > 1. M

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: Do not get coalesce settings while in reset

2023-12-10 Thread Simon Horman
On Wed, Dec 06, 2023 at 06:39:36PM +0100, Pawel Chmielewski wrote: > From: Ngai-Mint Kwan > > Getting coalesce settings while reset is in progress can cause NULL > pointer deference bug. > If under reset, abort get coalesce for ethtool. > > Fixes: 67fe64d78c437 ("ice: Implement getting and setti

Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/2] ice: Schedule service task in IRQ top half

2023-12-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Wednesday, November 29, 2023 6:10 PM > To: intel-wired-...@lists.osuosl.org > Cc: Michalik, Michal ; net...@vger.kernel.org; > Brandeburg, Jesse ; Kolacinski, Karol > ; Nguyen, Anthony L ; > Kitszel, P

Re: [Intel-wired-lan] [PATCH v2 iwl-next 2/2] ice: Enable SW interrupt from FW for LL TS

2023-12-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Wednesday, November 29, 2023 6:10 PM > To: intel-wired-...@lists.osuosl.org > Cc: Kitszel, Przemyslaw ; Brandeburg, Jesse > ; Kolacinski, Karol ; > Nguyen, Anthony L ; Hagvi, Yochai > ; net...@vger.ker

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix ST code value for Clause 45

2023-12-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Wednesday, November 29, 2023 9:47 PM > To: net...@vger.kernel.org > Cc: Kitszel, Przemyslaw ; Brandeburg, Jesse > ; open list ; > Loktionov, Aleksandr ; Eric Dumazet > ; Nguyen, Anthony L ; > moderated lis

Re: [Intel-wired-lan] [PATCH net] ice: fix theoretical out-of-bounds access in ethtool link modes

2023-12-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Michal Schmidt > Sent: Thursday, November 30, 2023 10:28 PM > To: net...@vger.kernel.org > Cc: Nguyen, Anthony L ; Greenwalt, Paul > ; intel-wired-...@lists.osuosl.org; Brandeburg, > Jesse > Subject: [Intel-wired-lan] [PATCH n

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic

2023-12-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jan > Sokolowski > Sent: Wednesday, December 6, 2023 4:14 PM > To: intel-wired-...@lists.osuosl.org > Cc: Sokolowski, Jan ; Polchlopek, Mateusz > > Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors > stati

Re: [Intel-wired-lan] [PATCH] ice: Fix some null pointer dereference issues in ice_ptp.c

2023-12-10 Thread Przemek Kitszel
On 12/11/23 07:26, Kunwu Chan wrote: devm_kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Fixes: d938a8cca88a ("ice: Auxbus devices & driver for E822 TS") Cc: Kunwu Chan Signed-off-by: Kunwu Chan I would suggest adding "iwl-net" as a target here