Re: [Intel-wired-lan] [PATCH v5 1/5] i40e: Use existing helper to find flow director VSI

2023-12-03 Thread Simon Horman
On Fri, Nov 24, 2023 at 04:03:39PM +0100, Ivan Vecera wrote: > Use existing i40e_find_vsi_by_type() to find a VSI > associated with flow director. > > Reviewed-by: Wojciech Drewek > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman ___ Intel-wire

Re: [Intel-wired-lan] [PATCH v5 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs

2023-12-03 Thread Simon Horman
On Fri, Nov 24, 2023 at 04:03:40PM +0100, Ivan Vecera wrote: > Introduce i40e_for_each_vsi() and i40e_for_each_veb() helper > macros and use them to iterate relevant arrays. > > Replace pattern: > for (i = 0; i < pf->num_alloc_vsi; i++) > by: > i40e_for_each_vsi(pf, i, vsi) > > and pattern: > for

Re: [Intel-wired-lan] [PATCH v5 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-12-03 Thread Simon Horman
On Fri, Nov 24, 2023 at 04:03:41PM +0100, Ivan Vecera wrote: > Add two helpers i40e_(veb|vsi)_get_by_seid() to find corresponding > VEB or VSI by their SEID value and use these helpers to replace > existing open-coded loops. > > Reviewed-by: Wojciech Drewek > Signed-off-by: Ivan Vecera Reviewed

Re: [Intel-wired-lan] [PATCH v5 4/5] i40e: Fix broken support for floating VEBs

2023-12-03 Thread Simon Horman
On Fri, Nov 24, 2023 at 04:03:42PM +0100, Ivan Vecera wrote: > Although the i40e supports so-called floating VEB (VEB without > an uplink connection to external network), this support is > broken. This functionality is currently unused (except debugfs) > but it will be used by subsequent series for

Re: [Intel-wired-lan] [PATCH v5 5/5] i40e: Remove VEB recursion

2023-12-03 Thread Simon Horman
On Fri, Nov 24, 2023 at 04:03:43PM +0100, Ivan Vecera wrote: > The VEB (virtual embedded switch) as a switch element can be > connected according datasheet though its uplink to: > - Physical port > - Port Virtualizer (not used directly by i40e driver but can > be present in MFP mode where the phy

Re: [Intel-wired-lan] [PATCH net-next v18 1/5] ice: remove FW logging code

2023-12-03 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Paul > M Stillwell Jr > Sent: Wednesday, November 29, 2023 4:57 AM > To: intel-wired-...@lists.osuosl.org > Cc: Stillwell Jr, Paul M > Subject: [Intel-wired-lan] [PATCH net-next v18 1/5] ice: remove FW logging > code > > The FW l

Re: [Intel-wired-lan] [PATCH net-next v18 2/5] ice: configure FW logging

2023-12-03 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Paul > M Stillwell Jr > Sent: Wednesday, November 29, 2023 4:57 AM > To: intel-wired-...@lists.osuosl.org > Cc: Stillwell Jr, Paul M > Subject: [Intel-wired-lan] [PATCH net-next v18 2/5] ice: configure FW logging > > Users want th

Re: [Intel-wired-lan] [PATCH net-next v18 3/5] ice: enable FW logging

2023-12-03 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Paul > M Stillwell Jr > Sent: Wednesday, November 29, 2023 4:57 AM > To: intel-wired-...@lists.osuosl.org > Cc: Stillwell Jr, Paul M > Subject: [Intel-wired-lan] [PATCH net-next v18 3/5] ice: enable FW logging > > Once users have

Re: [Intel-wired-lan] [PATCH net-next v18 4/5] ice: add ability to read FW log data and configure the amount of memory for log data

2023-12-03 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Paul > M Stillwell Jr > Sent: Wednesday, November 29, 2023 4:57 AM > To: intel-wired-...@lists.osuosl.org > Cc: Stillwell Jr, Paul M > Subject: [Intel-wired-lan] [PATCH net-next v18 4/5] ice: add ability to read > FW log data and