Re: [Intel-wired-lan] [PATCH iwl-net v4] ice: Block PF reinit if attached to bond

2023-11-28 Thread Przemek Kitszel
On 11/28/23 08:37, Jiri Pirko wrote: Mon, Nov 27, 2023 at 05:23:55PM CET, sachin.baha...@intel.com wrote: Nack. Remove the netdev during re-init, that would solve your issue. Looks like some checks are needed to be added in devlink code to make sure drivers behave properly. I'm on in. Sure.

Re: [Intel-wired-lan] The difference between linux kernel driver and FreeBSD's with Intel X533

2023-11-28 Thread Skyler Mäntysaari
On 11/28/23 04:20, Ivan Pang wrote: On Wed, Oct 18, 2023 at 09:50:35PM +0300, Skyler Mäntysaari wrote: On Tue, Oct 10, 2023, at 03:39, Skyler Mäntysaari wrote: On Tue, Oct 10, 2023, at 02:50, Skyler Mäntysaari wrote: On Mon, Oct 9, 2023, at 18:33, Jesse Brandeburg wrote: On 10/4/2023 10:08 A

Re: [Intel-wired-lan] The difference between linux kernel driver and FreeBSD's with Intel X533

2023-11-28 Thread Skyler Mäntysaari
On 11/28/23 04:20, Ivan Pang wrote: On Wed, Oct 18, 2023 at 09:50:35PM +0300, Skyler Mäntysaari wrote: On Tue, Oct 10, 2023, at 03:39, Skyler Mäntysaari wrote: On Tue, Oct 10, 2023, at 02:50, Skyler Mäntysaari wrote: On Mon, Oct 9, 2023, at 18:33, Jesse Brandeburg wrote: On 10/4/2023 10:08 AM

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: Improve logs for max ntuple errors

2023-11-28 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Pawel > Kaminski > Sent: Tuesday, November 21, 2023 7:02 AM > To: intel-wired-lan@osuosl.org > Cc: net...@vger.kernel.org; Kaminski, Pawel ; > Brandeburg, Jesse > Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: Improve logs f

Re: [Intel-wired-lan] The difference between linux kernel driver and FreeBSD's with Intel X533

2023-11-28 Thread Ivan Pang
On Wed, Oct 18, 2023 at 09:50:35PM +0300, Skyler Mäntysaari wrote: > On Tue, Oct 10, 2023, at 03:39, Skyler Mäntysaari wrote: > > On Tue, Oct 10, 2023, at 02:50, Skyler Mäntysaari wrote: > >> On Mon, Oct 9, 2023, at 18:33, Jesse Brandeburg wrote: > >>> On 10/4/2023 10:08 AM, Skyler Mäntysaari wrote

Re: [Intel-wired-lan] [PATCH net-next v5 03/14] page_pool: avoid calling no-op externals when possible

2023-11-28 Thread Alexander Lobakin
From: Jakub Kicinski Date: Mon, 27 Nov 2023 10:17:20 -0800 > On Mon, 27 Nov 2023 15:32:19 +0100 Alexander Lobakin wrote: >>> Sorry for not remembering the suggestion:( >> >> In the previous versions of this change I used a global flag per whole >> page_pool, just like XSk does for the whole XSk

Re: [Intel-wired-lan] [PATCH iwl-net v4] ice: Block PF reinit if attached to bond

2023-11-28 Thread Bahadur, Sachin
> From: Jiri Pirko > Sent: Monday, November 27, 2023 11:38 PM > To: Bahadur, Sachin > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond > > Mon, Nov 27, 2023 at 05:23:55PM CE

[Intel-wired-lan] [PATCH iwl-next v1] ice: Print NIC FW version during init

2023-11-28 Thread Sachin Bahadur
Print NIC FW version during PF initialization. FW version in dmesg is used to identify and isolate issues. Particularly useful when dmesg is read after reboot. Reviewed-by: Pawel Kaminski Signed-off-by: Sachin Bahadur --- drivers/net/ethernet/intel/ice/ice_main.c | 6 ++ 1 file changed, 6 i

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: Print NIC FW version during init

2023-11-28 Thread Paul Menzel
Dear Sachin, Thank you for the patch. Am 28.11.23 um 19:35 schrieb Sachin Bahadur: Print NIC FW version during PF initialization. FW version in dmesg is used to identify and isolate issues. Particularly useful when dmesg is read after reboot. Please paste one example log line into the commit

[Intel-wired-lan] [PATCH iwl-next v4] ice: replace ice_vf_recreate_vsi() with ice_vf_reconfig_vsi()

2023-11-28 Thread Jacob Keller
The ice_vf_create_vsi() function and its VF ops helper introduced by commit a4c785e8162e ("ice: convert vf_ops .vsi_rebuild to .create_vsi") are used during an individual VF reset to re-create the VSI. This was done in order to ensure that the VSI gets properly reconfigured within the hardware. Th

Re: [Intel-wired-lan] [PATCH net-next v6 1/7] net: ethtool: pass ethtool_rxfh to get/set_rxfh ethtool ops

2023-11-28 Thread Keller, Jacob E
> -Original Message- > From: Zaki, Ahmed > Sent: Monday, November 27, 2023 6:15 AM > To: Jakub Kicinski > Cc: net...@vger.kernel.org; intel-wired-...@lists.osuosl.org; cor...@lwn.net; > Brandeburg, Jesse ; Nguyen, Anthony L > ; da...@davemloft.net; eduma...@google.com; > pab...@redhat.

Re: [Intel-wired-lan] The difference between linux kernel driver and FreeBSD's with Intel X533

2023-11-28 Thread Paul Menzel
[Cc: +, +regressi...@lists.linux.dev] #regzbot ^introduced: 565736048bd5f9888990569993c6b6bfdf6dcb6d Dear Ivan, Am 28.11.23 um 03:20 schrieb Ivan Pang: On Wed, Oct 18, 2023 at 09:50:35PM +0300, Skyler Mäntysaari wrote: On Tue, Oct 10, 2023, at 03:39, Skyler Mäntysaari wrote: On Tue, Oct 10,

[Intel-wired-lan] [tnguy-next-queue:40GbE] BUILD SUCCESS 95260816b489509c1f5b0141d0ae7b65be3c1d39

2023-11-28 Thread kernel test robot
nsimosci_defconfig gcc arc randconfig-001-20231128 gcc arc randconfig-002-20231128 gcc arm allnoconfig gcc arm aspeed_g5_defconfig gcc arm footbridge_defconfig

[Intel-wired-lan] [PATCH net-next v18 0/5] add-fwlog-v2-debugfs

2023-11-28 Thread Paul M Stillwell Jr
Firmware (FW) log support was added to the ice driver, but that version is no longer supported. There is a newer version of FW logging (v2) that adds more control knobs to get the exact data out of the FW for debugging. The interface for FW logging is debugfs. This was chosen based on discussions

[Intel-wired-lan] [PATCH net-next v18 5/5] ice: add documentation for FW logging

2023-11-28 Thread Paul M Stillwell Jr
Add documentation for FW logging in Documentation/networking/device_drivers/ethernet/intel/ice.rst Signed-off-by: Paul M Stillwell Jr --- v17->v18: - updated the documentation for clearing the log data to indicate that logging has to be disabled and that any value will clear the data v16->v17:

[Intel-wired-lan] [PATCH net-next v18 1/5] ice: remove FW logging code

2023-11-28 Thread Paul M Stillwell Jr
The FW logging code doesn't work because there is no way to set cq_ena or uart_ena so remove the code. This code is the original (v1) way of FW logging so it should be replaced with the v2 way. Signed-off-by: Paul M Stillwell Jr --- v17->v18: none v16->v17: none v15->v16: none v14->v15: none v13-

[Intel-wired-lan] [PATCH net-next v18 3/5] ice: enable FW logging

2023-11-28 Thread Paul M Stillwell Jr
Once users have configured the FW logging then allow them to enable it by writing to the 'fwlog/enable' file. The file accepts a boolean value (0 or 1) where 1 means enable FW logging and 0 means disable FW logging. # echo > /sys/kernel/debug/ice/\:18\:00.0/fwlog/enable Where is 0 or 1.

[Intel-wired-lan] [PATCH net-next v18 2/5] ice: configure FW logging

2023-11-28 Thread Paul M Stillwell Jr
Users want the ability to debug FW issues by retrieving the FW logs from the E8xx devices. Use debugfs to allow the user to configure the log level and number of messages for FW logging. If FW logging is supported on the E8xx then the file 'fwlog' will be created under the PCI device ID for the ic

[Intel-wired-lan] [PATCH net-next v18 4/5] ice: add ability to read FW log data and configure the amount of memory for log data

2023-11-28 Thread Paul M Stillwell Jr
Once logging is enabled the user should read the data from the 'data' file. The data is in the form of a binary blob that can be sent to Intel for decoding. To read the data use a command like: # cat /sys/kernel/debug/ice/\:18\:00.0/fwlog/data > log_data.bin If the user wants to clear the F

Re: [Intel-wired-lan] [PATCH net-next 0/5] igc: ethtool: Check VLAN TCI mask

2023-11-28 Thread Vinicius Costa Gomes
Kurt Kanzenbach writes: > Hi, > > currently it is possible to configure receive queue assignment using the VLAN > TCI field with arbitrary masks. However, the hardware only supports steering > either by full TCI or the priority (PCP) field. In case a wrong mask is given > by > the user the drive

Re: [Intel-wired-lan] [PATCH net-next v5 01/14] page_pool: make sure frag API fields don't span between cachelines

2023-11-28 Thread Yunsheng Lin
On 2023/11/27 22:08, Alexander Lobakin wrote: > From: Yunsheng Lin > Date: Sat, 25 Nov 2023 20:29:22 +0800 > >> On 2023/11/24 23:47, Alexander Lobakin wrote: >>> After commit 5027ec19f104 ("net: page_pool: split the page_pool_params >>> into fast and slow") that made &page_pool contain only "hot"

Re: [Intel-wired-lan] [PATCH net-next v5 03/14] page_pool: avoid calling no-op externals when possible

2023-11-28 Thread Yunsheng Lin
On 2023/11/27 22:32, Alexander Lobakin wrote: > > Chris, any thoughts on a global flag for skipping DMA syncs ladder? It seems there was one already in the past: https://lore.kernel.org/netdev/7c55a4d7-b4aa-25d4-1917-f6f355bd7...@arm.com/T/ > >> >> >>> +static inline bool page_pool_set_dma_ad

Re: [Intel-wired-lan] [PATCH net-next] ice: fix error code in ice_eswitch_attach()

2023-11-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 27 Nov 2023 15:59:17 +0300 you wrote: > Set the "err" variable on this error path. > > Fixes: fff292b47ac1 ("ice: add VF representors one by one") > Signed-off-by: Dan Carpenter > --- > drivers/net/ethernet

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: remove fake support of rx-frames-irq

2023-11-28 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jason > Xing > Sent: Monday, November 27, 2023 2:11 PM > To: Brandeburg, Jesse ; Nguyen, Anthony L > ; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com > Cc: net...@vger.kernel.org; intel-wired-...@l