On Tue, Nov 21, 2023 at 02:34:26PM +0200, Ilpo Järvinen wrote:
> Use FIELD_GET() to extract PCIe Negotiated Link Width field instead of
> custom masking and shifting.
>
> Signed-off-by: Ilpo Järvinen
> Reviewed-by: Jonathan Cameron
Thanks, nice to see FIELD_GET() used here.
Reviewed-by: Simon
On Tue, Nov 21, 2023 at 02:34:27PM +0200, Ilpo Järvinen wrote:
> e1000e has own copy of PCI Negotiated Link Width field defines. Use the
> ones from include/uapi/linux/pci_regs.h instead of the custom ones and
> remove the custom ones and convert to FIELD_GET().
>
> Suggested-by: Jonathan Cameron
On Tue, Nov 21, 2023 at 02:34:28PM +0200, Ilpo Järvinen wrote:
> Use pcie_capability_read_word() for reading LNKSTA and remove the
> custom define that matches to PCI_EXP_LNKSTA.
>
> As only single user for cap_offset remains, replace it with a call to
> pci_pcie_cap(). Instead of e1000_adapter, m
On 22/11/2023 1:33, Jakub Kicinski wrote:
> Last but not least please keep the field check you moved to the drivers
> in the core. Nobody will remember to check that other drivers added the
> check as well.
The wording of this sentence is a bit confusing, so I might be repeating
what you already s
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Petr Oros
> Sent: Tuesday, November 14, 2023 11:35 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Drewek, Wojciech ;
> net...@vger.kernel.org; Brandeburg, Jesse ;
> linux-ker...@vger.kernel.org; eduma...@google.com; Nguyen, Antho
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Michal Swiatkowski
> Sent: Monday, September 18, 2023 8:24 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Michal Swiatkowski
> ; Fijalkowski, Maciej
> ; Kitszel, Przemyslaw
>
> Subject: [Intel-wired-lan]
On Thu, 23 Nov 2023 15:33:04 +0200 Gal Pressman wrote:
> On 22/11/2023 1:33, Jakub Kicinski wrote:
> > Last but not least please keep the field check you moved to the drivers
> > in the core. Nobody will remember to check that other drivers added the
> > check as well.
>
> The wording of this se
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Keller, Jacob E
> Sent: Thursday, June 15, 2023 5:58 PM
> To: Michal Swiatkowski ; intel-wired-
> l...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Kitszel, Przemyslaw
>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 4/4]
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Simon Horman
> Sent: Friday, November 3, 2023 5:57 PM
> To: Michal Swiatkowski
> Cc: net...@vger.kernel.org; Cao, Yahui ;
> marcin.szy...@linux.intel.com; intel-wired-...@lists.osuosl.org; Kitszel,
> Przemyslaw ; Keller, Jacob E
