Re: [Intel-wired-lan] [PATCH iwl-next] ice: Re-enable timestamping correctly after reset

2023-11-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Wednesday, October 11, 2023 4:34 PM > To: intel-wired-...@lists.osuosl.org > Cc: Kolacinski, Karol ; Nguyen, Anthony L > ; Brandeburg, Jesse > Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Re-enable

Re: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: restore timestamp configuration after device reset

2023-11-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Saturday, November 4, 2023 5:17 AM > To: Nguyen, Anthony L > Cc: Keller, Jacob E ; net...@vger.kernel.org; Intel > Wired LAN ; Brandeburg, Jesse > > Subject: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: res

Re: [Intel-wired-lan] [PATCH iwl-net 2/3] ice: unify logic for programming PFINT_TSYN_MSK

2023-11-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Saturday, November 4, 2023 5:17 AM > To: Nguyen, Anthony L > Cc: Keller, Jacob E ; net...@vger.kernel.org; Intel > Wired LAN ; Brandeburg, Jesse > > Subject: [Intel-wired-lan] [PATCH iwl-net 2/3] ice: uni

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove ptp_tx ring parameter flag

2023-11-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Saturday, November 4, 2023 5:17 AM > To: Nguyen, Anthony L > Cc: Keller, Jacob E ; net...@vger.kernel.org; Intel > Wired LAN ; Brandeburg, Jesse > > Subject: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: rem

Re: [Intel-wired-lan] [PATCH iwl-next] ice: periodically kick Tx timestamp interrupt

2023-11-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Friday, November 3, 2023 10:00 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Brandeburg, Jesse ; > Staikov, Andrii ; Kolacinski, Karol > ; Nguyen, Anthony L ; > Keller, Jacob

[Intel-wired-lan] [PATCH iwl-next] ice: add CGU info to devlink info callback

2023-11-16 Thread Arkadiusz Kubalewski
If Clock Generation Unit is present on NIC board user shall know its details. Provide the devlink info callback with a new: - fixed type object (cgu.id) indicating hardware variant of onboard CGU, - running type object (fw.cgu) consisting of CGU id, config and firmware versions. These information s

Re: [Intel-wired-lan] [PATCH iwl-next 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-11-16 Thread Wojciech Drewek
On 15.11.2023 18:01, Ivan Vecera wrote: > > On 13. 11. 23 14:27, Wojciech Drewek wrote: >> >> On 13.11.2023 13:58, Ivan Vecera wrote: >>> Add two helpers i40e_(veb|vsi)_get_by_seid() to find corresponding >>> VEB or VSI by their SEID value and use these helpers to replace >>> existing open-coded

Re: [Intel-wired-lan] [PATCH net v2] i40e: Fix adding unsupported cloud filters

2023-11-16 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Ivan Vecera > Sent: Sunday, November 5, 2023 5:46 PM > To: net...@vger.kernel.org > Cc: Drewek, Wojciech ; intel-wired- > l...@lists.osuosl.org; Brandeburg, Jesse ; linux- > ker...@vger.kernel.org; Eric Dumazet ; Nguyen, > Anthony

Re: [Intel-wired-lan] [PATCH iwl-next 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-11-16 Thread Ivan Vecera
On 16. 11. 23 13:37, Wojciech Drewek wrote: On 15.11.2023 18:01, Ivan Vecera wrote: On 13. 11. 23 14:27, Wojciech Drewek wrote: On 13.11.2023 13:58, Ivan Vecera wrote: Add two helpers i40e_(veb|vsi)_get_by_seid() to find corresponding VEB or VSI by their SEID value and use these helpers t

Re: [Intel-wired-lan] [PATCH iwl-next 5/5] i40e: Remove VEB recursion

2023-11-16 Thread Wojciech Drewek
On 13.11.2023 13:58, Ivan Vecera wrote: > The VEB (virtual embedded switch) as a switch element can be > connected according datasheet though its uplink to: > - Physical port > - Port Virtualizer (not used directly by i40e driver but can > be present in MFP mode where the physical port is shar

Re: [Intel-wired-lan] [PATCH iwl-next 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-11-16 Thread Wojciech Drewek
On 16.11.2023 14:59, Ivan Vecera wrote: > > On 16. 11. 23 13:37, Wojciech Drewek wrote: >> >> >> On 15.11.2023 18:01, Ivan Vecera wrote: >>> >>> On 13. 11. 23 14:27, Wojciech Drewek wrote: On 13.11.2023 13:58, Ivan Vecera wrote: > Add two helpers i40e_(veb|vsi)_get_by_seid() to fin

[Intel-wired-lan] [PATCH iwl-next v2 0/5] i40e: Simplify VSI and VEB handling

2023-11-16 Thread Ivan Vecera
The series simplifies handling of VSIs and VEBs by introducing for-each iterating macros, 'find' helper functions. Also removes the VEB recursion because the VEBs cannot have sub-VEBs according datasheet and fixes the support for floating VEBs. The series content: Patch 1 - Uses existing helper fu

[Intel-wired-lan] [PATCH iwl-next v2 1/5] i40e: Use existing helper to find flow director VSI

2023-11-16 Thread Ivan Vecera
Use existing i40e_find_vsi_by_type() to find a VSI associated with flow director. Reviewed-by: Wojciech Drewek Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_main.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/i4

[Intel-wired-lan] [PATCH iwl-next v2 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs

2023-11-16 Thread Ivan Vecera
Introduce i40e_for_each_vsi() and i40e_for_each_veb() helper macros and use them to iterate relevant arrays. Replace pattern: for (i = 0; i < pf->num_alloc_vsi; i++) by: i40e_for_each_vsi(pf, i, vsi) and pattern: for (i = 0; i < I40E_MAX_VEB; i++) by i40e_for_each_veb(pf, i, veb) These macros al

[Intel-wired-lan] [PATCH iwl-next v2 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-11-16 Thread Ivan Vecera
Add two helpers i40e_(veb|vsi)_get_by_seid() to find corresponding VEB or VSI by their SEID value and use these helpers to replace existing open-coded loops. Reviewed-by: Wojciech Drewek Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 34 + .../net/etherne

[Intel-wired-lan] [PATCH iwl-next v2 4/5] i40e: Fix broken support for floating VEBs

2023-11-16 Thread Ivan Vecera
Although the i40e supports so-called floating VEB (VEB without an uplink connection to external network), this support is broken. This functionality is currently unused (except debugfs) but it will be used by subsequent series for switchdev mode slow-path. Fix this by following: 1) Handle correctl

[Intel-wired-lan] [PATCH iwl-next v2 5/5] i40e: Remove VEB recursion

2023-11-16 Thread Ivan Vecera
The VEB (virtual embedded switch) as a switch element can be connected according datasheet though its uplink to: - Physical port - Port Virtualizer (not used directly by i40e driver but can be present in MFP mode where the physical port is shared between PFs) - No uplink (aka floating VEB) But

Re: [Intel-wired-lan] [PATCH iwl-next 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-11-16 Thread Ivan Vecera
On 16. 11. 23 15:21, Wojciech Drewek wrote: Sounds good, my point was that I prefer to have "get" before "{veb|vsi}" OK, got it... Will repost v2 with this change + "too many also..." issue 😉 Thanks Btw. what about the last patch? Reviewed 🙂 Thanks, Wojciech! But I already submitted v2 of

Re: [Intel-wired-lan] [PATCH iwl-next v2 0/5] i40e: Simplify VSI and VEB handling

2023-11-16 Thread Ivan Vecera
On 16. 11. 23 15:41, Ivan Vecera wrote: The series simplifies handling of VSIs and VEBs by introducing for-each iterating macros, 'find' helper functions. Also removes the VEB recursion because the VEBs cannot have sub-VEBs according datasheet and fixes the support for floating VEBs. The series

[Intel-wired-lan] [PATCH iwl-next v3 0/5] i40e: Simplify VSI and VEB handling

2023-11-16 Thread Ivan Vecera
The series simplifies handling of VSIs and VEBs by introducing for-each iterating macros, 'find' helper functions. Also removes the VEB recursion because the VEBs cannot have sub-VEBs according datasheet and fixes the support for floating VEBs. The series content: Patch 1 - Uses existing helper fu

[Intel-wired-lan] [PATCH iwl-next v3 1/5] i40e: Use existing helper to find flow director VSI

2023-11-16 Thread Ivan Vecera
Use existing i40e_find_vsi_by_type() to find a VSI associated with flow director. Reviewed-by: Wojciech Drewek Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_main.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/i4

[Intel-wired-lan] [PATCH iwl-next v3 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-11-16 Thread Ivan Vecera
Add two helpers i40e_(veb|vsi)_get_by_seid() to find corresponding VEB or VSI by their SEID value and use these helpers to replace existing open-coded loops. Reviewed-by: Wojciech Drewek Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 34 + .../net/etherne

[Intel-wired-lan] [PATCH iwl-next v3 4/5] i40e: Fix broken support for floating VEBs

2023-11-16 Thread Ivan Vecera
Although the i40e supports so-called floating VEB (VEB without an uplink connection to external network), this support is broken. This functionality is currently unused (except debugfs) but it will be used by subsequent series for switchdev mode slow-path. Fix this by following: 1) Handle correctl

[Intel-wired-lan] [PATCH iwl-next v3 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs

2023-11-16 Thread Ivan Vecera
Introduce i40e_for_each_vsi() and i40e_for_each_veb() helper macros and use them to iterate relevant arrays. Replace pattern: for (i = 0; i < pf->num_alloc_vsi; i++) by: i40e_for_each_vsi(pf, i, vsi) and pattern: for (i = 0; i < I40E_MAX_VEB; i++) by i40e_for_each_veb(pf, i, veb) These macros al

[Intel-wired-lan] [PATCH iwl-next v3 5/5] i40e: Remove VEB recursion

2023-11-16 Thread Ivan Vecera
The VEB (virtual embedded switch) as a switch element can be connected according datasheet though its uplink to: - Physical port - Port Virtualizer (not used directly by i40e driver but can be present in MFP mode where the physical port is shared between PFs) - No uplink (aka floating VEB) But

Re: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking fields from iavf_adminq_ring

2023-11-16 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Friday, November 3, 2023 6:09 PM > To: ivecera > Cc: Drewek, Wojciech ; > net...@vger.kernel.org; Brandeburg, Jesse ; > linux-ker...@vger.kernel.org; Eric Dumazet ; > Nguyen, Anthony L ; intel-wired- > l...@l

Re: [Intel-wired-lan] sr-iov related bonding regression (two regressions in one report)

2023-11-16 Thread Bagas Sanjaya
On Wed, Nov 15, 2023 at 12:48:51PM -0800, Anil Choudhary wrote: > We are getting errorError subscribing to SWID 0x. > from following code > root@us-ash-r1-c2-m1:~/linux# grep -rn -e "subscribing to " . > grep: > ./debian/linux-image/lib/modules/6.6.1-vdx/kernel/drivers/net/ethernet/intel/ice/

[Intel-wired-lan] Counter spikes in /proc/net/dev for E810-CQDA2 interfaces (ice driver) on kernel >=6.2

2023-11-16 Thread Christian Rohmann
Dear sir or madam, we run multiple Intel E810-CQDA2 100G adapters (2x QSFP28) in our fleet of servers . The machines are running Ubuntu 22.04 LTS (Jammy), wieth Linux kernel 6.2.0-36-generic (Ubuntu HWE Kernel). This is the output from ethtool: ---cut --- # ethtool -i eth2 driver: ice versio

[Intel-wired-lan] Lots of rx_long_byte_count errors

2023-11-16 Thread Stephen Hemminger
I am using builtin NIC on my little Brix box and surprised to see lots of byte count errors. Network seems a little sluggish at times. Do use locally NFS mounted NAS for storing things like kernel trees. $ lspci | grep Ethernet 00:1f.6 Ethernet controller: Intel Corporation Ethernet Connection (13

[Intel-wired-lan] [PATCH iwl-net v2] ice: Fix VF Reset paths when interface in a failed over aggregate

2023-11-16 Thread Dave Ertman
There is an error when an interface has the following conditions: - PF is in an aggregate (bond) - PF has VFs created on it - bond is in a state where it is failed-over to the secondary interface - A VF reset is issued on one or more of those VFs The issue is generated by the originating PF trying

Re: [Intel-wired-lan] [PATCH iwl-next v1 1/2] ixgbe: Refactor overtemp event handling

2023-11-16 Thread Tony Nguyen
On 11/14/2023 1:10 AM, Jedrzej Jagielski wrote: Currently ixgbe driver is notified of overheating events via internal IXGBE_ERR_OVERTEMP erorr code. Change the approach to use is_overhaet variable which set when such event occurs. I'll likely have more questions/comments, but an initial questi

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-11-16 Thread Zhang, Xuejun
Hello Jiri & Jakub, Thanks for looking into our last patch with devlink API. Really appreciate your candid review. Following your suggestion, we have looked into 3 tc offload options to support queue rate limiting #1 mq + matchall + police #2 mq + tbf #3 htb all 3 tc offload options requ