[Intel-wired-lan] [PATCH iwl-next] ice: periodically kick Tx timestamp interrupt

2023-11-03 Thread Karol Kolacinski
From: Jacob Keller The E822 hardware for Tx timestamping keeps track of how many outstanding timestamps are still in the PHY memory block. It will not generate a new interrupt to the MAC until all of the timestamps in the region have been read. If somehow all the available data is not read, but

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: change vfs.num_msix_per to vf->num_msix

2023-11-03 Thread Simon Horman
On Tue, Oct 24, 2023 at 04:20:10PM +0200, Michal Swiatkowski wrote: > vfs::num_msix_per should be only used as default value for > vf->num_msix. For other use cases vf->num_msix should be used, as VF can > have different MSI-X amount values. > > Fix incorrect register index calculation. vfs::num_m

Re: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking fields from iavf_adminq_ring

2023-11-03 Thread Simon Horman
On Thu, Oct 26, 2023 at 10:39:32AM +0200, Ivan Vecera wrote: > Fields 'head', 'tail', 'len', 'bah' and 'bal' in iavf_adminq_ring > are used to store register offsets. These offsets are initialized > and remains constant so there is no need to store them in the > iavf_adminq_ring structure. > > Rem

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Remove AQ register definitions for VF types

2023-11-03 Thread Simon Horman
On Thu, Oct 26, 2023 at 10:38:22AM +0200, Ivan Vecera wrote: > The i40e driver does not handle its VF device types so there > is no need to keep AdminQ register definitions for such > device types. Remove them. > > Signed-off-by: Ivan Vecera Thanks, another nice cleanup. Reviewed-by: Simon Horm

[Intel-wired-lan] [PATCH net] i40e: Fix adding unsupported cloud filters

2023-11-03 Thread Ivan Vecera
If a VF tries to add unsupported cloud filter through virchnl then i40e_add_del_cloud_filter(_big_buf) returns -ENOTSUPP but this error code is stored in 'ret' instead of 'aq_ret' that is used as error code sent back to VF. In this scenario where one of the mentioned functions fails the value of 'a

[Intel-wired-lan] [PATCH iwl-net 0/3] ice: restore timestamp config after reset

2023-11-03 Thread Jacob Keller
We recently discovered during internal validation that the ice driver has not been properly restoring Tx timestamp configuration after a device reset, which resulted in application failures after a device reset. After some digging, it turned out this problem is two-fold. Since the introduction of

[Intel-wired-lan] [PATCH iwl-net 3/3] ice: restore timestamp configuration after device reset

2023-11-03 Thread Jacob Keller
The driver calls ice_ptp_cfg_timestamp() during ice_ptp_prepare_for_reset() to disable timestamping while the device is resetting. This operation destroys the user requested configuration. While the driver does call ice_ptp_cfg_timestamp in ice_rebuild() to restore some hardware settings after a re

[Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove ptp_tx ring parameter flag

2023-11-03 Thread Jacob Keller
Before performing a Tx timestamp in ice_stamp(), the driver checks a ptp_tx ring variable to see if timestamping is enabled on that ring. This value is set for all rings whenever userspace configures Tx timestamping. Ostensibly this was done to avoid wasting cycles checking other fields when times

[Intel-wired-lan] [PATCH iwl-net 2/3] ice: unify logic for programming PFINT_TSYN_MSK

2023-11-03 Thread Jacob Keller
Commit d938a8cca88a ("ice: Auxbus devices & driver for E822 TS") modified how Tx timestamps are handled for E822 devices. On these devices, only the clock owner handles reading the Tx timestamp data from firmware. To do this, the PFINT_TSYN_MSK register is modified from the default value to one whi