Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Kubalewski, Arkadiusz
>From: Vadim Fedorenko >Sent: Wednesday, September 27, 2023 8:09 PM > >On 27/09/2023 10:24, Arkadiusz Kubalewski wrote: >> Add callback op (get) for pin-dpll phase-offset measurment. >> Add callback ops (get/set) for pin signal phase adjustment. >> Add min and max phase adjustment values to pin pr

[Intel-wired-lan] [PATCH net-next v3 0/2] ethtool: Add link mode maps for forced speeds

2023-10-02 Thread Pawel Chmielewski
The following patch set was initially a part of [1]. As the purpose of the original series was to add the support of the new hardware to the intel ice driver, the refactoring of advertised link modes mapping was extracted to a new set. The patch set adds a common mechanism for mapping Ethtool force

[Intel-wired-lan] [PATCH net-next v3 1/2] ethtool: Add forced speed to supported link modes maps

2023-10-02 Thread Pawel Chmielewski
From: Paul Greenwalt The need to map Ethtool forced speeds to Ethtool supported link modes is common among drivers. To support this, add a common structure for forced speed maps and a function to init them. This is solution was originally introduced in commit 1d4e4ecccb11 ("qede: populate suppor

[Intel-wired-lan] [PATCH net-next v3 2/2] ice: Refactor finding advertised link speed

2023-10-02 Thread Pawel Chmielewski
Refactor ice_get_link_ksettings to using forced speed to link modes mapping. Suggested-by : Alexander Lobakin Reviewed-by: Jacob Keller Reviewed-by: Przemek Kitszel Signed-off-by: Paul Greenwalt Signed-off-by: Pawel Chmielewski --- drivers/net/ethernet/intel/ice/ice.h | 1 + driver

Re: [Intel-wired-lan] [PATCH net-next 2/4] dpll: spec: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Jiri Pirko
Wed, Sep 27, 2023 at 11:24:33AM CEST, arkadiusz.kubalew...@intel.com wrote: >Add new pin's attributes to dpll netlink spec: >- phase-offset - measured difference between phase of signals on pin > and dpll >- phase-adjust - adjustable value of pin's signal phase >- phase-adjust-min / phase-adjust-m

Re: [Intel-wired-lan] [PATCH net-next 1/4] dpll: docs: add support for pin signal phase offset/adjust

2023-10-02 Thread Jiri Pirko
Wed, Sep 27, 2023 at 11:24:32AM CEST, arkadiusz.kubalew...@intel.com wrote: >Add dpll documentation on new pin's attributes: >- phase-offset - measured difference between phase of signals on pin > and dpll >- phase-adjust - adjustable value of pin's signal phase >- phase-adjust-min / phase-adjust-

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Jiri Pirko
Mon, Oct 02, 2023 at 04:32:30PM CEST, arkadiusz.kubalew...@intel.com wrote: >>From: Vadim Fedorenko >>Sent: Wednesday, September 27, 2023 8:09 PM >> >>On 27/09/2023 10:24, Arkadiusz Kubalewski wrote: >>> Add callback op (get) for pin-dpll phase-offset measurment. >>> Add callback ops (get/set) for

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Vadim Fedorenko
On 02/10/2023 16:04, Jiri Pirko wrote: Mon, Oct 02, 2023 at 04:32:30PM CEST, arkadiusz.kubalew...@intel.com wrote: From: Vadim Fedorenko Sent: Wednesday, September 27, 2023 8:09 PM On 27/09/2023 10:24, Arkadiusz Kubalewski wrote: Add callback op (get) for pin-dpll phase-offset measurment. Add

Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: reset first in crash dump kernels

2023-10-02 Thread Jesse Brandeburg
On 9/19/2023 10:18 PM, Paul Menzel wrote: > Dear Jesse, > > > Thank you for your patch. > > Am 19.09.23 um 23:29 schrieb Jesse Brandeburg: >> When booting into the crash dump kernels there are cases where upon >> enabling the device, the system under test will panic or machine check. >> >> One s

[Intel-wired-lan] [PATCH iwl-net v2] ice: reset first in crash dump kernels

2023-10-02 Thread Jesse Brandeburg
When the system boots into the crash dump kernel after a panic, the ice networking device may still have pending transactions that can cause errors or machine checks when the device is re-enabled. This can prevent the crash dump kernel from loading the driver or collecting the crash data. To avoid

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Kubalewski, Arkadiusz
>From: Jiri Pirko >Sent: Monday, October 2, 2023 5:04 PM > >Mon, Oct 02, 2023 at 04:32:30PM CEST, arkadiusz.kubalew...@intel.com wrote: >>>From: Vadim Fedorenko >>>Sent: Wednesday, September 27, 2023 8:09 PM >>> >>>On 27/09/2023 10:24, Arkadiusz Kubalewski wrote: Add callback op (get) for pi

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Kubalewski, Arkadiusz
>From: Intel-wired-lan On Behalf Of >Vadim Fedorenko >Sent: Monday, October 2, 2023 5:09 PM > >On 02/10/2023 16:04, Jiri Pirko wrote: >> Mon, Oct 02, 2023 at 04:32:30PM CEST, arkadiusz.kubalew...@intel.com >> wrote: From: Vadim Fedorenko Sent: Wednesday, September 27, 2023 8:09 PM

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: reset first in crash dump kernels

2023-10-02 Thread Jay Vosburgh
Jesse Brandeburg wrote: >When the system boots into the crash dump kernel after a panic, the ice >networking device may still have pending transactions that can cause errors >or machine checks when the device is re-enabled. This can prevent the crash >dump kernel from loading the driver or collec

Re: [Intel-wired-lan] [PATCH iwl-next 3/4] ice: make ice_get_pf_c827_idx static

2023-10-02 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Wednesday, September 20, 2023 5:05 AM > To: Intel Wired LAN > Cc: Keller, Jacob E ; Nguyen, Anthony L > > Subject: [Intel-wired-lan] [PATCH iwl-next 3/4] ice: make ice_get_pf_c827_idx > static > > The ice

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 9e8622c29420f8067533e6d2c83c898da168103d

2023-10-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue branch HEAD: 9e8622c29420f8067533e6d2c83c898da168103d ice: block default rule setting on LAG interface elapsed time: 737m configs tested: 107 configs skipped: 2 The following configs have been built suc

[Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable

2023-10-02 Thread Jesse Brandeburg
Since the introduction of the ice driver the code has been double-shifting the RSS enabling field, because the define already has shifts in it and can't have the regular pattern of "a << shiftval & mask" applied. Most places in the code got it right, but one line was still wrong. Fix this one loca

[Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Fix ambiguity in the ethtool advertising

2023-10-02 Thread Sasha Neftin
The 'ethtool_convert_link_mode_to_legacy_u32' method does not allow us to advertise 2500M speed support and TP (twisted pair) properly. Convert to 'ethtool_link_ksettings_test_link_mode' to advertise supported speed and eliminate ambiguity. Fixes: 8c5ad0dae93c ("igc: Add ethtool support") Suggeste

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: reset first in crash dump kernels

2023-10-02 Thread Jesse Brandeburg
On 10/2/2023 4:49 PM, Jay Vosburgh wrote: > Jesse Brandeburg wrote: > >> When the system boots into the crash dump kernel after a panic, the ice >> networking device may still have pending transactions that can cause errors >> or machine checks when the device is re-enabled. This can prevent the

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Jiri Pirko
Tue, Oct 03, 2023 at 01:10:39AM CEST, arkadiusz.kubalew...@intel.com wrote: >>From: Intel-wired-lan On Behalf Of >>Vadim Fedorenko >>Sent: Monday, October 2, 2023 5:09 PM >> >>On 02/10/2023 16:04, Jiri Pirko wrote: >>> Mon, Oct 02, 2023 at 04:32:30PM CEST, arkadiusz.kubalew...@intel.com >>> wrote:

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-02 Thread Jiri Pirko
Tue, Oct 03, 2023 at 01:03:00AM CEST, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Monday, October 2, 2023 5:04 PM >> >>Mon, Oct 02, 2023 at 04:32:30PM CEST, arkadiusz.kubalew...@intel.com wrote: From: Vadim Fedorenko Sent: Wednesday, September 27, 2023 8:09 PM >>