Re: [Intel-wired-lan] [PATCH net-next 7/9] i40e: Move memory allocation structures to i40e_alloc.h

2023-09-27 Thread Ivan Vecera
On 26. 09. 23 21:57, Przemek Kitszel wrote: On 9/26/23 20:27, Ivan Vecera wrote: Structures i40e_dma_mem & i40e_virt_mem are defined i40e_osdep.h while memory allocation functions that use them are declared in i40e_alloc.h Move them to i40e_alloc.h and remove this header file dependency on i40

[Intel-wired-lan] [PATCH net-next v2 0/9] i40e: House-keeping and clean-up

2023-09-27 Thread Ivan Vecera
The series makes some house-keeping tasks on i40e driver: Patch 1: Removes unnecessary back pointer from i40e_hw Patch 2: Moves I40E_MASK macro to i40e_register.h where is used Patch 3: Refactors I40E_MDIO_CLAUSE* to use the common macro Patch 4: Add header dependencies to Patch 5: Simplifies mem

[Intel-wired-lan] [PATCH net-next v2 1/9] i40e: Remove back pointer from i40e_hw structure

2023-09-27 Thread Ivan Vecera
The .back field placed in i40e_hw is used to get pointer to i40e_pf instance but it is not necessary as the i40e_hw is a part of i40e_pf and containerof macro can be used to obtain the pointer to i40e_pf. Remove .back field from i40e_hw structure, introduce i40e_hw_to_pf() and i40e_hw_to_dev() help

[Intel-wired-lan] [PATCH net-next v2 2/9] i40e: Move I40E_MASK macro to i40e_register.h

2023-09-27 Thread Ivan Vecera
The macro is practically used only in i40e_register.h header file except few I40E_MDIO_CLAUSE* macros that are defined in i40e_type.h Move I40E_MASK macro to i40e_register.h header, I40E_MDIO_CLAUSE* macros are refactored in subsequent patch. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/i

[Intel-wired-lan] [PATCH net-next v2 3/9] i40e: Refactor I40E_MDIO_CLAUSE* macros

2023-09-27 Thread Ivan Vecera
The macros I40E_MDIO_CLAUSE22* and I40E_MDIO_CLAUSE45* are using I40E_MASK together with the same values I40E_GLGEN_MSCA_STCODE_SHIFT and I40E_GLGEN_MSCA_OPCODE_SHIFT to define masks. Introduce I40E_GLGEN_MSCA_OPCODE_MASK and I40E_GLGEN_MSCA_STCODE_MASK for both shifts in i40e_register.h and use th

[Intel-wired-lan] [PATCH net-next v2 5/9] i40e: Simplify memory allocation functions

2023-09-27 Thread Ivan Vecera
Enum i40e_memory_type enum is unused in i40e_allocate_dma_mem() thus can be safely removed. Useless macros in i40e_alloc.h can be removed as well. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 4 drivers/net/ethernet/intel/i40e/i40e_alloc.h | 14 --

[Intel-wired-lan] [PATCH net-next v2 4/9] virtchnl: Add header dependencies

2023-09-27 Thread Ivan Vecera
The uses BIT, struct_size and ETH_ALEN macros but does not include appropriate header files that defines them. Add these dependencies so this header file can be included anywhere. Signed-off-by: Ivan Vecera --- include/linux/avf/virtchnl.h | 4 1 file changed, 4 insertions(+) diff --git a

[Intel-wired-lan] [PATCH net-next v2 6/9] i40e: Move memory allocation structures to i40e_alloc.h

2023-09-27 Thread Ivan Vecera
Structures i40e_dma_mem & i40e_virt_mem are defined i40e_osdep.h while memory allocation functions that use them are declared in i40e_alloc.h Move them there. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_adminq.h | 1 + drivers/net/ethernet/intel/i40e/i40e_alloc.h | 14 +

[Intel-wired-lan] [PATCH net-next v2 7/9] i40e: Split i40e_osdep.h

2023-09-27 Thread Ivan Vecera
Header i40e_osdep.h contains only IO primitives and couple of debug printing macros. Split this header file to i40e_io.h and i40e_debug.h and move i40e_debug_mask enum to i40e_debug.h Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_adminq.h | 2 +- drivers/net/ethernet/intel

[Intel-wired-lan] [PATCH net-next v2 8/9] i40e: Remove circular header dependencies and fix headers

2023-09-27 Thread Ivan Vecera
Similarly as for ice driver [1] there are also circular header dependencies in i40e driver: i40e.h -> i40e_virtchnl_pf.h -> i40e.h Another issue is that i40e header files does not contain their own depenencies on other header files (both private and standard) so their inclusion in .c file require

[Intel-wired-lan] [PATCH net-next v2 9/9] i40e: Move DDP specific macros and structures to i40e_ddp.c

2023-09-27 Thread Ivan Vecera
Move several DDP related macros and structures from i40e.h header to i40e_ddp.c where are privately used. Make static i40e_ddp_load() function that is also used only in i40e_ddp and move declaration of i40e_ddp_flash() used by i40e_ethtool.c to i40e_prototype.h Signed-off-by: Ivan Vecera --- dri

Re: [Intel-wired-lan] [PATCH net-next v2 0/9] i40e: House-keeping and clean-up

2023-09-27 Thread Przemek Kitszel
On 9/27/23 10:31, Ivan Vecera wrote: The series makes some house-keeping tasks on i40e driver: Patch 1: Removes unnecessary back pointer from i40e_hw Patch 2: Moves I40E_MASK macro to i40e_register.h where is used Patch 3: Refactors I40E_MDIO_CLAUSE* to use the common macro Patch 4: Add header d

[Intel-wired-lan] [PATCH net-next 0/4] dpll: add phase-offset and phase-adjust

2023-09-27 Thread Arkadiusz Kubalewski
Improve monitoring and control over dpll devices. Allow user to receive measurement of phase difference between signals on pin and dpll (phase-offset). Allow user to receive and control adjustable value of pin's signal phase (phase-adjust). Arkadiusz Kubalewski (4): dpll: docs: add support for p

[Intel-wired-lan] [PATCH net-next 1/4] dpll: docs: add support for pin signal phase offset/adjust

2023-09-27 Thread Arkadiusz Kubalewski
Add dpll documentation on new pin's attributes: - phase-offset - measured difference between phase of signals on pin and dpll - phase-adjust - adjustable value of pin's signal phase - phase-adjust-min / phase-adjust-max - values for determining limits for phase-adjust Signed-off-by: Arkadiusz

[Intel-wired-lan] [PATCH net-next 2/4] dpll: spec: add support for pin-dpll signal phase offset/adjust

2023-09-27 Thread Arkadiusz Kubalewski
Add new pin's attributes to dpll netlink spec: - phase-offset - measured difference between phase of signals on pin and dpll - phase-adjust - adjustable value of pin's signal phase - phase-adjust-min / phase-adjust-max - values for determining limits for phase-adjust Signed-off-by: Arkadiusz K

[Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-09-27 Thread Arkadiusz Kubalewski
Add callback op (get) for pin-dpll phase-offset measurment. Add callback ops (get/set) for pin signal phase adjustment. Add min and max phase adjustment values to pin proprties. Invoke get callbacks when filling up the pin details to provide user with phase related attribute values. Invoke phase-ad

[Intel-wired-lan] [PATCH net-next 4/4] ice: dpll: implement phase related callbacks

2023-09-27 Thread Arkadiusz Kubalewski
Implement callback op related to phase-offset measurement for input pins to provide user with measured value. Implement callback ops related to phase-adjust get and set to allow the user with control over adjustable value of phase on pin's signal. Fill pin-adjust(-min/-max) limit values on pin-prop

Re: [Intel-wired-lan] [PATCH net-next 4/4] ice: dpll: implement phase related callbacks

2023-09-27 Thread kernel test robot
Hi Arkadiusz, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Arkadiusz-Kubalewski/dpll-docs-add-support-for-pin-signal-phase-offset-adjust/20230927-172843 base: net-next/main patch link

[Intel-wired-lan] [PATCH iwl-next v1] ice: read internal temperature sensor

2023-09-27 Thread Konrad Knitter
Since 4.30 firmware exposes internal thermal sensor reading via admin queue commands. Expose those readouts via hwmon API when supported. Driver provides current reading from HW as well as device specific thresholds for thermal alarm (Warning, Critical, Fatal) events. $ sensors Output ==

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: read internal temperature sensor

2023-09-27 Thread Andrew Lunn
On Wed, Sep 27, 2023 at 03:38:57PM +0200, Konrad Knitter wrote: > Since 4.30 firmware exposes internal thermal sensor reading via admin > queue commands. Expose those readouts via hwmon API when supported. > > Driver provides current reading from HW as well as device specific > thresholds for ther

[Intel-wired-lan] [PATCH iwl-next, v1] ice: Fix VF-VF filter rules in switchdev mode

2023-09-27 Thread Aniruddha Paul
Any packet leaving VSI i.e VF's VSI is considered as egress traffic by HW, thus failing to match the added rule. Mark the direction for redirect rules as below: 1. VF-VF - Egress 2. Uplink-VF - Ingress 3. VF-Uplink - Egress 4. Link_Partner-Uplink - Ingress 5. Link_Partner-VF - Ingress Fixes: 0960

[Intel-wired-lan] [ANN] Upstreaming Process Change - Mandatory "reviewed-by" Tag

2023-09-27 Thread Rucinska, Monika
Dear e1000 and IWL contributors, We are implementing a crucial process change to enhance the quality and efficiency of our upstream development and upstreaming efforts. Effective immediately, every INTEL/NCIS patch posted to IWL must have at least one "Reviewed-by" tag, those are provided during e

[Intel-wired-lan] [linux-next:master] BUILD REGRESSION 18030226a48de1fbfabf4ae16aaa2695a484254f

2023-09-27 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 18030226a48de1fbfabf4ae16aaa2695a484254f Add linux-next specific files for 20230927 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202308282000.2xnh0k6d-...@intel.com https

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-09-27 Thread Vadim Fedorenko
On 27/09/2023 10:24, Arkadiusz Kubalewski wrote: Add callback op (get) for pin-dpll phase-offset measurment. Add callback ops (get/set) for pin signal phase adjustment. Add min and max phase adjustment values to pin proprties. Invoke get callbacks when filling up the pin details to provide user w

Re: [Intel-wired-lan] [PATCH net-next v5 0/7] introduce DEFINE_FLEX() macro

2023-09-27 Thread Tony Nguyen
On 9/19/2023 4:10 AM, Przemek Kitszel wrote: On 9/12/23 18:16, Kees Cook wrote: On Tue, Sep 12, 2023 at 07:59:30AM -0400, Przemek Kitszel wrote: Add DEFINE_FLEX() macro, that helps on-stack allocation of structures with trailing flex array member. Expose __struct_size() macro which reads size

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 85b90747fa80e6b5daae9fc82240dbfff869ef1e

2023-09-27 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230927 gcc arc randconfig-001-20230928 gcc arm

Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: Extend rx_errors calculation

2023-09-27 Thread Arland, ArpanaX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jedrzej Jagielski > Sent: Tuesday, September 12, 2023 3:00 PM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; Jagielski, Jedrzej > > Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: Extend rx_errors > cal