Re: [Intel-wired-lan] [PATCH net-next] iavf: Avoid a memory allocation in iavf_print_link_message()

2023-09-25 Thread Przemek Kitszel
On 9/23/23 14:17, Christophe JAILLET wrote: IAVF_MAX_SPEED_STRLEN is only 13 and 'speed' is allocated and freed within iavf_print_link_message(). 'speed' is only used with some snprintf() and netdev_info() calls. So there is no real use to kzalloc()/free() it. Use the stack instead. This saves

Re: [Intel-wired-lan] [PATCH iwl-next] idpf: set scheduling mode for completion queue

2023-09-25 Thread Przemek Kitszel
On 9/22/23 18:16, Michal Kubiak wrote: The HW must be programmed differently for queue-based scheduling mode. To program the completion queue context correctly, the control plane must know the scheduling mode not only for the Tx queue, but also for the completion queue. Unfortunately, currently t

Re: [Intel-wired-lan] [PATCH] i40e: fix the wrong PTP frequency calculation

2023-09-25 Thread Yajun Deng
On 2023/6/28 04:20, Jacob Keller wrote: On 6/26/2023 7:26 PM, Yajun Deng wrote: The new adjustment should be based on the base frequency, not the I40E_PTP_40GB_INCVAL in i40e_ptp_adjfine(). This issue was introduced in commit 3626a690b717 ("i40e: use mul_u64_u64_div_u64 for PTP frequency cal

[Intel-wired-lan] [PATCH] ice: require PTP clock for building

2023-09-25 Thread Arnd Bergmann
From: Arnd Bergmann A previous fix added PTP as an optional dependency, which was correct as of commit 87758511075ec ("igc: fix build errors for PTP"), but this has recently changed with the PTP code getting more deeply integrated into the ICE driver. Trying to build ICE when PTP is disabled res

[Intel-wired-lan] [PATCH] idpf: fix building without IPv4

2023-09-25 Thread Arnd Bergmann
From: Arnd Bergmann The newly added offload code fails to link when IPv4 networking is disabled: arm-linux-gnueabi-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: in function `idpf_vport_splitq_napi_poll': idpf_txrx.c:(.text+0x7a20): undefined reference to `tcp_gro_complete' Add complile-time

Re: [Intel-wired-lan] [PATCH] ice: require PTP clock for building

2023-09-25 Thread Tony Nguyen
On 9/25/2023 8:55 AM, Arnd Bergmann wrote: From: Arnd Bergmann A previous fix added PTP as an optional dependency, which was correct as of commit 87758511075ec ("igc: fix build errors for PTP"), but this has recently changed with the PTP code getting more deeply integrated into the ICE driver.

Re: [Intel-wired-lan] [PATCH] idpf: fix building without IPv4

2023-09-25 Thread Tony Nguyen
On 9/25/2023 8:58 AM, Arnd Bergmann wrote: From: Arnd Bergmann The newly added offload code fails to link when IPv4 networking is disabled: arm-linux-gnueabi-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: in function `idpf_vport_splitq_napi_poll': idpf_txrx.c:(.text+0x7a20): undefined ref

Re: [Intel-wired-lan] [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings"

2023-09-25 Thread Andrew Lunn
> However, to reset the link with new 'advertising' bits, code takes this path: > > [  255.073847]  igc_setup_copper_link+0x73c/0x750 > [  255.073851]  igc_setup_link+0x4a/0x170 > [  255.073852]  igc_init_hw_base+0x98/0x100 > [  255.073855]  igc_reset+0x69/0xe0 > [  255.073857]  igc_down+0x22b/0x2

Re: [Intel-wired-lan] [PATCH] ice: require PTP clock for building

2023-09-25 Thread Keller, Jacob E
> -Original Message- > From: Arnd Bergmann > Sent: Monday, September 25, 2023 8:55 AM > To: Brandeburg, Jesse ; Nguyen, Anthony L > > Cc: Arnd Bergmann ; David S. Miller ; > Eric Dumazet ; Jakub Kicinski ; Paolo > Abeni ; Kubalewski, Arkadiusz > ; Michalik, Michal > ; Jiri Pirko ; Kell

Re: [Intel-wired-lan] [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings"

2023-09-25 Thread Prasad Koya
Hi, Here is the ethtool output before and after changing the speed with the commit 9ac3fc2f42e5ffa1e927dcbffb71b15fa81459e2: -bash-4.2# ethtool ma1 Settings for ma1: Supported ports: [ TP ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/

Re: [Intel-wired-lan] [PATCH] i40e: fix the wrong PTP frequency calculation

2023-09-25 Thread Tony Nguyen
On 9/25/2023 12:55 AM, Yajun Deng wrote: On 2023/6/28 04:20, Jacob Keller wrote: On 6/26/2023 7:26 PM, Yajun Deng wrote: The new adjustment should be based on the base frequency, not the I40E_PTP_40GB_INCVAL in i40e_ptp_adjfine(). This issue was introduced in commit 3626a690b717 ("i40e: use

[Intel-wired-lan] [PATCH iwl-next v6] ice: Add support for switch recipe reusing feature

2023-09-25 Thread Steven Zou
If E810 firmware supports the corresponding functionality, the driver allows PFs to subscribe the same switch recipes. Then when the PF is done with a switch recipes, the PF can ask firmware to free that switch recipe. When users configure a rule to PFn into E810 switch component, if there is no e

Re: [Intel-wired-lan] [PATCH] i40e: fix the wrong PTP frequency calculation

2023-09-25 Thread Greg KH
On Tue, Sep 26, 2023 at 09:54:29AM +0800, Yajun Deng wrote: > > On 2023/9/26 07:59, Tony Nguyen wrote: > > On 9/25/2023 12:55 AM, Yajun Deng wrote: > > > > > > On 2023/6/28 04:20, Jacob Keller wrote: > > > > > > > > On 6/26/2023 7:26 PM, Yajun Deng wrote: > > > > > The new adjustment should be b

Re: [Intel-wired-lan] [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings"

2023-09-25 Thread Neftin, Sasha
On 25/09/2023 22:40, Prasad Koya wrote: Hi, Here is the ethtool output before and after changing the speed with the commit 9ac3fc2f42e5ffa1e927dcbffb71b15fa81459e2: -bash-4.2# ethtool ma1 Settings for ma1:         Supported ports: [ TP ]         Supported link modes:   10baseT/Half 10baseT/

Re: [Intel-wired-lan] [PATCH] ice: require PTP clock for building

2023-09-25 Thread Arnd Bergmann
On Mon, Sep 25, 2023, at 23:49, Keller, Jacob E wrote: >> From: Arnd Bergmann >> >> I tried rearranging the code to allow building it again, but this was getting >> too complicated for an outsider, so just enforce the dependency to fix >> randconfig >> builds again, until someone wants to clean