Re: [Intel-wired-lan] [PATCH iwl-net v5] igc: Expose tx-usecs coalesce setting to user

2023-09-20 Thread naamax.meir
On 9/8/2023 11:17, Muhammad Husaini Zulkifli wrote: When users attempt to obtain the coalesce setting using the ethtool command, current code always returns 0 for tx-usecs. This is because I225/6 always uses a queue pair setting, hence tx_coalesce_usecs does not return a value during the igc_etht

[Intel-wired-lan] [tnguy-next-queue:main] BUILD SUCCESS WITH WARNING 5bed8d585aa1db1651745173a66e32df82a5cb05

2023-09-20 Thread kernel test robot
e.h:warning:array-subscript-is-outside-array-bounds-of-__u8-aka-unsigned-char |-- nios2-randconfig-002-20230920 | `-- include-asm-generic-rwonce.h:warning:array-subscript-is-outside-array-bounds-of-__u8-aka-unsigned-char `-- openrisc-defconfig `-- include-asm-generic-rwonce.h:warning:array-subscr

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 09d70717bd204c6124fb7297ae538e3365633d86

2023-09-20 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230920 gcc arm allmodconfig gcc arm

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 2fcb79a1962e88ff10552384fb8164fde815ccd3

2023-09-20 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230920 gcc arm allmodconfig gcc arm

Re: [Intel-wired-lan] [PATCH iwl-next 2/4] ice: move netlist check functions to ice_common.c

2023-09-20 Thread Przemek Kitszel
On 9/20/23 01:34, Jacob Keller wrote: The ice_ptp_hw.c file has a few functions which check for whether the device netlist has a node indicating hardware support for certain features. These checks don't really make sense to be in ice_ptp_hw.c. In addition, their names could be confusing as they j

Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: don't stop netdev tx queues when setting up XSK socket

2023-09-20 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Maziarz, Kamil >Sent: Tuesday, September 12, 2023 3:53 PM >To: intel-wired-...@lists.osuosl.org >Cc: Maziarz, Kamil >Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: don't stop netdev tx queues >when setting up XSK socket > >Av

[Intel-wired-lan] [PATCH net] ice: always add legacy 32byte RXDID in supported_rxdids

2023-09-20 Thread Michal Schmidt
When the PF and VF drivers both support flexible rx descriptors and have negotiated the VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC capability, the VF driver queries the PF for the list of supported descriptor formats (VIRTCHNL_OP_GET_SUPPORTED_RXDIDS). The PF driver is supposed to set the supported_rxdids bi

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: Fix call trace when rebuild fails

2023-09-20 Thread Palczewski, Mateusz
>On 9/8/2023 1:59 AM, Mateusz Palczewski wrote: >> In case rebuild fails trying to restart or unload a driver lead to >> call trace. >> >> [ 128.876458] BUG: unable to handle kernel NULL pointer dereference at >> >> [ 128.884417] PGD 33510d067 P4D 0 >> [ 128.

Re: [Intel-wired-lan] [PATCH iwl-net] ice: block default rule setting on LAG interface

2023-09-20 Thread Simon Horman
On Fri, Sep 15, 2023 at 05:35:19PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > When one of the LAG interfaces is in switchdev mode, setting default rule > can't be done. > > The interface on which switchdev is running has ice_set_rx_mode() blocked > to avoid default rule adding (a

Re: [Intel-wired-lan] [PATCH net] ice: always add legacy 32byte RXDID in supported_rxdids

2023-09-20 Thread Przemek Kitszel
On 9/20/23 13:54, Michal Schmidt wrote: When the PF and VF drivers both support flexible rx descriptors and have negotiated the VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC capability, the VF driver queries the PF for the list of supported descriptor formats (VIRTCHNL_OP_GET_SUPPORTED_RXDIDS). The PF driver

[Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors

2023-09-20 Thread Alexander Lobakin
Recently, several link-time issues were spotted in the ethernet/intel/ folder thanks to Kbuild bots and linux-next. The fixes are pretty straightforward, just some stubs and CONFIG_* guards, so resolve all of them in one shot and unbreak randconfig builds. Alexander Lobakin (3): ice: fix undefin

[Intel-wired-lan] [PATCH net-next 1/3] ice: fix undefined references to ice_is_*() when !CONFIG_PTP_1588_CLOCK

2023-09-20 Thread Alexander Lobakin
Starting the cited commit, ice_lib.c unconditionally refers to three functions compiled only when CONFIG_PTP_1588_CLOCK is set (as they're located in ice_ptp_hw.c): ERROR: modpost: "ice_is_clock_mux_present_e810t" [drivers/net/ethernet/intel/ice/ice.ko] undefined! ERROR: modpost: "ice_is_phy_rclk_

[Intel-wired-lan] [PATCH net-next 2/3] ice: fix undefined references from DPLL code when !CONFIG_PTP_1588_CLOCK

2023-09-20 Thread Alexander Lobakin
DPLL code in ice unconditionally calls several PTP functions which are only built when CONFIG_PTP_1588_CLOCK is set. This throws a good bunch of link errors: ERROR: modpost: "ice_cgu_get_pin_name" [drivers/net/ethernet/intel/ice/ice.ko] undefined! ERROR: modpost: "ice_get_cgu_state" [drivers/net/e

[Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET

2023-09-20 Thread Alexander Lobakin
When CONFIG_INET is not set, tcp_gro_complete is not compiled, although the drivers using it may still be compiled (spotted by Randy): aarch64-linux-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: in function `idpf_rx_rsc.isra.0': drivers/net/ethernet/intel/idpf/idpf_txrx.c:2909:(.text+0x40cc): u

Re: [Intel-wired-lan] [PATCH iwl-next 2/4] ice: move netlist check functions to ice_common.c

2023-09-20 Thread Jacob Keller
On 9/20/2023 3:35 AM, Przemek Kitszel wrote: > On 9/20/23 01:34, Jacob Keller wrote: >> The ice_ptp_hw.c file has a few functions which check for whether the >> device netlist has a node indicating hardware support for certain features. >> These checks don't really make sense to be in ice_ptp_hw

Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET

2023-09-20 Thread Randy Dunlap
On 9/20/23 11:07, Alexander Lobakin wrote: > When CONFIG_INET is not set, tcp_gro_complete is not compiled, although > the drivers using it may still be compiled (spotted by Randy): > > aarch64-linux-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: > in function `idpf_rx_rsc.isra.0': > drivers/

Re: [Intel-wired-lan] [PATCH net] ice: always add legacy 32byte RXDID in supported_rxdids

2023-09-20 Thread Jacob Keller
On 9/20/2023 4:54 AM, Michal Schmidt wrote: > When the PF and VF drivers both support flexible rx descriptors and have > negotiated the VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC capability, the VF driver > queries the PF for the list of supported descriptor formats > (VIRTCHNL_OP_GET_SUPPORTED_RXDIDS). T

Re: [Intel-wired-lan] [PATCH net-next 1/3] ice: fix undefined references to ice_is_*() when !CONFIG_PTP_1588_CLOCK

2023-09-20 Thread Jacob Keller
On 9/20/2023 11:07 AM, Alexander Lobakin wrote: > Starting the cited commit, ice_lib.c unconditionally refers to three > functions compiled only when CONFIG_PTP_1588_CLOCK is set (as they're > located in ice_ptp_hw.c): > > ERROR: modpost: "ice_is_clock_mux_present_e810t" > [drivers/net/ethernet

Re: [Intel-wired-lan] [PATCH net-next 2/3] ice: fix undefined references from DPLL code when !CONFIG_PTP_1588_CLOCK

2023-09-20 Thread Jacob Keller
On 9/20/2023 11:07 AM, Alexander Lobakin wrote: > DPLL code in ice unconditionally calls several PTP functions which are > only built when CONFIG_PTP_1588_CLOCK is set. This throws a good bunch > of link errors: > > ERROR: modpost: "ice_cgu_get_pin_name" > [drivers/net/ethernet/intel/ice/ice.ko

Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET

2023-09-20 Thread Jacob Keller
On 9/20/2023 11:07 AM, Alexander Lobakin wrote: > When CONFIG_INET is not set, tcp_gro_complete is not compiled, although > the drivers using it may still be compiled (spotted by Randy): > > aarch64-linux-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: > in function `idpf_rx_rsc.isra.0': > dri

Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors

2023-09-20 Thread Jacob Keller
On 9/20/2023 11:07 AM, Alexander Lobakin wrote: > Recently, several link-time issues were spotted in the ethernet/intel/ > folder thanks to Kbuild bots and linux-next. > The fixes are pretty straightforward, just some stubs and CONFIG_* > guards, so resolve all of them in one shot and unbreak ra

Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET

2023-09-20 Thread Jacob Keller
On 9/20/2023 2:30 PM, Randy Dunlap wrote: > > > On 9/20/23 11:07, Alexander Lobakin wrote: >> When CONFIG_INET is not set, tcp_gro_complete is not compiled, although >> the drivers using it may still be compiled (spotted by Randy): >> >> aarch64-linux-ld: drivers/net/ethernet/intel/idpf/idpf_t

[Intel-wired-lan] [PATCH net-next] ice: fix linking when CONFIG_PTP_1588_CLOCK=n

2023-09-20 Thread Jacob Keller
The recent support for DPLL introduced by commit 8a3a565ff210 ("ice: add admin commands to access cgu configuration") and commit d7999f5ea64b ("ice: implement dpll interface to control cgu") broke linking the ice driver if CONFIG_PTP_1588_CLOCK=n: ld: vmlinux.o: in function `ice_init_feature_suppo

Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET

2023-09-20 Thread Randy Dunlap
On 9/20/23 17:04, Jacob Keller wrote: > > > On 9/20/2023 2:30 PM, Randy Dunlap wrote: >> >> >> On 9/20/23 11:07, Alexander Lobakin wrote: >>> When CONFIG_INET is not set, tcp_gro_complete is not compiled, although >>> the drivers using it may still be compiled (spotted by Randy): >>> >>> aarch