Re: [Intel-wired-lan] [PATCH] ixgbe: Add support for firmware update

2024-06-11 Thread Chien, Richard (Options Engineering)
> I would also think about why Intel has not submitted this code before? > Maybe because it does things the wrong way? Please look at how other > Ethernet drivers support firmware. Is it the same? It might be you need to > throw away this code and reimplement it to mainline standards, maybe using >

Re: [Intel-wired-lan] [PATCH] ixgbe: Add support for firmware update

2024-06-10 Thread Andrew Lunn
On Sun, Jun 09, 2024 at 04:57:35PM +0800, Richard chien wrote: > This patch adds support for firmware update to the in-tree ixgbe driver and > it is actually a port > from the out-of-tree ixgbe driver. In-band firmware update is one of the > essential system maintenance > tasks. To simplify this

Re: [Intel-wired-lan] [PATCH] ixgbe: Add support for firmware update

2024-06-09 Thread kernel test robot
Hi Richard, kernel test robot noticed the following build warnings: [auto build test WARNING on tnguy-net-queue/dev-queue] [also build test WARNING on linus/master v6.10-rc3 next-20240607] [cannot apply to tnguy-next-queue/dev-queue] [If your patch is applied to the wrong git tree, kindly drop us

Re: [Intel-wired-lan] [PATCH] ixgbe: Add support for firmware update

2024-06-09 Thread Markus Elfring
> This patch adds support for firmware update to the in-tree ixgbe driver and > it is actually a port > from the out-of-tree ixgbe driver. In-band firmware update is one of the > essential system maintenance … Please improve such a change description also according to word wrapping because of mo