Re: [Intel-wired-lan] [PATCH net-next v3 1/3] ethtool: Implement ethtool_puts()

2023-10-30 Thread Justin Stitt
On Fri, Oct 27, 2023 at 4:43 PM Andrew Lunn wrote: > > > +/** > > + * ethtool_puts - Write string to ethtool string data > > + * @data: Pointer to start of string to update > > Isn't it actually a pointer to a pointer to the start of string to > update? I suppose. FWIW, I just copy-pasted the sp

[Intel-wired-lan] [PATCH net-next v3 1/3] ethtool: Implement ethtool_puts()

2023-10-30 Thread Justin Stitt
Use strscpy() to implement ethtool_puts(). Functionally the same as ethtool_sprintf() when it's used with two arguments or with just "%s" format specifier. Signed-off-by: Justin Stitt --- include/linux/ethtool.h | 13 + net/ethtool/ioctl.c | 7 +++ 2 files changed, 20 inser

Re: [Intel-wired-lan] [PATCH net-next v3 1/3] ethtool: Implement ethtool_puts()

2023-10-28 Thread Andrew Lunn
On Fri, Oct 27, 2023 at 06:20:08PM -0700, Justin Stitt wrote: > On Fri, Oct 27, 2023 at 4:43 PM Andrew Lunn wrote: > > > > > +/** > > > + * ethtool_puts - Write string to ethtool string data > > > + * @data: Pointer to start of string to update > > > > Isn't it actually a pointer to a pointer to t

Re: [Intel-wired-lan] [PATCH net-next v3 1/3] ethtool: Implement ethtool_puts()

2023-10-27 Thread Andrew Lunn
> +/** > + * ethtool_puts - Write string to ethtool string data > + * @data: Pointer to start of string to update Isn't it actually a pointer to a pointer to the start of string to update? > +extern void ethtool_puts(u8 **data, const char *str); Andrew ___