Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable

2023-10-08 Thread Pucha, HimasekharX Reddy
ubject: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable > > Since the introduction of the ice driver the code has been > double-shifting the RSS enabling field, because the define already has > shifts in it and can't have the regular pattern of "a << shi

Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable

2023-10-03 Thread Simon Horman
On Mon, Oct 02, 2023 at 10:31:10PM -0700, Jesse Brandeburg wrote: > Since the introduction of the ice driver the code has been > double-shifting the RSS enabling field, because the define already has > shifts in it and can't have the regular pattern of "a << shiftval & > mask" applied. > > Most pl

[Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable

2023-10-02 Thread Jesse Brandeburg
Since the introduction of the ice driver the code has been double-shifting the RSS enabling field, because the define already has shifts in it and can't have the regular pattern of "a << shiftval & mask" applied. Most places in the code got it right, but one line was still wrong. Fix this one loca