Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Fri, Dec 15, 2023 at 10:01:36AM -0800, Brett Creeley wrote: > [...] > > > > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > b/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > index df76493faa75..50761c2d9f3b 100644 > > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > +++

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Brett Creeley
On 12/12/2023 6:55 AM, Michal Kubiak wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Joshua Hay Tell hardware to writeback completed descriptors even when interrupts are disabled. Otherwise,

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Thu, Dec 14, 2023 at 01:59:57PM +0100, Paul Menzel wrote: > Lieber Michal, > > > Am 13.12.23 um 14:23 schrieb Michal Kubiak: > > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > > > > On 12/12/23 15:55, Michal Kubiak wrote: > > > > From: Joshua Hay > > > > > > > > Tell hardwar

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Wed, Dec 13, 2023 at 03:06:09PM -0800, Tony Nguyen wrote: > > > On 12/13/2023 2:22 PM, Nguyen, Anthony L wrote: > > > > > > > -Original Message- > > > From: Kubiak, Michal > > > Sent: Wednesday, December 13, 2023 5:51 AM > > > > > > On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-14 Thread Paul Menzel
Lieber Michal, Am 13.12.23 um 14:23 schrieb Michal Kubiak: On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: On 12/12/23 15:55, Michal Kubiak wrote: From: Joshua Hay Tell hardware to writeback completed descriptors even when interrupts Should you resend, the verb is spelled w

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-13 Thread Tony Nguyen
On 12/13/2023 2:22 PM, Nguyen, Anthony L wrote: -Original Message- From: Kubiak, Michal Sent: Wednesday, December 13, 2023 5:51 AM On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal Kubiak wrote: On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: Dear Michal, dear Joshua

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-13 Thread Nguyen, Anthony L
> -Original Message- > From: Kubiak, Michal > Sent: Wednesday, December 13, 2023 5:51 AM > > On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal Kubiak wrote: > > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > > > Dear Michal, dear Joshua, > > > > > > > > > Thank you for y

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-13 Thread Michal Kubiak
On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal Kubiak wrote: > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > > Dear Michal, dear Joshua, > > > > > > Thank you for your patch. > > > > On 12/12/23 15:55, Michal Kubiak wrote: > > > From: Joshua Hay > > > > > > Tell hardware to

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-13 Thread Michal Kubiak
On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > Dear Michal, dear Joshua, > > > Thank you for your patch. > > On 12/12/23 15:55, Michal Kubiak wrote: > > From: Joshua Hay > > > > Tell hardware to writeback completed descriptors even when interrupts > > Should you resend, the ve

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-12 Thread Paul Menzel
Dear Michal, dear Joshua, Thank you for your patch. On 12/12/23 15:55, Michal Kubiak wrote: > From: Joshua Hay > > Tell hardware to writeback completed descriptors even when interrupts Should you resend, the verb is spelled with a space: write back. > are disabled. Otherwise, descriptors mig

[Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-12 Thread Michal Kubiak
From: Joshua Hay Tell hardware to writeback completed descriptors even when interrupts are disabled. Otherwise, descriptors might not be written back until the hardware can flush a full cacheline of descriptors. This can cause unnecessary delays when traffic is light (or even trigger Tx queue tim