Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix handling changed priv flags

2024-10-30 Thread Paul Menzel
[Cc: -Jesse 550 #5.1.0 Address rejected.] Am 30.10.24 um 17:34 schrieb Paul Menzel: [Cc: +Przemek who succeeded Jesse] Dear Peter, Thank you very much for your patch. Some minor comments. Am 30.10.24 um 17:06 schrieb pe...@friiks.de: From: Peter Große After assembling the new private flag

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix handling changed priv flags

2024-10-30 Thread Paul Menzel
[Cc: +Przemek who succeeded Jesse] Dear Peter, Thank you very much for your patch. Some minor comments. Am 30.10.24 um 17:06 schrieb pe...@friiks.de: From: Peter Große After assembling the new private flags on a PF, the operation to determine the changed flags uses the wrong bitmaps. Instea

[Intel-wired-lan] [PATCH iwl-net] i40e: Fix handling changed priv flags

2024-10-30 Thread pegro
From: Peter Große After assembling the new private flags on a PF, the operation to determine the changed flags uses the wrong bitmaps. Instead of xor-ing orig_flags with new_flags, it uses the still unchanged pf->flags, thus changed_flags is always 0. Fix it by using the corrent bitmaps. The i