[Intel-wired-lan] [PATCH] ixgbe: remove self assignment

2025-02-10 Thread Ethan Carter Edwards
Variable self assignment does not have any effect. Addresses-Coverity-ID: 1641823 ("Self assignment") Fixes: 46761fd52a886 ("ixgbe: Add support for E610 FW Admin Command Interface") Signed-off-by: Ethan Carter Edwards --- drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 1 - 1 file changed, 1 del

Re: [Intel-wired-lan] [PATCH] ixgbe: remove self assignment

2025-02-10 Thread Andrew Lunn
On Sun, Feb 09, 2025 at 11:47:24PM -0500, Ethan Carter Edwards wrote: > Variable self assignment does not have any effect. Hi Ethan As a general rule, it would be good to explain in the comment message what research you did to find out why there is a self assignment, and why just deleting it is t

Re: [Intel-wired-lan] [PATCH] ixgbe: remove self assignment

2025-02-09 Thread Michal Swiatkowski
On Sun, Feb 09, 2025 at 11:47:24PM -0500, Ethan Carter Edwards wrote: > Variable self assignment does not have any effect. > > Addresses-Coverity-ID: 1641823 ("Self assignment") > Fixes: 46761fd52a886 ("ixgbe: Add support for E610 FW Admin Command > Interface") > Signed-off-by: Ethan Carter Edwar