Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
On 2024-09-23 17:10:36 -0700, Jacob Keller wrote: > > > On 9/23/2024 4:11 PM, Jacob Keller wrote: > > > > > > On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: > >> Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") > >> changed igb_io_error_detected() to ignore non-fatal pcie erro

Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
On 2024-09-23 16:11:14 -0700, Jacob Keller wrote: > > > On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: > > Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") > > changed igb_io_error_detected() to ignore non-fatal pcie errors in order > > to avoid hung task that can happen when ig

[Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") changed igb_io_error_detected() to ignore non-fatal pcie errors in order to avoid hung task that can happen when igb_down() is called multiple times. This caused an issue when processing transient non-fatal errors. igb_io_resume(),

Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-23 Thread Jacob Keller
On 9/23/2024 4:11 PM, Jacob Keller wrote: > > > On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: >> Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") >> changed igb_io_error_detected() to ignore non-fatal pcie errors in order >> to avoid hung task that can happen when igb_down()

Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-23 Thread Jacob Keller
On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: > Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") > changed igb_io_error_detected() to ignore non-fatal pcie errors in order > to avoid hung task that can happen when igb_down() is called multiple > times. This caused an issue whe