Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-11 Thread Jacob Keller
On 6/11/2024 12:55 AM, Chien, Richard (Options Engineering) wrote: >> However, this implementation is wrong. It is exposing the >> ETHTOOL_GEEPROM and ETHTOOL_SEEPROM interface and abusing it to >> implement a non-standard interface that is custom to the out-of-tree Intel >> drivers to support t

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-11 Thread Chien, Richard (Options Engineering)
> However, this implementation is wrong. It is exposing the > ETHTOOL_GEEPROM and ETHTOOL_SEEPROM interface and abusing it to > implement a non-standard interface that is custom to the out-of-tree Intel > drivers to support the flash update utility. > > This implementation was widely rejected when

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-10 Thread Jacob Keller
On 6/9/2024 1:15 AM, Richard chien wrote: > This patch adds support for firmware update to the in-tree igb driver and it > is actually a port from the out-of-tree igb driver. > In-band firmware update is one of the essential system maintenance tasks. To > simplify this task, the Intel online f

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-10 Thread Andrew Lunn
On Sun, Jun 09, 2024 at 04:15:26PM +0800, Richard chien wrote: > This patch adds support for firmware update to the in-tree igb driver and it > is actually a port from the out-of-tree igb driver. > In-band firmware update is one of the essential system maintenance tasks. To > simplify this task,

[Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-10 Thread Richard chien
This patch adds support for firmware update to the in-tree igb driver and it is actually a port from the out-of-tree igb driver. In-band firmware update is one of the essential system maintenance tasks. To simplify this task, the Intel online firmware update utility provides a common interface th

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-09 Thread kernel test robot
Hi Richard, kernel test robot noticed the following build warnings: [auto build test WARNING on tnguy-next-queue/dev-queue] [also build test WARNING on tnguy-net-queue/dev-queue linus/master v6.10-rc3 next-20240607] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-09 Thread Markus Elfring
> This patch adds support for firmware update to the in-tree igb driver and it > is actually a port from the out-of-tree igb driver. > In-band firmware update is one of the essential system maintenance tasks. To > simplify this task, the Intel online firmware update … Please improve such a chang