Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-04-11 Thread Jacek Kowalski
If this approach is acceptable to you, I will prepare a patch with the proposed fix and send it to you next week for testing on your system. What solution do you have in mind? The only one I can think of is to ignore the checksum completely if the valid_csum_mask condition is not met on e1000_p

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-04-11 Thread Jacek Kowalski
I'll experiment a little more and get back to you.>> Specifically I'll try to dump the NVM contents before and after running e1000e_update_nvm_checksum and after a reboot. I finally had a moment to take a look at the issue again. This change also makes everything work on my system: diff --gi

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-04-10 Thread Lifshits, Vitaly
On 3/31/2025 11:36 PM, Jacek Kowalski wrote: Hi, Are you certain that the UEFI FW corrupts the checksum each time, or is it just that the system left the factory with incorrect checksum? I'm quite far from that device at the moment, but from what I remember: - when I forced the NVM update

[Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-04-05 Thread Jacek Kowalski
Many laptops and motherboards including I219-V network card have invalid NVM checksum. While in most instances checksum is fixed by e1000e module or by using bootutil, some setups are resistant to NVM modifications. This result in the network card being completely unusable. It seems to be the case

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-04-04 Thread Lifshits, Vitaly
On 3/18/2025 10:46 PM, Jacek Kowalski wrote: Many laptops and motherboards including I219-V network card have invalid NVM checksum. While in most instances checksum is fixed by e1000e module or by using bootutil, some setups are resistant to NVM modifications. This result in the network card b

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-03-31 Thread Jacek Kowalski
Hi, Are you certain that the UEFI FW corrupts the checksum each time, or is it just that the system left the factory with incorrect checksum? I'm quite far from that device at the moment, but from what I remember: - when I forced the NVM update path in the driver, the device would work, - aft

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-03-31 Thread Jacek Kowalski
From a technical perspective, your patch looks correct. However, if the checksum validation is skipped, there is no way to distinguish between the simple checksum error described above, and actual NVM corruption, which may result in loss of functionality and undefined behavior. This means, that if

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-03-31 Thread Andrew Lunn
> From a technical perspective, your patch looks correct. However, if the > checksum validation is skipped, there is no way to distinguish between the > simple checksum error described above, and actual NVM corruption, which may > result in loss of functionality and undefined behavior. This means,

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-03-19 Thread Loktionov, Aleksandr
tel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM > checksum > > Many laptops and motherboards including I219-V network card have invalid > NVM checksum. While in most i