[Intel-wired-lan] [PATCH v4 net-next 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp()

ijalkowski Reviewed-by: Jacob Keller Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igb/igb_main.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index f1

[Intel-wired-lan] [PATCH v4 net-next 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

drop actions") Reviewed-by: Jacob Keller Reviewed-by: Maciej Fijalkowski Signed-off-by: Yue Haibing --- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 --- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/d

[Intel-wired-lan] [PATCH v4 net-next 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()

tions") Reviewed-by: Jacob Keller Reviewed-by: Maciej Fijalkowski Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 --- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/ne

[Intel-wired-lan] [PATCH v4 net-next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

arget to net-next v3: https://lore.kernel.org/bpf/20241022065623.1282224-3-yuehaib...@huawei.com/T/ Fix uninitialized 'xdp_res' in patch 3 and 4 which Reported-by kernel test robot v2: Fix this as i40e drivers done instead of return NULL in xdp run code Yue Haibing (4): ig

[Intel-wired-lan] [PATCH v4 net-next 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

:2533 igc_xdp_run_prog() warn: passing zero to 'ERR_PTR' Fixes: 26575105d6ed ("igc: Add initial XDP support") Reviewed-by: Maciej Fijalkowski Reviewed-by: Jacob Keller Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igc/igc_main.c | 20 +++- 1 file c

Re: [Intel-wired-lan] [PATCH v3 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

On 2024/10/23 3:17, Jacob Keller wrote: > > > On 10/22/2024 12:32 AM, Simon Horman wrote: >> On Tue, Oct 22, 2024 at 02:56:19PM +0800, Yue Haibing wrote: >>> Fixing sparse error in xdp run code by introducing new variable xdp_res >>> instead of overloading

[Intel-wired-lan] [PATCH v3 net 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

drop actions") Reviewed-by: Jacob Keller Signed-off-by: Yue Haibing --- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 --- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/int

[Intel-wired-lan] [PATCH v3 net 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

:2533 igc_xdp_run_prog() warn: passing zero to 'ERR_PTR' Fixes: 26575105d6ed ("igc: Add initial XDP support") Reviewed-by: Maciej Fijalkowski Reviewed-by: Jacob Keller Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igc/igc_main.c | 20 +++- 1 file c

[Intel-wired-lan] [PATCH v3 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

initialized 'xdp_res' in patch 3 and 4 which Reported-by kernel test robot v2: Fix this as i40e drivers done instead of return NULL in xdp run code Yue Haibing (4): igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog() igb: Fix passing 0 to ERR_PTR in igb_run_xdp() ixgb

[Intel-wired-lan] [PATCH v3 net 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp()

ijalkowski Reviewed-by: Jacob Keller Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igb/igb_main.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index f1

[Intel-wired-lan] [PATCH v3 net 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()

tions") Reviewed-by: Jacob Keller Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 --- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ma

Re: [Intel-wired-lan] [tnguy-next-queue:dev-queue 50/51] drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:2391 ixgbe_clean_rx_irq() error: uninitialized symbol 'xdp_res'.

wski 2021-01-18 2339 unsigned int offset = > rx_ring->rx_offset; > ad088ec4807688 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c Jesper Dangaard > Brouer 2018-06-26 2340 unsigned int xdp_xmit = 0; > 99ffc5ade4e870 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Re: [Intel-wired-lan] [PATCH v2 net 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

On 2024/10/18 20:23, Maciej Fijalkowski wrote: > On Fri, Oct 18, 2024 at 10:37:34AM +0800, Yue Haibing wrote: >> ixgbevf_run_xdp() converts customed xdp action to a negative error code >> with the sk_buff pointer type which be checked with IS_ERR in >> ixgbevf_clean_rx_irq

Re: [Intel-wired-lan] [PATCH v2 net 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()

On 2024/10/18 20:22, Maciej Fijalkowski wrote: > On Fri, Oct 18, 2024 at 10:37:33AM +0800, Yue Haibing wrote: >> ixgbe_run_xdp() converts customed xdp action to a negative error code >> with the sk_buff pointer type which be checked with IS_ERR in >> ixgbe_clean_rx_irq(). Remo

[Intel-wired-lan] [PATCH v2 net 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

:2533 igc_xdp_run_prog() warn: passing zero to 'ERR_PTR' Fixes: 26575105d6ed ("igc: Add initial XDP support") Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igc/igc_main.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/driver

[Intel-wired-lan] [PATCH v2 net 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp()

igb_run_xdp() converts customed xdp action to a negative error code with the sk_buff pointer type which be checked with IS_ERR in igb_clean_rx_irq(). Remove this error pointer handing instead use plain int return value. Fixes: 9cbc948b5a20 ("igb: add XDP support") Signed-off-by: Y

[Intel-wired-lan] [PATCH v2 net 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()

tions") Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 --- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 8b8404d8c946..78

[Intel-wired-lan] [PATCH v2 net 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

drop actions") Signed-off-by: Yue Haibing --- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 --- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index 14

[Intel-wired-lan] [PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

this as i40e drivers done instead of return NULL in xdp run code Yue Haibing (4): igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog() igb: Fix passing 0 to ERR_PTR in igb_run_xdp() ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp() ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

Re: [Intel-wired-lan] [PATCH -next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

Pls ignore this corrupt patch, sorry for noise. On 2024/10/18 10:29, Yue Haibing wrote: > Fixing sparse error in xdp run code by introducing new variable xdp_res > instead of overloading this into the skb pointer as i40e drivers done > in commit 12738ac4754e ("i40e: Fix sp

[Intel-wired-lan] [PATCH net 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

:2533 igc_xdp_run_prog() warn: passing zero to 'ERR_PTR' Fixes: 26575105d6ed ("igc: Add initial XDP support") Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igc/igc_main.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/driver

[Intel-wired-lan] [PATCH -next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

Fixing sparse error in xdp run code by introducing new variable xdp_res instead of overloading this into the skb pointer as i40e drivers done in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c") and commit ae4393dfd472 ("i40e: fix broken XDP support"). Yue Hai

Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

On 2024/10/17 7:12, Jacob Keller wrote: > > > On 10/16/2024 4:06 PM, Jacob Keller wrote: >> >> >> On 10/16/2024 11:53 AM, Simon Horman wrote: >>> On Wed, Oct 16, 2024 at 06:53:10PM +0800, Yue Haibing wrote: >>>> Return NULL instead of passing to

Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

On 2024/10/17 7:12, Jacob Keller wrote: > > > On 10/16/2024 4:06 PM, Jacob Keller wrote: >> >> >> On 10/16/2024 11:53 AM, Simon Horman wrote: >>> On Wed, Oct 16, 2024 at 06:53:10PM +0800, Yue Haibing wrote: >>>> Return NULL instead of passing to

[Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

Return NULL instead of passing to ERR_PTR while res is IGC_XDP_PASS, which is zero, this fix smatch warnings: drivers/net/ethernet/intel/igc/igc_main.c:2533 igc_xdp_run_prog() warn: passing zero to 'ERR_PTR' Fixes: 26575105d6ed ("igc: Add initial XDP support") Signed

[Intel-wired-lan] [PATCH net-next 2/3] igb: Cleanup unused declarations

lementation. Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igb/e1000_mac.h | 1 - drivers/net/ethernet/intel/igb/e1000_nvm.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.h b/drivers/net/ethernet/intel/igb/e1000_mac.h index 6e110f28f922.

[Intel-wired-lan] [PATCH net-next 1/3] iavf: Remove unused declarations

There is no caller and implementation in tree. Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/iavf/iavf.h | 10 -- drivers/net/ethernet/intel/iavf/iavf_prototype.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b

[Intel-wired-lan] [PATCH net-next 3/3] ice: Cleanup unused declarations

declared ice_pkg_buf_get_free_space(), and commit 8a3a565ff210 ("ice: add admin commands to access cgu configuration") declared ice_is_pca9575_present(), but all these never be implemented. Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/ice/ice_eswitch.h | 5 - drivers/net/ethe

[Intel-wired-lan] [PATCH net-next 0/3] Cleanup intel driver declarations

Yue Haibing (3): iavf: Remove unused declarations igb: Cleanup unused declarations ice: Cleanup unused declarations drivers/net/ethernet/intel/iavf/iavf.h | 10 -- drivers/net/ethernet/intel/iavf/iavf_prototype.h | 3 --- drivers/net/ethernet/intel/ice/ice_eswitch.h

[Intel-wired-lan] [PATCH net-next] igbvf: Remove two unused declarations

There is no caller and implementations in tree. Signed-off-by: Yue Haibing --- drivers/net/ethernet/intel/igbvf/igbvf.h | 1 - drivers/net/ethernet/intel/igbvf/mbx.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igbvf/igbvf.h b/drivers/net/ethernet/intel