Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-03-04 Thread Takeru Hayasaka
rg/all/20240305074350.533622-1-hayatake...@gmail.com/ Takeru 2024年3月5日(火) 13:28 Pucha, HimasekharX Reddy : > > >-Original Message- > > From: Takeru Hayasaka > > Sent: Tuesday, March 5, 2024 9:12 AM > > To: Pucha, HimasekharX Reddy > > Cc: Brandeburg, J

Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-03-04 Thread Takeru Hayasaka
Hi Himasekhar Reddy-san > Functionality wise its working fine. But the ethtool part (tab complete > doesn't show GTP) I forgot to add the tab completion feature! Thank you for the good points. I've added it again in this version's patch. https://lore.kernel.org/all/20240305033555.524741-1-hayata

Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-02-16 Thread Takeru Hayasaka
Hi Tony-san Thanks for your reply! > Everything is good for now. If we have issues or questions we will reach > out to you. Okay. Let me know if there's anything I can help with:) Thanks Takeru

Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-02-16 Thread Takeru Hayasaka
Hi Tony-san and Paolo-san! > > The series LGTM. I *think* the series should go first in the intel Thank you both for picking up on the topic! > I agree. I think it would make sense for this to go through IWL. I understand. So, it means that it will go through the IWL branch and then through net

Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-02-15 Thread Takeru Hayasaka
the terminals connected to a particular base station.This case can be > solved by using this patch. > > Signed-off-by: Takeru Hayasaka > Reviewed-by: Marcin Szycik > --- > v2->v3: Based on Harald-san's review, I added documentation and comments to > ethtool.h and ice.rst.

Re: [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-02-11 Thread Takeru Hayasaka
Hi Simon-san. Thank you for your reply! > It appears that the series at the link above has been marked as > "Changes Requested" in patchwork. Although I am unsure why. > > I would suggest reposting it, say with the tags supplied by Marcin Szycik > as [PATCH net-next v8]. I have resent it earlier

[Intel-wired-lan] [PATCH net-next v8 2/2] ice: Implement RSS settings for GTP using ethtool

2024-02-11 Thread Takeru Hayasaka
implementation covers the handling of gtpu(4|6), gtpc(4|6), gtpc(4|6)t, gtpu(4|6)e, gtpu(4|6)u, and gtpu(4|6)d traffic, providing enhanced load distribution for GTP traffic across multiple processing units. Signed-off-by: Takeru Hayasaka Reviewed-by: Marcin Szycik --- .../device_drivers/ethernet/intel

[Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-02-11 Thread Takeru Hayasaka
PGW can only perform RSS within the IP range of the SGW. Problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station.This case can be solved by using this patch. Signed-off-by: Takeru Hayasaka Reviewed-by: Marcin S

Re: [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-02-08 Thread Takeru Hayasaka
etdevbpf/patch/20240201033310.1028154-1-hayatake...@gmail.com/ https://patchwork.kernel.org/project/netdevbpf/patch/20240201033310.1028154-2-hayatake...@gmail.com/ 2024年2月9日(金) 0:23 Jakub Kicinski : > > On Thu, 8 Feb 2024 16:34:49 +0900 Takeru Hayasaka wrote: > > Hello Jakub-san, a

Re: [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-02-07 Thread Takeru Hayasaka
to a single commit makes the uAPI addition to easy to miss. > > Understood. I will split the patches and submit them separately in v7. > > Thanks > Takeru > > 2024年2月1日(木) 6:13 Jakub Kicinski : > > > > On Wed, 31 Jan 2024 13:46:22 + Takeru Hayasak

Re: [Intel-wired-lan] [PATCH net-next v7 2/2] ice: Implement RSS settings for GTP using ethtool

2024-01-31 Thread takeru hayasaka
Hi reviews. I made a mistake in sending the patch without increasing the version, so I will send it again as v7. Thanks Takeru 2024年2月1日(木) 12:33 Takeru Hayasaka : > > Following the addition of new GTP RSS hash options to ethtool.h, this patch > implements the corresponding RSS setting

[Intel-wired-lan] [PATCH net-next v7 2/2] ice: Implement RSS settings for GTP using ethtool

2024-01-31 Thread Takeru Hayasaka
implementation covers the handling of gtpu(4|6), gtpc(4|6), gtpc(4|6)t, gtpu(4|6)e, gtpu(4|6)u, and gtpu(4|6)d traffic, providing enhanced load distribution for GTP traffic across multiple processing units. Signed-off-by: Takeru Hayasaka --- .../device_drivers/ethernet/intel/ice.rst | 21 - drivers

[Intel-wired-lan] [PATCH net-next v7 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-01-31 Thread Takeru Hayasaka
PGW can only perform RSS within the IP range of the SGW. Problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station.This case can be solved by using this patch. Signed-off-by: Takeru Hayasaka --- v2->v3: Based o

[Intel-wired-lan] [PATCH net-next v6 2/2] ice: Implement RSS settings for GTP using ethtool

2024-01-31 Thread Takeru Hayasaka
implementation covers the handling of gtpu(4|6), gtpc(4|6), gtpc(4|6)t, gtpu(4|6)e, gtpu(4|6)u, and gtpu(4|6)d traffic, providing enhanced load distribution for GTP traffic across multiple processing units. Signed-off-by: Takeru Hayasaka --- .../device_drivers/ethernet/intel/ice.rst | 21 - drivers

[Intel-wired-lan] [PATCH net-next v6 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-01-31 Thread Takeru Hayasaka
PGW can only perform RSS within the IP range of the SGW. Problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station.This case can be solved by using this patch. Signed-off-by: Takeru Hayasaka --- v2->v3: Based o

Re: [Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread takeru hayasaka
o easy to miss. Understood. I will split the patches and submit them separately in v7. Thanks Takeru 2024年2月1日(木) 6:13 Jakub Kicinski : > > On Wed, 31 Jan 2024 13:46:22 + Takeru Hayasaka wrote: > > .../device_drivers/ethernet/intel/ice.rst | 21 - > > drivers/net/ether

[Intel-wired-lan] [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread Takeru Hayasaka
PGW can only perform RSS within the IP range of the SGW. Problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station.This case can be solved by using this patch. Signed-off-by: Takeru Hayasaka --- v2->v3: Based o

Re: [Intel-wired-lan] [PATCH net-next v5] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread takeru hayasaka
Hi Marcin-san > LGTM Thanks for your review! > Still removing this line :c Oh! Sorry for the oversight. I will fix it in the next patch. Could you please take another look at the patch? Thanks Takeru 2024年1月31日(水) 20:53 Marcin Szycik : > > > > On 31.01.2024 02:37, Tak

Re: [Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-30 Thread takeru hayasaka
Hi Harald-san I apologize for the delay in making further progress on this patch.(I'm three months late... > There are many different GTPv2C messages Thank you for your assistance in explaining GTPC:) Thanks, Takeru 2024年1月30日(火) 19:15 Harald Welte : > > hi Marcin, > > Disclaimer: I have no un

[Intel-wired-lan] [PATCH net-next v5] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-30 Thread Takeru Hayasaka
PGW can only perform RSS within the IP range of the SGW. Problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station.This case can be solved by using this patch. Signed-off-by: Takeru Hayasaka --- v2->v3: Based o

Re: [Intel-wired-lan] [PATCH net-next v4] ethtool: ice: Support for RSS settings to GTP

2024-01-30 Thread takeru hayasaka
LOW_HASH_GTP_TEID to ICE_FLOW_HASH_GTP_C_TEID, which is clearer.) ICE_FLOW_HASH_GTP_IPV(4|6)_TEID -> ICE_FLOW_HASH_GTP_U_IPV(4|6)_TEID > Again, missing space before ( Sorry, I forgot to fix that. I will make sure it's corrected in the next one. Thanks, Takeru 2024年1月30日(火) 23:41 Marcin Szycik

Re: [Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-30 Thread takeru hayasaka
lly, it depends on the implementation, but there is a reason for differentiation as the context is different between cases where GTPC includes TEID and those where it does not. Thanks, Takeru 2024年1月30日(火) 18:59 Marcin Szycik : > > > > On 30.01.2024 07:39, takeru hayasaka wrote: >

[Intel-wired-lan] [PATCH net-next v4] ethtool: ice: Support for RSS settings to GTP

2024-01-30 Thread Takeru Hayasaka
, the PGW can only perform RSS within the IP range of the SGW. Problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station.This case can be solved by using this patch. Signed-off-by: Takeru Hayasaka --- v2->v3:

Re: [Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-29 Thread takeru hayasaka
PSC included in the Extension Header distinguishes between UL/DL. By using this option, it becomes possible to process including UL/DL. Marcin-san, thank you very much for your feedback! I will reflect your comments in the next patch. Takeru 2024年1月29日(月) 23:23 Marcin Szycik : > > &g

[Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-27 Thread Takeru Hayasaka
instance, the PGW can only perform RSS within the IP range of the SGW.Problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station.This case can be solved by using this patch. Signed-off-by: Takeru Hayasaka --- (I

Re: [Intel-wired-lan] [PATCH net-next v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-27 Thread takeru hayasaka
s sent at least four(?) times to the mailing list. Could > you please sent a patch tagged with [RESENT] or a v4, so there won’t be > several replies to different threads. > > One nit below: > > Am 26.01.24 um 05:52 schrieb Takeru Hayasaka: > > This is a patch that enable

[Intel-wired-lan] [PATCH net-next v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-25 Thread Takeru Hayasaka
, the PGW can only perform RSS within the IP range of the SGW. problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station. This case can be solved by using this patch Signed-off-by: Takeru Hayasaka --- Sorry for the

[Intel-wired-lan] [PATCH net-next v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-25 Thread Takeru Hayasaka
IP addresses. For instance, the PGW can only perform RSS within the IP range of the SGW. problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station. This case can be solved by using this patch Signed-off-by: Takeru Hay

[Intel-wired-lan] [PATCH net-next v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-25 Thread Takeru Hayasaka
IP addresses. For instance, the PGW can only perform RSS within the IP range of the SGW. problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station. This case can be solved by using this patch Signed-off-by: Takeru Hay

[Intel-wired-lan] [PATCH net-next v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-25 Thread Takeru Hayasaka
IP addresses. For instance, the PGW can only perform RSS within the IP range of the SGW. problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station. This case can be solved by using this patch Signed-off-by: Takeru Hay

[Intel-wired-lan] [PATCH net-next v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-25 Thread Takeru Hayasaka
of IP addresses. For instance, the PGW can only perform RSS within the IP range of the SGW. problematic from a load distribution perspective, especially if there's a bias in the terminals connected to a particular base station. This case can be solved by using this patch Signed-off-by: T

Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-18 Thread takeru hayasaka
ase in the future. The bad thing is that it may not be able to handle detailed use cases. Please let me know which one, 1 or 2, you prefer. Also, I would be happy if there is any further feedback! Thanks 2023年10月18日(水) 17:26 Harald Welte : > > Hi Takeru, > > On Wed, Oct 18, 2023 at 01:

Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-17 Thread takeru hayasaka
else think? 2023年10月18日(水) 8:49 Jakub Kicinski : > > On Tue, 17 Oct 2023 23:37:57 +0900 takeru hayasaka wrote: > > > Are there really deployments where the *very limited* GTP-C control > > I also think that it should not be limited to GTP-C. However, as I > > wrote in

Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-17 Thread takeru hayasaka
if it seems better to reduce them, it might be good to only incorporate gtp4|6, gtpc4|6, gtpue4|6. I would be happy to receive your feedback :) 2023年10月17日(火) 23:37 takeru hayasaka : > > Hi Harald-san > > Thanks for your review! > > > so if I'm guessing correctly, those w

Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-17 Thread takeru hayasaka
-dynamic-device-personalization-ddp-technology-guide.html (cf. Table 8. Patterns and Input Sets for iavf RSS) 2023年10月17日(火) 23:18 takeru hayasaka : > > Hi Jakub-san and Simon-san > Thank you for reviewing again! > > > Reviewed-by: Simon Horman > Thanks;) > > > Adding Wil

Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-17 Thread takeru hayasaka
is format is why it becomes so numerous. 2023年10月17日(火) 7:23 Jakub Kicinski : > > Thanks for the v2! > > Adding Willem, Pablo, and Harald to CC (please CC them on future > versions). > > On Thu, 12 Oct 2023 06:01:15 + Takeru Hayasaka wrote: > > diff --git a/include/u

[Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-12 Thread Takeru Hayasaka
ff-by: Takeru Hayasaka --- Added commit messages and options based on reviews drivers/net/ethernet/intel/ice/ice_ethtool.c | 116 ++- drivers/net/ethernet/intel/ice/ice_flow.h| 15 +++ drivers/net/ethernet/intel/ice/ice_lib.c | 84 ++ include/uapi/linux/etht

Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-12 Thread takeru hayasaka
ub Kicinski : > > On Wed, 11 Oct 2023 14:25:55 +0900 takeru hayasaka wrote: > > > Regarding the patch - you are only adding flow types, not a new field > > > (which are defined as RXH_*). If we want to hash on an extra field, > > > I think we need to specify that field

Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-12 Thread takeru hayasaka
6.137422-1-haiyue.w...@intel.com/ If we want to include something other than TEID (e.g., QFI) in Flow Director, I think it would be better to prepare a new field. 2023年10月11日(水) 11:10 Jakub Kicinski : > > On Wed, 11 Oct 2023 10:56:17 +0900 takeru hayasaka wrote: > > GTP generates a flo

Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-12 Thread takeru hayasaka
u for your understanding. --- Sorry! My email was blocked because it wasn't sent in plain text mode. I've made the necessary changes and will resend it. 2023年10月11日(水) 4:32 Jakub Kicinski : > > On Sun, 8 Oct 2023 07:52:22 + Takeru Hayasaka wrote: > > This is a patch that enables R

Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-12 Thread takeru hayasaka
u for your understanding. 2023年10月11日(水) 4:32 Jakub Kicinski : > On Sun, 8 Oct 2023 07:52:22 + Takeru Hayasaka wrote: > > This is a patch that enables RSS functionality for GTP packets using > > ethtool. > > A user can include her TEID and make RSS work for GTP-U over

[Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-12 Thread Takeru Hayasaka
. Signed-off-by: Takeru Hayasaka --- sorry. i signed off by mistake in email. i fixed. drivers/net/ethernet/intel/ice/ice_ethtool.c | 98 +++- drivers/net/ethernet/intel/ice/ice_flow.h| 15 +++ drivers/net/ethernet/intel/ice/ice_lib.c | 70 ++ include/uapi

[Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-12 Thread Takeru Hayasaka
From: Takeru Hayasaka This is a patch that enables RSS functionality for GTP packets using ethtool. A user can include her TEID and make RSS work for GTP-U over IPv4 by doing the following: `ethtool -N ens3 rx-flow-hash gtpu4 sd` In addition to gtpu(4|6), we now support gtpc(4|6), gtpu(4|6)e