On Tuesday, July 1, 2025 4:10 PM, Song Yoong Siang
wrote:
>Remove the unnecessary increment of the data_meta pointer to ensure the
>metadata area is correctly presented to XDP program and to avoid accidental
>overwriting of device-reserved metadata by XDP programs.
>
>Previously
9151d3d3eb...@as1pr10mb5675.eurprd10.prod.outlook.com/
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/net/ethernet/intel/igc/igc_main.c
index 686793c539f2..83
On Thursday, June 19, 2025 11:49 PM, Brett Creeley wrote:
>On 6/19/2025 8:37 AM, Song Yoong Siang wrote:
>> diff --git a/drivers/net/ethernet/intel/igc/igc.h
>b/drivers/net/ethernet/intel/igc/igc.h
>> index 1525ae25fd3e..c580ecc954be 100644
>> --- a/drivers/net/ethernet/
rx_q.*packets
rx_queue_0_packets: 20
rx_queue_1_packets: 10
rx_queue_2_packets: 0
rx_queue_3_packets: 10
Reviewed-by: Kurt Kanzenbach
Co-developed-by: Blanco Alcaine Hector
Signed-off-by: Blanco Alcaine Hector
Signed-off-by: Song Yoong Siang
---
drivers/net/eth
814-1-yoong.siang.s...@intel.com/
Song Yoong Siang (2):
igc: Relocate RSS field definitions to igc_defines.h
igc: Add wildcard rule support to ethtool NFC using Default Queue
drivers/net/ethernet/intel/igc/igc.h | 15 ++---
drivers/net/ethernet/intel/igc/igc_defines.h | 4
d
grouping of related constants
Reviewed-by: Kurt Kanzenbach
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc.h | 4
drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc
On Friday, June 20, 2025 3:46 PM, Kurt Kanzenbach wrote:
>On Thu Jun 19 2025, Song Yoong Siang wrote:
>> Introduce support for a lowest priority wildcard (catch-all) rule in
>> ethtool's Network Flow Classification (NFC) for the igc driver. The
>> wildcard rule dir
rx_q.*packets
rx_queue_0_packets: 20
rx_queue_1_packets: 10
rx_queue_2_packets: 0
rx_queue_3_packets: 10
Co-developed-by: Blanco Alcaine Hector
Signed-off-by: Blanco Alcaine Hector
Signed-off-by: Song Yoong Siang
---
V2:
- use Ethtool wildcard rule instead of extra
roduced on i226 by sending 10x 60 B frames with
>launch time set to minimal IPG (672 ns between starts of frames)
>on 1Gbit/s. Always 1026 frames are not sent and are missing a
>completion.
>
>Fixes: 9acf59a752d4c ("igc: Enable TX via AF_XDP zero-copy")
>Signed-off-by:
On Friday, March 7, 2025 9:25 PM, Bouska, Zdenek
wrote:
[...]
>> @@ -2996,7 +3035,13 @@ static void igc_xdp_xmit_zc(struct igc_ring *ring)
>> ntu = ring->next_to_use;
>> budget = igc_desc_unused(ring);
>>
>> -while (xsk_tx_peek_desc(pool, &xdp_desc) && budget--) {
>> +/* Packe
tly in sending 1000 packets continuously.
Min delta: 0.005 us
Avr delta: 0.016 us
Max delta: 0.031 us
Total packets forwarded: 1000
Reviewed-by: Faizal Rahim
Reviewed-by: Maciej Fijalkowski
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc.h | 1 +
drive
behind this handling.
Reviewed-by: Faizal Rahim
Reviewed-by: Maciej Fijalkowski
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 82 ++-
1 file changed, 50 insertions(+), 32 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b
tly in sending 1000 packets continuously.
Min delta: 08.410 us
Avr delta: 13.854 us
Max delta: 17.076 us
Total packets forwarded: 1000
Reviewed-by: Choong Yong Liang
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++
drivers/net/ethernet/stmicro/
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
s://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/
Song Yoong Siang (5):
xsk: Add launch time hardware offload support to XDP Tx metadata
selftests/bpf: Add launch time request to xdp_hw_metadata
net: stmmac: Add launch time support to XDP ZC
igc: Refactor empty frame
tly in sending 1000 packets continuously.
Min delta: 0.005 us
Avr delta: 0.016 us
Max delta: 0.031 us
Total packets forwarded: 1000
Reviewed-by: Faizal Rahim
Reviewed-by: Maciej Fijalkowski
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc.h | 1 +
drive
tly in sending 1000 packets continuously.
Min delta: 08.410 us
Avr delta: 13.854 us
Max delta: 17.076 us
Total packets forwarded: 1000
Reviewed-by: Choong Yong Liang
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++
drivers/net/ethernet/stmicro/
behind this handling.
Reviewed-by: Faizal Rahim
Reviewed-by: Maciej Fijalkowski
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 82 ++-
1 file changed, 50 insertions(+), 32 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h
xtime (Willem)
V1:
https://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/
Song Yoong Siang (5):
xsk: Add launch time hardware offload support to XDP Tx metadata
selftests/bpf: Add launch time request to xdp_hw_metadata
net: stmmac: Add launch time support to XD
On Sunday, February 16, 2025 3:04 AM, Jakub Kicinski wrote:
>On Sat, 15 Feb 2025 11:01:59 -0800 Jakub Kicinski wrote:
>> On Fri, 7 Feb 2025 10:19:39 +0800 Song Yoong Siang wrote:
>> > Extend the XDP Tx metadata framework so that user can requests launch time
>> >
tly in sending 1000 packets continuously.
Min delta: 0.005 us
Avr delta: 0.016 us
Max delta: 0.031 us
Total packets forwarded: 1000
Reviewed-by: Maciej Fijalkowski
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc.h | 1 +
drivers/net/ethernet/intel/igc/igc_
behind this handling.
Reviewed-by: Maciej Fijalkowski
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 82 ++-
1 file changed, 50 insertions(+), 32 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/net/ethernet/intel
tly in sending 1000 packets continuously.
Min delta: 08.410 us
Avr delta: 13.854 us
Max delta: 17.076 us
Total packets forwarded: 1000
Reviewed-by: Choong Yong Liang
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++
drivers/net/ethernet/stmicro/
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h
s://lore.kernel.org/netdev/20231201062421.1074768-1-yoong.siang.s...@intel.com/
- renamed to use Earliest TxTime First (Willem)
- renamed to use txtime (Willem)
V1:
https://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/
Song Yoong Siang (5):
xsk: Add launch time hardware
tly in sending 1000 packets continuously.
Min delta: 0.005 us
Avr delta: 0.016 us
Max delta: 0.031 us
Total packets forwarded: 1000
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc.h | 1 +
drivers/net/ethernet/intel/igc/igc_main.c | 57
behind this handling.
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 84 ++-
1 file changed, 52 insertions(+), 32 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/net/ethernet/intel/igc/igc_main.c
index
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
tly in sending 1000 packets continuously.
Min delta: 08.410 us
Avr delta: 13.854 us
Max delta: 17.076 us
Total packets forwarded: 1000
Reviewed-by: Choong Yong Liang
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++
drivers/net/ethernet/stmicro/
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Acked-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h
v/20231201062421.1074768-1-yoong.siang.s...@intel.com/
- renamed to use Earliest TxTime First (Willem)
- renamed to use txtime (Willem)
V1:
https://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/
Song Yoong Siang (5):
xsk: Add launch time hardware offload support to XDP T
On Thursday, February 6, 2025 12:08 AM, Fijalkowski, Maciej
wrote:
>On Wed, Feb 05, 2025 at 03:43:19PM +0100, Song, Yoong Siang wrote:
>> On Wednesday, February 5, 2025 8:31 PM, Fijalkowski,
>> Maciej wrote:
>> >On Wed, Feb 05, 2025 at 10:41:15AM +0800, Song Yoong Sia
On Wednesday, February 5, 2025 8:31 PM, Fijalkowski, Maciej
wrote:
>On Wed, Feb 05, 2025 at 10:41:15AM +0800, Song Yoong Siang wrote:
>> Refactor the code for inserting an empty packet into a new function
>> igc_insert_empty_packet(). This change extracts the logic for insert
tly in sending 1000 packets continuously.
Min delta: 08.410 us
Avr delta: 13.854 us
Max delta: 17.076 us
Total packets forwarded: 1000
Signed-off-by: Song Yoong Siang
Reviewed-by: Choong Yong Liang
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++
drivers/net/ethernet/stmicro/
tly in sending 1000 packets continuously.
Min delta: 0.005 us
Avr delta: 0.016 us
Max delta: 0.031 us
Total packets forwarded: 1000
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc.h | 1 +
drivers/net/ethernet/intel/igc/igc_main.c | 52
function.
This patch introduces no functional changes.
Signed-off-by: Song Yoong Siang
Reviewed-by: Faizal Rahim
---
drivers/net/ethernet/intel/igc/igc_main.c | 42 ---
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Signed-off-by: Song Yoong Siang
Acked-by: Stanislav Fomichev
028.852006-1-yoong.siang.s...@intel.com/
Song Yoong Siang (5):
xsk: Add launch time hardware offload support to XDP Tx metadata
selftests/bpf: Add launch time request to xdp_hw_metadata
net: stmmac: Add launch time support to XDP ZC
igc: Refactor empty packet insertion into a reusable funct
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
Acked-by: Stanislav Fomichev
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h
kernel.org # 6.2+
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/net/ethernet/intel/igc/igc_main.c
index 56a35d58e7a6..7daa7f8f81ca 100644
--- a/drivers/net/ethe
On Tuesday, February 4, 2025 11:18 PM, Fijalkowski, Maciej
wrote:
>On Tue, Feb 04, 2025 at 03:49:32PM +0100, Song, Yoong Siang wrote:
[...]
>> With above, IMHO, we no need to clear igc_tx_buffer::type,
>> Are you agree?
>
>Yes, the contract should be that every
On Tuesday, February 4, 2025 10:04 PM, Fijalkowski, Maciej
wrote:
>On Tue, Feb 04, 2025 at 02:14:00PM +0100, Song, Yoong Siang wrote:
>> On Tuesday, February 4, 2025 6:10 PM, Fijalkowski,
>> Maciej wrote:
>> >On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang
On Tuesday, February 4, 2025 8:36 PM, Fijalkowski, Maciej
wrote:
>On Tue, Feb 04, 2025 at 12:07:21PM +0100, Song, Yoong Siang wrote:
[...]
>>
>> "insert an empty packet" is a launch time trick to send a packet in
>> next Qbv cycle. The design is, the driver w
On Tuesday, February 4, 2025 6:10 PM, Fijalkowski, Maciej
wrote:
>On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang wrote:
>
>> Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx
>> metadata framework.
>>
>> This patch has been tested wi
On Tuesday, February 4, 2025 5:50 PM, Fijalkowski, Maciej
wrote:
>On Tue, Feb 04, 2025 at 08:49:06AM +0800, Song Yoong Siang wrote:
>> Refactor the code for inserting an empty packet into a new function
>> igc_insert_empty_packet(). This change extracts the logic for inserting
>
function.
This patch introduces no functional changes.
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 42 ---
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/net/ethernet/intel
tly in sending 1000 packets continuously.
Min delta: 0.005 us
Avr delta: 0.016 us
Max delta: 0.031 us
Total packets forwarded: 1000
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 42 +--
1 file changed, 40 insertions(+), 2 deletions(-)
tly in sending 1000 packets continuously.
Min delta: 08.410 us
Avr delta: 13.854 us
Max delta: 17.076 us
Total packets forwarded: 1000
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++
drivers/net/ethernet/stmicro/stmmac/stmmac_main.
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Signed-off-by: Song Yoong Siang
Acked-by: Stanislav Fomichev
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
Acked-by: Stanislav Fomichev
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h
s://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/
Song Yoong Siang (5):
xsk: Add launch time hardware offload support to XDP Tx metadata
selftests/bpf: Add launch time request to xdp_hw_metadata
net: stmmac: Add launch time support to XDP ZC
igc: Refactor emp
d xdp_hw_metadata prints:
> found skb hwtstamp = 1736509937.852786132
>
>Fixes: 069b142f5819 ("igc: Add support for PTP .getcyclesx64()")
>Signed-off-by: Zdenek Bouska
This patch LGTM and tested working on my side with xdp_hw_metadata
self-test app on XDP_PASS scenario.
Thanks for the patch.
Reviewed-by: Song Yoong Siang
On Thursday, January 23, 2025 11:40 PM, Bouska, Zdenek
wrote:
>
>Hi Siang,
>
>I tested this patch series on 6.13 with Intel I226-LM (rev 04).
>
>I also applied patch "selftests/bpf: Actuate tx_metadata_len in
>xdp_hw_metadata" [1]
>and "selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata" [2] s
On Monday, January 20, 2025 3:25 PM, Choong Yong Liang
wrote:
>On 20/1/2025 2:25 pm, Abdul Rahim, Faizal wrote:
>>
>> To be cautious, could we perform a stress test by sending a higher number
>> of packets with launch time? For example, we could send 200 packets, each
>> configured with a launch
On Monday, January 20, 2025 2:26 PM, Abdul Rahim, Faizal
wrote:
>Hi Siang.
>
>On 16/1/2025 11:53 pm, Song Yoong Siang wrote:
>> Enable Launch Time Control (LTC) support to XDP zero copy via XDP Tx
>> metadata framework.
>>
>> This patch is tested with tools/test
sec:1734578015.4677) delta to User
TX-complete-time sec:0. (29.768 usec)
HW RX-time: 1734578015467548904 (sec:1734578015.4675) delta to HW
TX-complete-time sec:1. (100.016 usec)
0x562ff5dc8880: complete rx idx=132 addr=84110
Signed-off-by: Song Yoong Siang
---
drivers/net/ether
680) delta to User
TX-complete-time sec:0. (999860.245 usec)
HW RX-time: 1734579065767717328 (sec:1734579065.7677) delta to HW
TX-complete-time sec:1. (116.963 usec)
0x55b5864717a8: complete rx idx=132 addr=88100
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/stmi
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Signed-off-by: Song Yoong Siang
---
tools/testing/selftests/bpf/xdp
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
Acked-by: Stanislav Fomichev
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h
/
v5:
https://patchwork.kernel.org/project/netdevbpf/cover/20250114152718.120588-1-yoong.siang.s...@intel.com/
Song Yoong Siang (4):
xsk: Add launch time hardware offload support to XDP Tx metadata
selftests/bpf: Add launch time request to xdp_hw_metadata
net: stmmac: Add launch time suppo
On Wednesday, January 15, 2025 10:57 PM, Daniel Borkmann
wrote:
>On 1/14/25 4:27 PM, Song Yoong Siang wrote:
>[...]
>> +/* Add mqprio qdisc with TC and hardware queue one-to-one mapping */
>> +char map[256] = {0};
>> +char queues[256] = {0};
>> +
sec:1734578015.4677) delta to User
TX-complete-time sec:0. (29.768 usec)
HW RX-time: 1734578015467548904 (sec:1734578015.4675) delta to HW
TX-complete-time sec:1. (100.016 usec)
0x562ff5dc8880: complete rx idx=132 addr=84110
Signed-off-by: Song Yoong Siang
---
drivers/net/ether
aunch time
hardware offload feature will be enabled and requested. Additionally, users
can configure the Tx Queue to be enabled with the launch time hardware
offload using the "-L" argument. By default, Tx Queue 0 will be used.
Signed-off-by: Song Yoong Siang
---
tools/testing/selftests/bpf/xdp
680) delta to User
TX-complete-time sec:0. (999860.245 usec)
HW RX-time: 1734579065767717328 (sec:1734579065.7677) delta to HW
TX-complete-time sec:1. (116.963 usec)
0x55b5864717a8: complete rx idx=132 addr=88100
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/stmi
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 62
include/net/xdp_sock.h | 10
include/net
devbpf/cover/20231203165129.1740512-1-yoong.siang.s...@intel.com/
v4:
https://patchwork.kernel.org/project/netdevbpf/cover/20250106135506.9687-1-yoong.siang.s...@intel.com/
Song Yoong Siang (4):
xsk: Add launch time hardware offload support to XDP Tx metadata
selftests/bpf: Add launch time request to xdp_hw_me
On Wednesday, January 8, 2025 12:50 AM, Stanislav Fomichev
wrote:
>On 01/06, Song Yoong Siang wrote:
>> Extend the XDP Tx metadata framework so that user can requests launch time
>> hardware offload, where the Ethernet device will schedule the packet for
>> transmission at
On Wednesday, January 8, 2025 12:58 AM, Stanislav Fomichev
wrote:
>On 01/06, Song Yoong Siang wrote:
>> Add Launch Time hw offload request to xdp_hw_metadata. User can configure
>> the delta of launch time to HW RX-time by using "-l" argument. The default
>>
On Wednesday, January 8, 2025 1:08 AM, Stanislav Fomichev
wrote:
>On 01/06, Song Yoong Siang wrote:
>> Enable launch time (Time-Based Scheduling) support to XDP zero copy via XDP
>> Tx metadata framework.
>>
>> This patch is tested with tools/testing/selftests/bpf/
000 (100.016 usec)
0x562ff5dc8880: complete rx idx=132 addr=84110
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_main.c | 78 ---
1 file changed, 56 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/
ime: 1734579065768004454 (sec:1734579065.7680) delta to User
TX-complete-time sec:0. (999860.245 usec)
HW RX-time: 1734579065767717328 (sec:1734579065.7677) delta to HW
TX-complete-time sec:1. (116.963 usec)
0x55b5864717a8: complete rx idx=132 addr=88100
Signed-off-by: Song Yoong Si
Add Launch Time hw offload request to xdp_hw_metadata. User can configure
the delta of launch time to HW RX-time by using "-l" argument. The default
delta is 100,000,000 nanosecond.
Signed-off-by: Song Yoong Siang
---
tools/testing/selftests/bpf/xdp_hw_metadata.c | 30
field of struct xsk_tx_metadata.
Suggested-by: Stanislav Fomichev
Signed-off-by: Song Yoong Siang
---
Documentation/netlink/specs/netdev.yaml | 4 ++
Documentation/networking/xsk-tx-metadata.rst | 64
include/net/xdp_sock.h | 10 +++
include/net
.org/project/netdevbpf/cover/20231130162028.852006-1-yoong.siang.s...@intel.com/
v2:
https://patchwork.kernel.org/project/netdevbpf/cover/20231201062421.1074768-1-yoong.siang.s...@intel.com/
v3:
https://patchwork.kernel.org/project/netdevbpf/cover/20231203165129.1740512-1-yoong.siang.s...@intel.com/
On Friday, December 13, 2024 4:10 PM, Paul Menzel wrote:
>Dear Song,
>
>
>Thank you for your patch. Maybe for the summary/title you could be more
>specific:
>
>igc: Avoid unnecessary link down event in XDP_SETUP_PROG process
>
>
>Am 11.12.24 um 14:45 schrie
(120.771 usec)
0x55881c7ef7a8: complete rx idx=10127 addr=8f110
Signed-off-by: Song Yoong Siang
---
V2:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20241211134532.3489335-1-yoong.siang.s...@intel.com/
V1:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20241204120
On Thursday, December 12, 2024 10:09 PM, Fijalkowski, Maciej wrote:
>On Wed, Dec 11, 2024 at 09:45:32PM +0800, Song Yoong Siang wrote:
>> Improve XDP_SETUP_PROG process by avoiding unnecessary link down event.
>>
[...]
>
>I agree we could do better than igc_close/igc_op
ime: 1733923136269482482 (sec:1733923136.2695) delta to User
TX-complete-time sec:0.0002 (217.726 usec)
HW RX-time: 1733923136269470866 (sec:1733923136.2695) delta to HW
TX-complete-time sec:0.0001 (120.771 usec)
0x55881c7ef7a8: complete rx idx=10127 addr=8f110
Signed-off-by: Song Yoong Siang
---
V2 change
On Thursday, December 5, 2024 8:38 AM, Gomes, Vinicius
wrote:
>Song Yoong Siang writes:
>
>> Improve XDP_SETUP_PROG process by avoiding unnecessary link down/up event
>> and hardware device reset.
>>
>
>Some examples of problems that these hardware resets are c
Improve XDP_SETUP_PROG process by avoiding unnecessary link down/up event
and hardware device reset.
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc.h | 2 +
drivers/net/ethernet/intel/igc/igc_main.c | 138 ++
drivers/net/ethernet/intel/igc
interface, allowing for seamless hot-swapping of
XDP programs.
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/igc_xdp.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_xdp.c
b/drivers/net/ethernet/intel/igc/igc_xdp.c
index
On Tuesday, July 30, 2024 9:20 PM, Marcin Szycik
wrote:
>On 30.07.2024 03:23, Song Yoong Siang wrote:
>> From: Blanco Alcaine Hector
>>
>> This commit introduces the support to configure default Rx queue during
>
>Use imperative mood.
>
Hi Marcin Szycik,
Thanks
On Tuesday, July 30, 2024 6:09 PM, Drewek, Wojciech
wrote:
[...]
>> +if (mrqe != IGC_MRQC_ENABLE_MQ && mrqe !=
>IGC_MRQC_ENABLE_RSS_MQ)
>> +return false;
>
>just:
>return mrqe != IGC_MRQC_ENABLE_MQ && mrqe != IGC_MRQC_ENABLE_RSS_MQ
>
Hi Drewek Wojciech,
Thanks for your review c
On Tuesday, July 30, 2024 5:59 PM, Kurt Kanzenbach wrote:
>> --- a/drivers/net/ethernet/intel/igc/igc_regs.h
>> +++ b/drivers/net/ethernet/intel/igc/igc_regs.h
>> @@ -63,6 +63,12 @@
>> /* RSS registers */
>> #define IGC_MRQC0x05818 /* Multiple Receive Control - RW */
>>
>> +/* MRQC r
On Thursday, August 1, 2024 7:53 AM, Jakub Kicinski wrote:
>On Wed, 31 Jul 2024 09:41:16 -0700 Jacob Keller wrote:
>> In this case, (I haven't dug into the actual patches or code), I suspect
>> the driver will need to validate the location values when adding rules
>> to ensure that all rules which
On Tuesday, July 30, 2024 10:55 PM, Jakub Kicinski wrote:
>On Tue, 30 Jul 2024 09:22:12 +0800 Song Yoong Siang wrote:
>> This patch set introduces the support to configure default Rx queue during
>runtime.
>> A new sysfs attribute "default_rx_queue" has been added, all
From: Blanco Alcaine Hector
Add description on default Rx Queue, including the get and set
method, into documentation.
Signed-off-by: Blanco Alcaine Hector
Signed-off-by: Song Yoong Siang
---
.../device_drivers/ethernet/intel/igc.rst | 21 +++
1 file changed, 21
ue:
cat /sys/devices/pci:00/.../default_rx_queue
2. Command to set the default Rx queue to a desired value, for example 3:
echo 3 > /sys/devices/pci:00/.../default_rx_queue
Signed-off-by: Blanco Alcaine Hector
Signed-off-by: Song Yoong Siang
---
drivers/net/ethernet/intel/igc/Make
information on how to identify the adapter, use
command line parameters, configure additional features, and obtain support.
Signed-off-by: Blanco Alcaine Hector
Signed-off-by: Song Yoong Siang
---
.../device_drivers/ethernet/index.rst | 1 +
.../device_drivers/ethernet/intel/igc.rst
This patch set introduces the support to configure default Rx queue during
runtime.
A new sysfs attribute "default_rx_queue" has been added, allowing users to check
and modify the default Rx queue.
This patch set is tested on two back-to-back connected i226 on Intel ADL-S
systems.
Test Steps an
On Wednesday, March 27, 2024 7:21 PM, Florian Bezdeka
wrote:
>On Tue, 2024-03-26 at 14:55 +0000, Song, Yoong Siang wrote:
>> On Tuesday, March 26, 2024 9:08 PM, Kurt Kanzenbach
>> wrote:
>> > Hi Florian,
>> >
>> > On Tue Mar 26 2024, Florian Bezdeka
On Tuesday, March 26, 2024 9:08 PM, Kurt Kanzenbach wrote:
>Hi Florian,
>
>On Tue Mar 26 2024, Florian Bezdeka wrote:
>> On Mon, 2024-03-25 at 10:09 +0800, Song Yoong Siang wrote:
>>> This patch adds support to per-packet Tx hardware timestamp request to
>>> A
On Tuesday, March 26, 2024 10:29 AM, Gomes, Vinicius
wrote:
>Song Yoong Siang writes:
>
>> This patch adds support to per-packet Tx hardware timestamp request to
>> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
>> user needs to enable Tx HW
Retr
[ 5] 0.00-10.00 sec 2.74 GBytes 2.36 Gbits/sec0 sender
[ 5] 0.00-10.04 sec 2.74 GBytes 2.34 Gbits/sec receiver
Co-developed-by: Lai Peter Jun Ann
Signed-off-by: Lai Peter Jun Ann
Signed-off-by: Song Yoong Siang
Acked-by: John Fastabend
On Thursday, March 7, 2024 9:39 PM, Kurt Kanzenbach wrote:
>Hi Maciej,
>
>On Wed Mar 06 2024, Maciej Fijalkowski wrote:
>> On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote:
>>> - tstamp->skb = NULL;
>>> + /* Copy the tx hardware timestamp in
xsk_tx_metadata_complete().
Co-developed-by: Lai Peter Jun Ann
Signed-off-by: Lai Peter Jun Ann
Signed-off-by: Song Yoong Siang
Acked-by: John Fastabend
---
drivers/net/ethernet/intel/igc/igc.h | 71 --
drivers/net/ethernet/intel/igc/igc_main.c | 113 --
drivers/net/ethernet
1 - 100 of 110 matches
Mail list logo
