Re: [Intel-wired-lan] [PATCH v4 iwl-next 5/6] ice: factor out ice_ptp_rebuild_owner()

2023-12-21 Thread Sokolowski, Jan
>From: Jacob Keller > >The ice_ptp_reset() function uses a goto to skip past clock owner >operations if performing a PF reset or if the device is not the clock >owner. This is a bit confusing. Factor this out into >ice_ptp_rebuild_owner() instead. To me at least, the wording of the title (Factor

Re: [Intel-wired-lan] [net PATCH] i40e: fix use-after-free in i40e_aqc_add_filters()

2023-12-13 Thread Sokolowski, Jan
>Commit 3116f59c12bd ("i40e: fix use-after-free in >i40e_sync_filters_subtask()") avoided use-after-free issues, >by increasing refcount during update the VSI filter list to >the HW. However, it missed the unicast situation. > >When deleting an unicast FDB entry, the i40e driver will release >the m

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic

2023-11-29 Thread Sokolowski, Jan
> >On 11/20/2023 3:27 AM, Jan Sokolowski wrote: >> It was found that this statistic is incorrectly reported >> by HW and thus, useless. >> >> Remove it. > >Is there any further information about what is reported incorrectly? Is >rx_length_errors part of netdev stats and standardized? Does HW fail