Re: [Intel-wired-lan] [PATCH v3 2/2] e1000e: ignore factory-default checksum value on TGP platform

2025-06-25 Thread Ruinskiy, Dima
On 25/06/2025 20:00, Simon Horman wrote: On Wed, Jun 25, 2025 at 05:06:44PM +0300, Vlad URSU wrote: On 25.06.2025 16:05, Jacek Kowalski wrote: +#define NVM_CHECKSUM_FACTORY_DEFAULT 0x Perhaps it is too long, but I liked Vlad's suggestion of naming this NVM_CHECKSUM_WORD_FACTORY_DEFAULT.

Re: [Intel-wired-lan] igc: Multiple failed link-ups on boot

2025-05-26 Thread Ruinskiy, Dima
On 22/05/2025 10:21, Mateusz Kusiak wrote: Hello, I was wondering I could get some help understanding the igc/i225 combo. The issue I'm having is during boot-time, the i225 fails to establish link multiple times and it takes a long time (2.5s) for successful link up. I know this because I enab

Re: [Intel-wired-lan] [PATCH iwl-next v1 1/8] igc: move IGC_TXDCTL_QUEUE_ENABLE and IGC_TXDCTL_SWFLUSH

2025-04-28 Thread Ruinskiy, Dima
On 28/04/2025 9:02, Faizal Rahim wrote: Consolidate TXDCTL-related macros for better organization and readability. Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc.h | 6 ++ drivers/net/ethernet/intel/igc/igc_base.h | 4 2 files changed, 6 insertions(+), 4 de

Re: [Intel-wired-lan] [PATCH iwl-next v1 2/8] igc: add TXDCTL prefix to related macros

2025-04-27 Thread Ruinskiy, Dima
On 28/04/2025 9:02, Faizal Rahim wrote: Rename macros to include the TXDCTL_ prefix for consistency and clarity. This aligns naming with the register they configure and improves code readability. Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc.h | 6 +++--- drivers/ne

Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations problem

2024-05-09 Thread Ruinskiy, Dima
On 08/05/2024 8:05, Sasha Neftin wrote: On 07/05/2024 15:31, Andrew Lunn wrote: On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote: As described in https://bugzilla.kernel.org/show_bug.cgi?id=218642, Intel I219-LM reports link up -> link down -> link up after hot-plugging the Ethernet cab

Re: [Intel-wired-lan] [PATCH v2 1/2] e1000e: let the sleep codes run every time

2024-05-06 Thread Ruinskiy, Dima
On 06/05/2024 19:46, En-Wei WU wrote: Thank you for your time. Originally, sleep codes would only be executed if the first read fails or the link status that is read is down. Some circumstances like the [v2,2/2] "e1000e: fix link fluctuations problem" would need a delay before first reading/acce

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change usleep_range to udelay in PHY mdic access

2024-04-23 Thread Ruinskiy, Dima
On 17/04/2024 22:03, Lifshits, Vitaly wrote: This is a partial revert of commit 6dbdd4de0362 ("e1000e: Workaround for sporadic MDI error on Meteor Lake systems"). The referenced commit introduced an issue on vPro systems, where disconnecting and reconnecting the LAN cable might result in a kernel