Re: [Intel-wired-lan] [PATCH net-next 20/24] net: intel: Use nested-BH locking for XDP redirect.

2023-12-19 Thread Nick Desaulniers
utput): > > https://godbolt.org/z/9bvGboxvc > > While there is a warning from GCC in that example, I don't see one in > the kernel's case. I see there is an open GCC issue around this problem: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91951 > > While it is possible that there may not actually be a problem with how > the kernel uses __attribute__((__cleanup__(...))) and gotos, I think > clang's behavior is reasonable given the potential footguns that this > construct has. > > Cheers, > Nathan > -- Thanks, ~Nick Desaulniers ___ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

2023-12-19 Thread Nick Desaulniers
till get nightmares frome: - commit e7140639b1de ("powerpc/xmon: Fix opcode being uninitialized in print_insn_powerpc") - commit f7019b7b0ad1 ("xsk: Properly terminate assignment in xskq_produce_flush_desc") -- Thanks, ~Nick Desaulniers ___

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

2023-12-18 Thread Nick Desaulniers
On Mon, Dec 18, 2023 at 11:00 AM Nathan Chancellor wrote: > > On Mon, Dec 18, 2023 at 08:32:28AM -0800, Nick Desaulniers wrote: > > (Is -Wcomma enabled by -Wall?) > > No and last time that I looked into enabling it, there were a lot of > instances in the kernel: > &

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

2023-12-18 Thread Nick Desaulniers
le is why I hate the comma operator! Reviewed-by: Nick Desaulniers (Is -Wcomma enabled by -Wall?) Is there a fixes tag we can add? > > No functional change intended. > Compile tested only. > > Signed-off-by: Simon Horman > --- > drivers/net/ethernet/intel/i40e/i40e_ethtoo