Re: [Intel-wired-lan] [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Nelson, Shannon
On 10/30/2024 5:23 PM, Caleb Sander Mateos wrote: net_dim() is currently passed a struct dim_sample argument by value. struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 passes it on the stack. All callers have already initialized dim_sample on the stack, so passing it by valu

Re: [Intel-wired-lan] [PATCH] e1000e: makes e1000_watchdog_task use queue_delayed_work

2024-09-17 Thread Nelson, Shannon
On 9/15/2024 12:03 AM, Dmitrii Ermakov wrote: Replaces watchdog timer with delayed_work as advised in the driver's TODO comment. Signed-off-by: Dmitrii Ermakov The Subject should identify which tree to go to, net or net-next. This should be for net-next, e.g. [PATCH net-next]. But be awa

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: extend tx watchdog timeout

2024-06-03 Thread Nelson, Shannon
On 6/3/2024 11:47 AM, Joshua Hay wrote: There are several reasons for a TX completion to take longer than usual to be written back by HW. For example, the completion for a packet that misses a rule will have increased latency. The side effect of these variable latencies for any given packet is o

Re: [Intel-wired-lan] [PATCH v2 iwl-net 0/8] ice: fix AF_XDP ZC timeout and concurrency issues

2024-05-31 Thread Nelson, Shannon
On 5/29/2024 4:23 AM, Maciej Fijalkowski wrote: Hi, changes included in this patchset address an issue that customer has been facing when AF_XDP ZC Tx sockets were used in combination with flow control and regular Tx traffic. After executing: ethtool --set-priv-flags $dev link-down-on-close on

Re: [Intel-wired-lan] [PATCH v2 iwl-net 6/8] ice: improve updating ice_{t, r}x_ring::xsk_pool

2024-05-31 Thread Nelson, Shannon
On 5/29/2024 4:23 AM, Maciej Fijalkowski wrote: xsk_buff_pool pointers that ice ring structs hold are updated via ndo_bpf that is executed in process context while it can be read by remote CPU at the same time within NAPI poll. Use synchronize_net() after pointer update and {READ,WRITE}_ONCE() w

Re: [Intel-wired-lan] [PATCH v2 iwl-net 3/8] ice: replace synchronize_rcu with synchronize_net

2024-05-31 Thread Nelson, Shannon
On 5/29/2024 4:23 AM, Maciej Fijalkowski wrote: Given that ice_qp_dis() is called under rtnl_lock, synchronize_net() can be called instead of synchronize_rcu() so that XDP rings can finish its job in a faster way. Also let us do this as earlier in XSK queue disable flow. Additionally, turn off

Re: [Intel-wired-lan] [PATCH iwl-net] ixgbe: avoid sleeping allocation in ixgbe_ipsec_vf_add_sa()

2024-03-05 Thread Nelson, Shannon
On 3/5/2024 8:02 AM, Przemek Kitszel wrote: Change kzalloc() flags used in ixgbe_ipsec_vf_add_sa() to GFP_ATOMIC, to avoid sleeping in IRQ context. Dan Carpenter, with the help of Smatch, has found following issue: The patch eda0333ac293: "ixgbe: add VF IPsec management" from Aug 13, 2018 (linux

Re: [Intel-wired-lan] [bug report] ixgbe: add VF IPsec management

2024-02-14 Thread Nelson, Shannon
On 2/14/2024 5:58 AM, Przemek Kitszel wrote: On 2/9/24 18:57, Nelson, Shannon wrote: On 2/9/2024 4:59 AM, Dan Carpenter wrote: Hello Shannon Nelson, The patch eda0333ac293: "ixgbe: add VF IPsec management" from Aug 13, 2018 (linux-next), leads to the following Smatch static check

Re: [Intel-wired-lan] [bug report] ixgbe: add VF IPsec management

2024-02-09 Thread Nelson, Shannon
On 2/9/2024 4:59 AM, Dan Carpenter wrote: Hello Shannon Nelson, The patch eda0333ac293: "ixgbe: add VF IPsec management" from Aug 13, 2018 (linux-next), leads to the following Smatch static checker warning: drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c:917 ixgbe_ipsec_vf_add_sa()

Re: [Intel-wired-lan] [PATCH v5 iwl-next] i40e: Use correct buffer size in i40e_dbg_command_read

2023-12-19 Thread Nelson, Shannon
On 12/17/2023 9:54 PM, Pucha, HimasekharX Reddy wrote: -Original Message- From: Intel-wired-lan On Behalf Of Kunwu Chan Sent: Friday, December 8, 2023 8:50 AM To: Brandeburg, Jesse ; Nguyen, Anthony L ; da...@davemloft.net; eduma...@google.com; k...@kernel.org; pab...@redhat.com; je

Re: [Intel-wired-lan] [PATCH 2/3] treewide: Convert some ethtool_sprintf() to ethtool_puts()

2023-10-26 Thread Nelson, Shannon
On 10/25/2023 4:40 PM, Justin Stitt wrote: This patch converts some basic cases of ethtool_sprintf() to ethtool_puts(). The conversions are used in cases where ethtool_sprintf() was being used with just two arguments: | ethtool_sprintf(&data, buffer[i].name); or when it's used with format