Re: [Intel-wired-lan] [PATCH v2 1/1] igb: Do not bring the device up after non-fatal error

2024-09-30 Thread Mohamed Khalfella
On 2024-09-28 14:40:05 +, Pucha, HimasekharX Reddy wrote: > >-Original Message- > >From: Intel-wired-lan On Behalf Of > >Mohamed Khalfella > > Sent: Wednesday, September 25, 2024 2:36 AM > > To: Nguyen, Anthony L ; Kitszel, Przemyslaw > > ;

Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
On 2024-09-23 17:10:36 -0700, Jacob Keller wrote: > > > On 9/23/2024 4:11 PM, Jacob Keller wrote: > > > > > > On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: > >> Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") > >> c

[Intel-wired-lan] [PATCH v2 1/1] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
the device down and there is no need to bring it up. Signed-off-by: Mohamed Khalfella Reviewed-by: Yuanyuan Zhong Fixes: 004d25060c78 ("igb: Fix igb_down hung on surprise removal") --- drivers/net/ethernet/intel/igb/igb_main.c | 4 1 file changed, 4 insertions(+) diff --git a/driver

[Intel-wired-lan] [PATCH v2 0/1] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
Changes: - Changed dev_info() to dev_dbg() as suggested. v1: https://lore.kernel.org/all/20240923212218.116979-1-mkhalfe...@purestorage.com/ Mohamed Khalfella (1): igb: Do not bring the device up after non-fatal error drivers/net/ethernet/intel/igb/igb_main.c | 4 1 file changed, 4

Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
On 2024-09-23 16:11:14 -0700, Jacob Keller wrote: > > > On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: > > Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") > > changed igb_io_error_detected() to ignore non-fatal pcie errors in order > > to

[Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-24 Thread Mohamed Khalfella
the device down and there is no need to bring it up. Signed-off-by: Mohamed Khalfella Reviewed-by: Yuanyuan Zhong Fixes: 004d25060c78 ("igb: Fix igb_down hung on surprise removal") --- drivers/net/ethernet/intel/igb/igb_main.c | 4 1 file changed, 4 insertions(+) diff --git a/driver