hard rule against it, so
be it.
There is a possibility for a future cleanup, outside of the scope of
the current fix: idpf_set_real_num_queues() can be replaced with just
a call to netif_set_real_num_queues().
I know Jordan tested the patch with success and he agrees to being
mentioned, so you can add:
Reviewed-by: Michal Schmidt
Tested-by: Jordan Rhee
On Mon, Dec 16, 2024 at 6:39 AM Przemek Kitszel
wrote:
> On 12/12/24 16:34, Michal Schmidt wrote:
> > The E810 is connected to the u-blox GNSS module over I2C. The ice driver
> > periodically (every ~20ms) sends AdminQ commands to poll the u-blox for
> > available data. Most
This improves the reading of GNSS data. The main change is the lower
latency for received GNSS messages, which helps ts2phc do its job.
Michal Schmidt (3):
ice: downgrade warning about gnss_insert_raw to debug level
ice: lower the latency of GNSS reads
ice: remove special delay after
gnss_insert_raw() will reject the GNSS data the ice driver produces
whenever userspace has the gnss device open, but is not reading it fast
enough for whatever reason.
Do not spam kernel logs just because userspace misbehaves.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice
I do not see a reason to have a special longer delay (100 ms) after
passing read GNSS data to userspace.
Just use the regular GNSS polling interval (20 ms).
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_gnss.c | 5 ++---
drivers/net/ethernet/intel/ice/ice_gnss.h | 1 -
2
.
Improve the NMEA message receiving latency. Pass each 15-bytes chunk to
userspace as soon as it's received.
Tested-by: Miroslav Lichvar
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_gnss.c | 29 +++
drivers/net/ethernet/intel/ice/ice_gnss.h | 6
On Fri, Dec 6, 2024 at 4:41 PM Romanowski, Rafal
wrote:
> From: Intel-wired-lan on behalf of
> Aleksandr Loktionov
> Sent: Friday, November 15, 2024 8:42 PM
> To: intel-wired-...@lists.osuosl.org ;
> Nguyen, Anthony L ; Loktionov, Aleksandr
>
> Cc: net...@vger.kernel.org ; Sokolowski, Jan
>
->pdev->dev, is_tx ?
> + "%lld Tx Malicious Driver Detection events detected on PF %d
> VF %d MAC %pm. mdd-auto-reset-vfs=%s\n" :
> + "%lld Rx Malicious Driver Detection events detected on PF %d
> VF %d MAC %pm. mdd
On Mon, Nov 4, 2024 at 1:13 PM Michal Swiatkowski
wrote:
>
> Use generic devlink PF MSI-X parameter to allow user to change MSI-X
> range.
>
> Add notes about this parameters into ice devlink documentation.
>
> Signed-off-by: Michal Swiatkowski
> ---
> Documentation/networking/devlink/ice.rst
On Mon, Nov 4, 2024 at 4:40 PM Michal Schmidt wrote:
>
> On Tue, Oct 29, 2024 at 1:36 PM Aleksandr Loktionov
> wrote:
[...]
> > +
> > + i40e_vc_reset_vf(vf, true);
> > }
> > }
> >
> > /* re-enable
On Tue, Oct 29, 2024 at 1:36 PM Aleksandr Loktionov
wrote:
> Implement "mdd-auto-reset-vf" priv-flag to handle Tx and Rx MDD events for
> VFs.
> This flag is also used in other network adapters like ICE.
>
> Usage:
> - "on" - The problematic VF will be automatically reset
> if a malfor
On Mon, Oct 28, 2024 at 11:04 AM Michal Swiatkowski
wrote:
>
> Use generic devlink PF MSI-X parameter to allow user to change MSI-X
> range.
>
> Add notes about this parameters into ice devlink documentation.
>
> Reviewed-by: Wojciech Drewek
> Signed-off-by: Michal Swiatkowski
> ---
> Documenta
On Mon, Oct 28, 2024 at 11:04 AM Michal Swiatkowski
wrote:
>
> Use generic devlink PF MSI-X parameter to allow user to change MSI-X
> range.
>
> Add notes about this parameters into ice devlink documentation.
>
> Reviewed-by: Wojciech Drewek
> Signed-off-by: Michal Swiatkowski
> ---
> Documenta
lters in a hash with the MAC
> Address as key")
> Signed-off-by: Aleksandr Loktionov
Reviewed-by: Michal Schmidt
Tested-by: Michal Schmidt
Michal
On Wed, Oct 16, 2024 at 11:30 AM Aleksandr Loktionov
wrote:
>
> Fix a race condition in the i40e driver that leads to MAC/VLAN filters
> becoming corrupted and leaking. Address the issue that occurs under
> heavy load when multiple threads are concurrently modifying MAC/VLAN
> filters by setting m
On Thu, Oct 3, 2024 at 11:26 AM Arkadiusz Kubalewski
wrote:
>
> The E810 Lan On Motherboard (LOM) design is vendor specific. Intel
> provides the reference design, but it is up to vendor on the final
> product design. For some cases, like Linux DPLL support, the static
> values defined in the driv
vers/net/ethernet/intel/ice/ice_switch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c
> b/drivers/net/ethernet/intel/ice/ice_switch.c
> index fe8847184cb1..0160f0bae8d6 100644
Reviewed-by: Michal Schmidt
other caller of ice_find_vsi_list_entry. I don't have a
LAG-capable card at hand to test.
Fixes: 23ccae5ce15f ("ice: changes to the interface with the HW and FW for
SRIOV_VF+LAG")
Reviewed-by: Michal Swiatkowski
Signed-off-by: Michal Schmidt
---
v2: Corrected the Fixes commit ID
On Fri, Aug 30, 2024 at 9:28 PM Aleksandr Loktionov
wrote:
>
> In cases when vf sends malformed packets that are classified as
> malicious, sometimes it causes tx queue to freeze. This frozen queue can be
> stuck for several minutes being unusable. When mdd event occurs, there is a
> posibility to
er of ice_find_vsi_list_entry. I don't have a
LAG-capable card at hand to test.
Fixes: 25746e4f06a5 ("ice: changes to the interface with the HW and FW for
SRIOV_VF+LAG")
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
n from Kuba:
> https://lore.kernel.org/netdev/20240610194756.5be5b...@kernel.org/
> Previous attempt (dropped because it introduced regression with link up):
> https://lore.kernel.org/netdev/20240722122839.51342-1-dawid.osuchow...@linux.intel.com/
This v5 passes the tests that the previous attempt referenced above failed.
The patch looks sane.
Reviewed-by: Michal Schmidt
On Mon, Jul 22, 2024 at 2:30 PM Dawid Osuchowski
wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index ec636be4d17d..eb199fd3c989 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_mai
On Fri, Jun 21, 2024 at 10:44 AM Sergey Temerkhanov
wrote:
> This series replaces multiple aux buses and devices used in
> the PTP support code with struct ice_adapter holding the necessary
> shared data
>
> Patches 1,2 add convenience wrappers
> Patch 3 does the main refactoring
> Patch 4 finaliz
On Tue, Jun 18, 2024 at 3:59 PM Sergey Temerkhanov
wrote:
> - Use struct ice_adapter to hold shared PTP data and control PTP
> related actions instead of auxbus. This allows significant code
> simplification and faster access to the container fields used in
> the PTP support code.
>
> - Move the P
On Tue, Jun 18, 2024 at 3:53 PM Sergey Temerkhanov
wrote:
> Add ice_get_ctrl_ptp() wrapper to simplify the PTP support code
> in the functions that do not use ctrl_pf directly
>
> Reviewed-by: Przemek Kitszel
> Signed-off-by: Sergey Temerkhanov
> ---
> drivers/net/ethernet/intel/ice/ice_ptp.c |
fies code a tiny bit.
>
> Reviewed-by: Wojciech Drewek
> Signed-off-by: Przemek Kitszel
> ---
> drivers/net/ethernet/intel/ice/ice_adapter.c | 60 +---
> 1 file changed, 28 insertions(+), 32 deletions(-)
Reviewed-by: Michal Schmidt
On Fri, May 24, 2024 at 11:04 PM Jacob Keller wrote:
> On 5/22/2024 4:12 PM, Michal Schmidt wrote:
> > irq_set_affinity_hint() is deprecated. Use irq_update_affinity_hint()
> > instead. This removes the side-effect of actually applying the affinity.
> >
> > The dri
all useful, because
irqbalance ignores them since 2016 ([1]), but at least it's harmless.
This ice change is similar to i40e commit d34c54d1739c ("i40e: Use
irq_update_affinity_hint()").
[1] https://github.com/Irqbalance/irqbalance/commit/dcc411e7bfdd
Signed-off-by: Michal
Fixes: 9b1aa3ef2328 ("idpf: add get/set for Ethtool's header split ringparam")
Reported-by: Xu Du
Closes: https://issues.redhat.com/browse/RHEL-36182
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ++-
1 file changed, 2 insertions(+), 1 de
This is a cleanup. It is unnecessary to have this function just to call
another function.
Reviewed-by: Przemek Kitszel
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 25 +++-
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a
ere is no tearing and the biggest delta I saw
was in the range [1M, 2M), that is under 2 ms.
Reviewed-by: Jacob Keller
Reviewed-by: Przemek Kitszel
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_adapter.c | 2 ++
drivers/net/ethernet/intel/ice/ice_adapter.h | 6 ++
d
ct it will be useful also to
improve the ugliness that is ice_prot_id_tbl.
Reviewed-by: Przemek Kitszel
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/Makefile | 3 +-
drivers/net/ethernet/intel/ice/ice.h | 2 +
drivers/net/ethernet/intel/ice/ice_adapt
ri Pirko)
- Patch 2: Do not use *_irqsave with ptp_gltsyn_time_lock, as it's used
only in process contexts.
Michal Schmidt (3):
ice: add ice_adapter for shared data across PFs on the same NIC
ice: avoid the PTP hardware semaphore in gettimex64 path
ice: fold ice_ptp_read_time into
l/i40e/i40e_txrx.h | 2 +-
> .../ethernet/intel/i40e/i40e_virtchnl_pf.c| 14 +-
> 10 files changed, 210 insertions(+), 152 deletions(-)
Series looks OK to me.
Reviewed-by: Michal Schmidt
tion = 195.841
> sockperf: ---> percentile 99.999 = 45.026
> sockperf: ---> percentile 99.990 = 39.009
> sockperf: ---> percentile 99.900 = 35.922
> sockperf: ---> percentile 99.000 = 33.482
> sockperf: ---> percentile 90.000 = 28.902
> sockperf: ---> percentile 75.000 = 27.821
> sockperf: ---> percentile 50.000 = 26.860
> sockperf: ---> percentile 25.000 = 25.685
> sockperf: ---> observation = 12.277
>
> Fixes: 0bcd952feec7 ("ethernet/intel: consolidate NAPI and NAPI exit")
> Reported-by: Hugo Ferreira
> Reviewed-by: Michal Schmidt
Yes, I am OK with v4.
Michal
> Signed-off-by: Ivan Vecera
ntile 75.000 = 27.821
> sockperf: ---> percentile 50.000 = 26.860
> sockperf: ---> percentile 25.000 = 25.685
> sockperf: ---> observation = 12.277
Those are the numbers from the original measurements, but I confirmed
with Ivan that he re-tested with v3 and the overall picture was the
same.
> Fixes: 0bcd952feec7 ("ethernet/intel: consolidate NAPI and NAPI exit")
> Reported-by: Hugo Ferreira
> Reviewed-by: Michal Schmidt
Yeah.
> Signed-off-by: Ivan Vecera
> ---
> Changes since v2
> - eliminated two writes in hot-path (thx Jesse)
I like this improvement.
Michal
eg_swint(I40E_SW_ITR);
> + }
> + wr32(hw, I40E_PFINT_DYN_CTLN(q_vector->reg_idx), intval);
> }
>
> /**
> @@ -2845,6 +2867,8 @@ int i40e_napi_poll(struct napi_struct *napi, int budget)
> */
> if (likely(napi_complete_done(napi, work_done)))
> i40e_update_enable_itr(vsi, q_vector);
> + else
> + q_vector->in_busy_poll = true;
>
> return min(work_done, budget - 1);
> }
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h
> b/drivers/net/ethernet/intel/i40e/i40e_txrx.h
> index abf15067eb5d..2cdc7de6301c 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h
> @@ -68,6 +68,7 @@ enum i40e_dyn_idx {
> /* these are indexes into ITRN registers */
> #define I40E_RX_ITRI40E_IDX_ITR0
> #define I40E_TX_ITRI40E_IDX_ITR1
> +#define I40E_SW_ITRI40E_IDX_ITR2
>
> /* Supported RSS offloads */
> #define I40E_DEFAULT_RSS_HENA ( \
> --
> 2.43.0
Reviewed-by: Michal Schmidt
continue;
> + }
>
> if (i40e_del_mac_filter(vsi, al->list[i].addr)) {
> ret = -EINVAL;
> --
> 2.43.0
Reviewed-by: Michal Schmidt
On Wed, Mar 13, 2024 at 1:55 PM Ivan Vecera wrote:
> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h
> b/drivers/net/ethernet/intel/i40e/i40e.h
> index 9b701615c7c6..4d2b05de6c63 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e.h
> @@ -908,6 +
On Fri, Mar 8, 2024 at 1:17 PM Przemek Kitszel
wrote:
> On 3/7/24 23:25, Michal Schmidt wrote:
> > There is a need for synchronization between ice PFs on the same physical
> > adapter.
> >
> > Add a "struct ice_adapter" for holding data shared between PFs of
On Fri, Mar 8, 2024 at 11:57 AM Marcin Szycik
wrote:
> On 07.03.2024 23:25, Michal Schmidt wrote:
> > There is a need for synchronization between ice PFs on the same physical
> > adapter.
> >
> > Add a "struct ice_adapter" for holding data shared between
This is a cleanup. It is unnecessary to have this function just to call
another function.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 25 +++-
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice
ere is no tearing and the biggest delta I saw
was in the range [1M, 2M), that is under 2 ms.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_adapter.c | 2 ++
drivers/net/ethernet/intel/ice/ice_adapter.h | 6 ++
drivers/net/ethernet/intel/ice/ice_ptp.c | 8 +---
d
ct it will be useful also to
improve the ugliness that is ice_prot_id_tbl.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/Makefile | 3 +-
drivers/net/ethernet/intel/ice/ice.h | 2 +
drivers/net/ethernet/intel/ice/ice_adapter.c | 107 +++
d
tsyn_time_lock, as it's used
only in process contexts.
Michal Schmidt (3):
ice: add ice_adapter for shared data across PFs on the same NIC
ice: avoid the PTP hardware semaphore in gettimex64 path
ice: fold ice_ptp_read_time into ice_ptp_gettimex64
drivers/net/ethernet/intel/ice/Makefile
ata shared between PFs of the
> >same multifunction PCI device. The struct is refcounted - each ice_pf
> >holds a reference to it.
> >
> >Its first use will be for PTP. I expect it will be useful also to
> >improve the ugliness that is ice_prot_id_tbl.
> >
> >Si
This is a cleanup. It is unnecessary to have this function just to call
another function.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 25 +++-
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice
ere is no tearing and the biggest delta I saw
was in the range [1M, 2M), that is under 2 ms.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_adapter.c | 2 ++
drivers/net/ethernet/intel/ice/ice_adapter.h | 6 ++
drivers/net/ethernet/intel/ice/ice_ptp.c | 8 +---
d
ct it will be useful also to
improve the ugliness that is ice_prot_id_tbl.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/Makefile | 3 +-
drivers/net/ethernet/intel/ice/ice.h | 2 +
drivers/net/ethernet/intel/ice/ice_adapter.c | 85
drivers/ne
1: Rely on xarray's own lock. (Suggested by Jiri Pirko)
- Patch 2: Do not use *_irqsave with ptp_gltsyn_time_lock, as it's used
only in process contexts.
Michal Schmidt (3):
ice: add ice_adapter for shared data across PFs on the same NIC
ice: avoid the PTP hardware semaphore in
ck+0x1a/0x60
---[ end trace ]---
Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu")
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_dpll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/int
The struct is refcounted - each ice_pf
holds a reference to it.
Its first use will be for PTP. I expect it will be useful also to
improve the ugliness that is ice_prot_id_tbl.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/Makefile | 3 +-
drivers/net/ethernet/intel
On Mon, Feb 26, 2024 at 8:36 PM Jacob Keller wrote:
> On 2/26/2024 7:11 AM, Michal Schmidt wrote:
> > The writing is performed indirectly, by the hardware, as a result of
> > the driver writing GLTSYN_CMD_SYNC in ice_ptp_exec_tmr_cmd. I wasn't
> > sure if the ice_flu
On Mon, Feb 26, 2024 at 8:17 PM Jacob Keller wrote:
> On 2/26/2024 7:11 AM, Michal Schmidt wrote:
> > This series removes the use of the heavy-weight PTP hardware semaphore
> > in the gettimex64 path. Instead, serialization of access to the time
> > register is done using
This is a cleanup. It is unnecessary to have this function just to call
another function.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 25 +++-
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice
.
With the spinlock added, there is no tearing and the biggest delta I saw
was in the range [1M, 2M), that is under 2 ms.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_adapter.c | 2 ++
drivers/net/ethernet/intel/ice/ice_adapter.h | 6 ++
drivers/net/ethernet/in
ct it will be useful also to
improve the ugliness that is ice_prot_id_tbl.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/Makefile | 3 +-
drivers/net/ethernet/intel/ice/ice.h | 2 +
drivers/net/ethernet/intel/ice/ice_adapter.c | 67
drivers/ne
instances too.
Michal Schmidt (3):
ice: add ice_adapter for shared data across PFs on the same NIC
ice: avoid the PTP hardware semaphore in gettimex64 path
ice: fold ice_ptp_read_time into ice_ptp_gettimex64
drivers/net/ethernet/intel/ice/Makefile | 3 +-
drivers/net/ethernet/intel/ice
On 1/31/24 17:59, Alexander Lobakin wrote:
From: Jiri Pirko
Date: Wed, 31 Jan 2024 13:17:44 +0100
Wed, Jan 31, 2024 at 12:58:23PM CET, mschm...@redhat.com wrote:
diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c
b/drivers/net/ethernet/intel/ice/ice_lag.c
index 2a25323105e5..d4848f6fe919
Memory Limit: none
[ 17.915268] ---[ end Kernel panic - not syncing: Oops: Fatal exception ]---
Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on
bonded interface")
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_lag.c | 4 +---
1 fi
to the
netdevs (e.g. "ens2f0", "ens2f0d1", "ens2f0d2", "ens2f0d3").
The Intel-provided out-of-tree idpf driver already sets dev_port. In
this patch I chose to do it in the same place in the idpf_cfg_netdev
function.
Fixes: 0fe45467a104 ("idpf: add c
On Mon, Dec 18, 2023 at 4:02 PM Arkadiusz Kubalewski
wrote:
>
> Stop dividing the phase_offset value received from firmware. This fault
> is present since the initial implementation.
> The phase_offset value received from firmware is in 0.01ps resolution.
> Dpll subsystem is using the value in 0.0
On Thu, Nov 2, 2023 at 4:56 PM Pawel Chmielewski
wrote:
> From: Liang-Min Wang
>
> In cases when VF sends malformed packets that are classified as malicious,
> sometimes it causes Tx queue to freeze. This frozen queue can be stuck
> for several minutes being unusable. This behavior can be reprodu
orts a
higher bit in phy_types_high, the driver would access memory beyond the
lookup table's end.
Instead of iterating through all 64 bits of phy_types_{low,high}, use
the sizes of the respective lookup tables.
Fixes: 9136e1f1e5c3 ("ice: refactor PHY type to ethtool link mode&q
86fb40 ("ice: update reset path for SRIOV LAG support")
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_lag.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c
b/drivers/net/ethernet/intel/ic
iavf_probe.
Queue the watchdog_task as the last step in iavf_probe. Add a comment to
prevent repeating the mistake.
Fixes: fe2647ab0c99 ("i40evf: prevent VF close returning before state
transitions to DOWN")
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_main.c |
On Wed, Oct 18, 2023 at 1:26 PM Drewek, Wojciech
wrote:
> > -Original Message-
> > From: Michal Schmidt
> > Sent: Wednesday, October 18, 2023 1:15 PM
> > To: intel-wired-...@lists.osuosl.org
> > Cc: Keller, Jacob E ; Drewek, Wojciech
> > ; Brand
in the future there's a need for the MAC type (or other PCI
ID-dependent data), I would prefer to use .driver_data in iavf_pci_tbl[]
for this purpose.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_common.c | 32 ---
drivers/net/ethernet/intel/iavf/iavf_m
Use unregister_netdev, which takes rtnl_lock for us. We don't have to
check the reg_state under rtnl_lock. There's nothing to race with. We
have just cancelled the finish_config work.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 4 +---
1 file
Add a new function iavf_free_interrupt_scheme that does the inverse of
iavf_init_interrupt_scheme. Symmetry is nice. And there will be three
callers already.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 26 -
1 file changed, 15 insertions
The information whether a netdev has been registered is already present
in the netdev itself. There's no need for a driver flag with the same
meaning.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf.h | 1 -
drivers/net/ethernet/intel/iavf/iavf_main.
better
solution.
Remove the iavf client interface code. Also gone are the client_task
work and the client_lock mutex.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/Makefile | 2 +-
drivers/net/ethernet/intel/iavf/iavf.h| 27 -
drivers/net/ethernet/intel/iav
The first 3 patches are quite simple cleanups.
Patch 4 removes the whole unused iavf client interface and the
supporting code.
Michal Schmidt (4):
iavf: rely on netdev's own registered state
iavf: use unregister_netdev
iavf: add a common function for undoing the interrupt scheme
Dne 10. 10. 23 v 13:39 Drewek, Wojciech napsal:
-Original Message-
From: Intel-wired-lan On Behalf Of
Michal Schmidt
Sent: Tuesday, October 10, 2023 2:25 AM
To: intel-wired-...@lists.osuosl.org
Cc: Nguyen, Anthony L ; Radoslaw Tyl
; Brandeburg, Jesse
Subject: [Intel-wired-lan
Dne 10. 10. 23 v 13:30 Drewek, Wojciech napsal:
-Original Message-
From: Intel-wired-lan On Behalf Of
Michal Schmidt
Sent: Tuesday, October 10, 2023 2:25 AM
To: intel-wired-...@lists.osuosl.org
Cc: Nguyen, Anthony L ; Radoslaw Tyl
; Brandeburg, Jesse
Subject: [Intel-wired-lan] [PATCH
th
128 VFs on ice).
The added benefit of not triggering the "Device is still in reset" path
is that we avoid going through the __IAVF_INIT_FAILED state, which would
take a full second before retrying.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +
after the queues are released.
Without this fix, "rmmod iavf" takes half a second per interface that's
up and prints the "Device resources not yet released" warning.
Fixes: c8de44b577eb ("iavf: do not process adminq tasks when
__IAVF_IN_REMOVE_TASK is set")
Sig
Bit lock __IAVF_IN_CRITICAL_TASK does not exist anymore since commit
5ac49f3c2702 ("iavf: use mutexes for locking of critical sections").
Adjust the comments accordingly.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
1 file changed, 2 insert
The reason for queueing watchdog_task is to have it process the
aq_required flags that are being set here. If comms failed, there's
nothing to do, so return early.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 6 --
1 file changed, 4 insertions(
or locking
of critical sections") replaced test_and_set_bit with !mutex_trylock,
preserving the pattern.
Simplify it to mutex_lock.
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drive
Here are a couple of iavf cleanups and then improvements for the
initialization flow (waiting for the VF reset) and driver removal.
Michal Schmidt (5):
iavf: fix comments about old bit locks
iavf: simplify mutex_trylock+sleep loops
iavf: in iavf_down, don't queue watchdog_task if
38d41d92a90 ("i40e: clear all queues and interrupts")
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c
b/drivers/net/ethernet/intel/i40e/i40e
t;ice: Add support Flex RXD")
Signed-off-by: Michal Schmidt
---
drivers/net/ethernet/intel/ice/ice_virtchnl.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
index b0
83 matches
Mail list logo
