Re: [Intel-wired-lan] [PATCH v3 iwl-net 5/8] ice: toggle netif_carrier when setting up XSK pool

2024-06-26 Thread Michal Kubiak
On Tue, Jun 04, 2024 at 03:21:52PM +0200, Maciej Fijalkowski wrote: > This so we prevent Tx timeout issues. One of conditions checked on > running in the background dev_watchdog() is netif_carrier_ok(), so let > us turn it off when we disable the queues that belong to a q_vector > where XSK pool is

[Intel-wired-lan] [PATCH iwl-net v2] i40e: Fix XDP program unloading while removing the driver

2024-06-24 Thread Michal Kubiak
checking if the XDP program is being loaded or unloaded. Then, block only loading a new program while "__I40E_IN_REMOVE" is set. Also, move testing "__I40E_IN_REMOVE" flag to the beginning of XDP_SETUP callback to avoid unnecessary operations and checks. Fixes: 6533e558c650 ("

[Intel-wired-lan] [PATCH iwl-net] i40e: Fix XDP program unloading while removing the driver

2024-05-16 Thread Michal Kubiak
nload the XDP program. Allow for unloading the XDP program in such a case. Fixes: 6533e558c650 ("i40e: Fix reset path while removing the driver") Reviewed-by: Wojciech Drewek Signed-off-by: Michal Kubiak --- drivers/net/ethernet/intel/i40e/i40e_main.c | 19 ++- 1

[Intel-wired-lan] [PATCH iwl-net v2] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
XDP queue share the same NAPI. Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support") Fixes: a5ab9ee0df0b ("idpf: add singleq start_xmit and napi poll") Reviewed-by: Przemek Kitszel Reviewed-by: Alexander Lobakin Signed-off-by: Joshua Hay Co-developed-by: Michal K

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Fri, Dec 15, 2023 at 10:01:36AM -0800, Brett Creeley wrote: > [...] > > > > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > b/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > index df76493faa75..50761c2d9f3b 100644 > > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > +++

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Thu, Dec 14, 2023 at 01:59:57PM +0100, Paul Menzel wrote: > Lieber Michal, > > > Am 13.12.23 um 14:23 schrieb Michal Kubiak: > > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > > > > On 12/12/23 15:55, Michal Kubiak wrote: > > > &g

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
; > > > On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal Kubiak wrote: > > > > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > > > > > Dear Michal, dear Joshua, > > > > > > > > > > > > > > > Thank yo

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-13 Thread Michal Kubiak
On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal Kubiak wrote: > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > > Dear Michal, dear Joshua, > > > > > > Thank you for your patch. > > > > On 12/12/23 15:55, Michal Kubiak wrote: > > >

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-13 Thread Michal Kubiak
On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > Dear Michal, dear Joshua, > > > Thank you for your patch. > > On 12/12/23 15:55, Michal Kubiak wrote: > > From: Joshua Hay > > > > Tell hardware to writeback completed descriptors even when in

[Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-12 Thread Michal Kubiak
timeout). Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support") Fixes: a5ab9ee0df0b ("idpf: add singleq start_xmit and napi poll") Reviewed-by: Przemek Kitszel Reviewed-by: Alexander Lobakin Signed-off-by: Joshua Hay Co-developed-by: Michal Kubiak Signed-o

[Intel-wired-lan] [PATCH iwl-next] idpf: set scheduling mode for completion queue

2023-09-22 Thread Michal Kubiak
for the Tx queues. Propagate the scheduling mode data for the completion queue as well when sending the queue configuration messages. Fixes: 1c325aac10a8 ("idpf: configure resources for TX queues") Reviewed-by: Alexander Lobakin Signed-off-by: Michal Kubiak --- drivers/net/ethernet/