Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

2024-03-20 Thread Jonathan Cameron
ed to >> something else before the first return, so this might cause "unused >> assignment" warnings? I don't know if there are any tools which >> complain about that in that situation. I think probably we should just >> make that an exception and do the checkpatch

Re: [Intel-wired-lan] [PATCH v3 8/8] e1000e: Use pcie_capability_read_word() for reading LNKSTA

2023-09-19 Thread Jonathan Cameron
0_adapter, make local variable out of > pci_dev because both users are interested in it. > > Signed-off-by: Ilpo Järvinen LGTM Reviewed-by: Jonathan Cameron > --- > drivers/net/ethernet/intel/e1000e/defines.h | 1 - > drivers/net/ethernet/intel/e1000e/mac.c | 11