Re: [Intel-wired-lan] [RFC PATCH] net: add net-device TX clock source selection framework

2025-07-31 Thread Jiri Pirko
Wed, Jul 30, 2025 at 04:09:03PM +0200, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Wednesday, July 30, 2025 2:26 PM >> >>Tue, Jul 29, 2025 at 12:45:28PM +0200, arkadiusz.kubalew...@intel.com >>wrote: >> >>[...] >> >>>

Re: [Intel-wired-lan] [RFC PATCH] net: add net-device TX clock source selection framework

2025-07-30 Thread Jiri Pirko
Tue, Jul 29, 2025 at 12:45:28PM +0200, arkadiusz.kubalew...@intel.com wrote: [...] >User interface: >- Read /sys/class/net//tx_clk/ to get status (0/1) >- Write "1" to switch to that clock source I wonder, if someone invented a time machine and sent me back to 2005... [...]

Re: [Intel-wired-lan] [PATCH iwl-next v1 00/15] Fwlog support in ixgbe

2025-07-23 Thread Jiri Pirko
Tue, Jul 22, 2025 at 12:45:45PM +0200, michal.swiatkow...@linux.intel.com wrote: >Hi, > >Firmware logging is a feature that allow user to dump firmware log using >debugfs interface. It is supported on device that can handle specific Did you consider using devlink health reporter for dumping this?

[Intel-wired-lan] fwupd - devlink firmware flashing support

2025-07-09 Thread Jiri Pirko
Hi. I'm currently working on fwupd plugin for devlink. I have somehow working version tested with netdevsim and mlx5. I'm curious if you would be interested into supporting your nics as well. Here's the code: https://github.com/jpirko/fwupd/tree/wip_devlink_rfc1 In plugins/devlink/tests/example/

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/2] devlink: allow driver to freely name interfaces

2025-07-04 Thread Jiri Pirko
Fri, Jul 04, 2025 at 11:17:23AM +0200, j...@resnulli.us wrote: >Thu, Jul 03, 2025 at 01:30:21PM +0200, jedrzej.jagiel...@intel.com wrote: >>Currently when adding devlink port it is prohibited to let >>a driver name an interface on its own. In some scenarios >>it would not be preferable to provide s

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/2] devlink: allow driver to freely name interfaces

2025-07-04 Thread Jiri Pirko
Thu, Jul 03, 2025 at 01:30:21PM +0200, jedrzej.jagiel...@intel.com wrote: >Currently when adding devlink port it is prohibited to let >a driver name an interface on its own. In some scenarios >it would not be preferable to provide such limitation. > >Remove triggering the warning when ndo_get_phys_

Re: [Intel-wired-lan] [PATCH net-next v4 1/3] dpll: add reference-sync netlink attribute

2025-05-26 Thread Jiri Pirko
wed-by: Przemek Kitszel >Reviewed-by: Milena Olech >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v4 2/3] dpll: add reference sync get/set

2025-05-26 Thread Jiri Pirko
pable pins (pin-get). > >Implement netlink handler to call proper ops and configure reference >sync pin state (pin-set). > >Reviewed-by: Przemek Kitszel >Reviewed-by: Milena Olech >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v4 2/3] dpll: add phase_offset_monitor_get/set callback ops

2025-05-26 Thread Jiri Pirko
llow feature configuration. > >Obtain the feature state value using the get callback and provide it to >the user if the device driver implements callbacks. > >Execute the set callback upon user requests. > >Reviewed-by: Milena Olech >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v4 1/3] dpll: add phase-offset-monitor feature to netlink spec

2025-05-26 Thread Jiri Pirko
nd shall return current state of a feature >(enum dpll_feature_state), if the device driver provides such capability, >otherwie attribute shall not be present. > >Reviewed-by: Aleksandr Loktionov >Reviewed-by: Milena Olech >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v3 2/3] dpll: add phase_offset_monitor_get/set callback ops

2025-05-23 Thread Jiri Pirko
Fri, May 23, 2025 at 09:45:29AM +0200, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Friday, May 9, 2025 8:15 AM >> >>Thu, May 08, 2025 at 05:20:24PM +0200, arkadiusz.kubalew...@intel.com >>wrote: >>>>From: Jiri Pirko >>>>

Re: [Intel-wired-lan] [PATCH net-next v3 2/3] dpll: add reference sync get/set

2025-05-23 Thread Jiri Pirko
Thu, May 22, 2025 at 06:29:37PM +0200, arkadiusz.kubalew...@intel.com wrote: >Define function for reference sync pin registration and callback ops to >set/get current feature state. > >Implement netlink handler to fill netlink messages with reference sync >pin configuration of capable pins (pin-get

Re: [Intel-wired-lan] [PATCH net-next v2 2/3] dpll: add Reference SYNC get/set

2025-05-09 Thread Jiri Pirko
Fri, May 09, 2025 at 02:46:50PM +0200, arkadiusz.kubalew...@intel.com wrote: >Define function for Reference SYNC pin registration and callback ops to >set/get current feature state. > >Implement netlink handler to fill netlink messages with Reference SYNC >pin configuration of capable pins (pin-get

Re: [Intel-wired-lan] [PATCH net-next v3 1/3] dpll: add phase-offset-monitor feature to netlink spec

2025-05-09 Thread Jiri Pirko
Thu, May 08, 2025 at 05:29:07PM +0200, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Thursday, May 8, 2025 4:26 PM >> >>Thu, May 08, 2025 at 02:21:26PM +0200, arkadiusz.kubalew...@intel.com >>wrote: >>>Add enum dpll_feature_state for

Re: [Intel-wired-lan] [PATCH net-next v3 2/3] dpll: add phase_offset_monitor_get/set callback ops

2025-05-08 Thread Jiri Pirko
Thu, May 08, 2025 at 05:20:24PM +0200, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Thursday, May 8, 2025 4:31 PM >> >>Thu, May 08, 2025 at 02:21:27PM +0200, arkadiusz.kubalew...@intel.com >>wrote: >>>Add new callback operations for a dpl

Re: [Intel-wired-lan] [PATCH net-next v3 2/3] dpll: add phase_offset_monitor_get/set callback ops

2025-05-08 Thread Jiri Pirko
Thu, May 08, 2025 at 02:21:27PM +0200, arkadiusz.kubalew...@intel.com wrote: >Add new callback operations for a dpll device: >- phase_offset_monitor_get(..) - to obtain current state of phase offset > monitor feature from dpll device, >- phase_offset_monitor_set(..) - to allow feature configuratio

Re: [Intel-wired-lan] [PATCH net-next v3 1/3] dpll: add phase-offset-monitor feature to netlink spec

2025-05-08 Thread Jiri Pirko
Thu, May 08, 2025 at 02:21:26PM +0200, arkadiusz.kubalew...@intel.com wrote: >Add enum dpll_feature_state for control over features. > >Add dpll device level attribute: >DPLL_A_PHASE_OFFSET_MONITOR - to allow control over a phase offset monitor >feature. Attribute is present and shall return curren

Re: [Intel-wired-lan] [PATCH net-next v2 3/4] dpll: features_get/set callbacks

2025-04-17 Thread Jiri Pirko
Thu, Apr 17, 2025 at 11:23:09AM +0200, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Wednesday, April 16, 2025 2:11 PM >> >>Tue, Apr 15, 2025 at 08:15:42PM +0200, arkadiusz.kubalew...@intel.com >>wrote: >>>Add new callback ops for a

Re: [Intel-wired-lan] [PATCH net-next v2 1/4] dpll: use struct dpll_device_info for dpll registration

2025-04-17 Thread Jiri Pirko
Thu, Apr 17, 2025 at 11:33:13AM +0200, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Wednesday, April 16, 2025 2:13 PM >> >>Tue, Apr 15, 2025 at 08:15:40PM +0200, arkadiusz.kubalew...@intel.com >>wrote: >>>Instead of pas

Re: [Intel-wired-lan] [PATCH net-next v2 1/4] dpll: use struct dpll_device_info for dpll registration

2025-04-16 Thread Jiri Pirko
Tue, Apr 15, 2025 at 08:15:40PM +0200, arkadiusz.kubalew...@intel.com wrote: >Instead of passing list of properties as arguments to >dpll_device_register(..) use a dedicated struct. > >Signed-off-by: Arkadiusz Kubalewski >--- >v2: >- new commit >--- > drivers/dpll/dpll_core.c

Re: [Intel-wired-lan] [PATCH net-next v2 3/4] dpll: features_get/set callbacks

2025-04-16 Thread Jiri Pirko
Tue, Apr 15, 2025 at 08:15:42PM +0200, arkadiusz.kubalew...@intel.com wrote: >Add new callback ops for a dpll device. >- features_get(..) - to obtain currently configured features from dpll > device, >- feature_set(..) - to allow dpll device features configuration. >Provide features attribute and

Re: [Intel-wired-lan] [PATCH net-next v1 0/3] dpll: add ref-sync pins feature

2025-04-16 Thread Jiri Pirko
Tue, Apr 15, 2025 at 07:51:12PM +0200, arkadiusz.kubalew...@intel.com wrote: >Allow to bind two pins and become a single source of clock signal, where >first of the pins is carring the base frequency and second provides SYNC >pulses. This is not enough. Could you please provide more details about

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: use DSN instead of PCI BDF for ice_adapter index

2025-04-07 Thread Jiri Pirko
nly simplification, but also fixes things up when PF >is passed to VM (and thus has a random BDF). > >Suggested-by: Jacob Keller >Suggested-by: Jakub Kicinski >Suggested-by: Jiri Pirko >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Przemek Kitszel >--- >CC: Karol

Re: [Intel-wired-lan] [RFC net-next v2 1/2] devlink: add whole device devlink instance

2025-03-18 Thread Jiri Pirko
Wed, Feb 19, 2025 at 05:32:54PM +0100, przemyslaw.kits...@intel.com wrote: >Add a support for whole device devlink instance. Intented as a entity >over all PF devices on given physical device. > >In case of ice driver we have multiple PF devices (with their devlink >dev representation), that have s

Re: [Intel-wired-lan] [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index

2025-03-10 Thread Jiri Pirko
Mon, Mar 10, 2025 at 09:40:16AM +0100, przemyslaw.kits...@intel.com wrote: >> Subject: Re: [PATCH iwl-next] ice: use DSN instead of PCI BDF for >> ice_adapter index > >regarding -net vs -next, no one have complained that this bug hurts Wait, so we are now waiting for someone to hit the bug and co

Re: [Intel-wired-lan] [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index

2025-03-07 Thread Jiri Pirko
ould point to the very same >> ice_adapter instance. >> >> This is not only simplification, but also fixes things up when PF >> is passed to VM (and thus has a random BDF). >> >> Suggested-by: Jacob Keller >> Suggested-by: Jakub Kicinski >> Suggested-by:

Re: [Intel-wired-lan] [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index

2025-03-07 Thread Jiri Pirko
nly simplification, but also fixes things up when PF >is passed to VM (and thus has a random BDF). > >Suggested-by: Jacob Keller >Suggested-by: Jakub Kicinski >Suggested-by: Jiri Pirko >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Przemek Kitszel >From my perspectiv

Re: [Intel-wired-lan] [RFC net-next v2 1/2] devlink: add whole device devlink instance

2025-02-26 Thread Jiri Pirko
Wed, Feb 26, 2025 at 04:06:19PM +0100, przemyslaw.kits...@intel.com wrote: >On 2/26/25 15:48, Jiri Pirko wrote: >> Tue, Feb 25, 2025 at 04:40:49PM +0100, przemyslaw.kits...@intel.com wrote: >> > On 2/25/25 15:35, Jiri Pirko wrote: >> > > Tue, Feb 25, 2025 at 12:

Re: [Intel-wired-lan] [RFC net-next v2 1/2] devlink: add whole device devlink instance

2025-02-26 Thread Jiri Pirko
Tue, Feb 25, 2025 at 04:40:49PM +0100, przemyslaw.kits...@intel.com wrote: >On 2/25/25 15:35, Jiri Pirko wrote: >> Tue, Feb 25, 2025 at 12:30:49PM +0100, przemyslaw.kits...@intel.com wrote: [...] >> > output, for all PFs and VFs on given device: >> > >> > pc

Re: [Intel-wired-lan] [RFC net-next v2 1/2] devlink: add whole device devlink instance

2025-02-25 Thread Jiri Pirko
Tue, Feb 25, 2025 at 12:30:49PM +0100, przemyslaw.kits...@intel.com wrote: > >> > Thanks to Wojciech Drewek for very nice naming of the devlink instance: >> > PF0: pci/:00:18.0 >> > whole-dev: pci/:00:18 >> > But I made this a param for now (driver is free to pass just "whole-

Re: [Intel-wired-lan] [RFC net-next v2 1/2] devlink: add whole device devlink instance

2025-02-24 Thread Jiri Pirko
Wed, Feb 19, 2025 at 05:32:54PM +0100, przemyslaw.kits...@intel.com wrote: >Add a support for whole device devlink instance. Intented as a entity >over all PF devices on given physical device. > >In case of ice driver we have multiple PF devices (with their devlink >dev representation), that have s

Re: [Intel-wired-lan] [RFC net-next v2 1/2] devlink: add whole device devlink instance

2025-02-24 Thread Jiri Pirko
Fri, Feb 21, 2025 at 02:45:12AM +0100, k...@kernel.org wrote: >On Wed, 19 Feb 2025 17:32:54 +0100 Przemek Kitszel wrote: >> Add a support for whole device devlink instance. Intented as a entity >> over all PF devices on given physical device. >> >> In case of ice driver we have multiple PF devices

Re: [Intel-wired-lan] [PATCH iwl-next v3 01/14] devlink: add value check to devlink_info_version_put()

2025-02-12 Thread Jiri Pirko
Wed, Feb 12, 2025 at 02:14:00PM +0100, jedrzej.jagiel...@intel.com wrote: >Prevent from proceeding if there's nothing to print. > >Suggested-by: Przemek Kitszel >Signed-off-by: Jedrzej Jagielski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH iwl-next v3 02/14] ixgbe: add initial devlink support

2025-02-12 Thread Jiri Pirko
Wed, Feb 12, 2025 at 02:14:01PM +0100, jedrzej.jagiel...@intel.com wrote: >Add an initial support for devlink interface to ixgbe driver. > >Similarly to i40e driver the implementation doesn't enable >devlink to manage device-wide configuration. Devlink instance >is created for each physical functio

Re: [Intel-wired-lan] [PATCH iwl-next v3 03/14] ixgbe: add handler for devlink .info_get()

2025-02-12 Thread Jiri Pirko
Wed, Feb 12, 2025 at 02:14:02PM +0100, jedrzej.jagiel...@intel.com wrote: >Provide devlink .info_get() callback implementation to allow the >driver to report detailed version information. The following info >is reported: > > "serial_number" -> The PCI DSN of the adapter > "fw.bundle_id" -> Unique i

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-11 Thread Jiri Pirko
Tue, Feb 11, 2025 at 03:38:25PM +0100, przemyslaw.kits...@intel.com wrote: >On 2/11/25 13:52, Jiri Pirko wrote: >> Tue, Feb 11, 2025 at 01:12:12PM +0100, jedrzej.jagiel...@intel.com wrote: >> > From: Jiri Pirko >> > Sent: Monday, February 10, 2025 5:26 PM >> &g

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-11 Thread Jiri Pirko
Tue, Feb 11, 2025 at 01:12:12PM +0100, jedrzej.jagiel...@intel.com wrote: >From: Jiri Pirko >Sent: Monday, February 10, 2025 5:26 PM >>Mon, Feb 10, 2025 at 02:56:28PM +0100, jedrzej.jagiel...@intel.com wrote: >> >>[...] >> >>>+enum ixgbe_devlink_versio

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-10 Thread Jiri Pirko
Mon, Feb 10, 2025 at 02:56:28PM +0100, jedrzej.jagiel...@intel.com wrote: [...] >+enum ixgbe_devlink_version_type { >+ IXGBE_DL_VERSION_FIXED, >+ IXGBE_DL_VERSION_RUNNING, >+}; >+ >+static int ixgbe_devlink_info_put(struct devlink_info_req *req, >+enum ix

Re: [Intel-wired-lan] [PATCH v8 net-next 00/15] net: introduce TX H/W shaping API

2024-10-07 Thread Jiri Pirko
wed it, didn't find anything noteworthy. set- Reviewed-by: Jiri Pirko Thanks for the work Paolo! I will try to convert devlink rate to this api soon, I promise.

Re: [Intel-wired-lan] [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-27 Thread Jiri Pirko
upport for SRIOV on >bonded interface") >Signed-off-by: Thomas Bogendoerfer Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Jiri Pirko
Mon, Aug 26, 2024 at 12:17:10PM CEST, tbogendoer...@suse.de wrote: >On Mon, 26 Aug 2024 11:41:19 +0200 >Jiri Pirko wrote: > >> Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote: >> >For PFs, which don't support SRIOV_LAG, there is no pf->lag

Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Jiri Pirko
Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote: >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct >allocated. So before accessing pf->lag a NULL pointer check is needed. > >Signed-off-by: Thomas Bogendoerfer You need to add a "fixes" tag blaming the commit tha

Re: [Intel-wired-lan] [PATCH net-next v3 2/2] ice: add callbacks for Embedded SYNC enablement on dpll pins

2024-08-23 Thread Jiri Pirko
Fri, Aug 23, 2024 at 12:25:13AM CEST, arkadiusz.kubalew...@intel.com wrote: >Allow the user to get and set configuration of Embedded SYNC feature >on the ice driver dpll pins. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v3 1/2] dpll: add Embedded SYNC feature for a pin

2024-08-23 Thread Jiri Pirko
t;pin-set do netlink message. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v2 2/2] ice: add callbacks for Embedded SYNC enablement on dpll pins

2024-08-22 Thread Jiri Pirko
Wed, Aug 21, 2024 at 11:32:18PM CEST, arkadiusz.kubalew...@intel.com wrote: >Allow the user to get and set configuration of Embedded SYNC feature >on the ice driver dpll pins. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski >--- >v2: >- align to v2 changes of "dpll: add E

Re: [Intel-wired-lan] [PATCH net-next v2 1/2] dpll: add Embedded SYNC feature for a pin

2024-08-22 Thread Jiri Pirko
Wed, Aug 21, 2024 at 11:32:17PM CEST, arkadiusz.kubalew...@intel.com wrote: >Implement and document new pin attributes for providing Embedded SYNC >capabilities to the DPLL subsystem users through a netlink pin-get >do/dump messages. Allow the user to set Embedded SYNC frequency with >pin-set do ne

Re: [Intel-wired-lan] [iwl-next v1] ice: use internal pf id instead of function number

2024-08-14 Thread Jiri Pirko
is a bugfix of something not recent, you should target -net. Also, please provide "Fixes" tag blaming the commit(s) that introduced the issue. > >Reviewed-by: Wojciech Drewek >Suggested-by: Jiri Pirko >Signed-off-by: Michal Swiatkowski >--- > drivers/net/ethernet/int

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 01:39:42PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Aug 09, 2024 at 01:29:29PM +0200, Jiri Pirko wrote: >> Fri, Aug 09, 2024 at 01:05:00PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Fri, Aug 09, 2024 at 12:51:58PM

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 01:05:00PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Aug 09, 2024 at 12:51:58PM +0200, Jiri Pirko wrote: >> Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Thu, Aug 08, 2024 at 05:34:35PM

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 07:18:38AM CEST, pmen...@molgen.mpg.de wrote: >Dear Michal, > > >Thank you for your patch. > >Am 09.08.24 um 07:13 schrieb Michal Swiatkowski: >> On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: >> > Thu, Aug 08, 2024 at

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: >> Thu, Aug 08, 2024 at 09:20:09AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >Use generic devlink PF MSI-X parameter to

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-08 Thread Jiri Pirko
Thu, Aug 08, 2024 at 09:20:09AM CEST, michal.swiatkow...@linux.intel.com wrote: >Use generic devlink PF MSI-X parameter to allow user to change MSI-X >range. > >Reviewed-by: Wojciech Drewek >Signed-off-by: Michal Swiatkowski >--- > .../net/ethernet/intel/ice/devlink/devlink.c | 56 ++

Re: [Intel-wired-lan] [PATCH net-next v1 2/2] ice: add callbacks for Embedded SYNC enablement on dpll pins

2024-08-08 Thread Jiri Pirko
Thu, Aug 08, 2024 at 01:20:13PM CEST, arkadiusz.kubalew...@intel.com wrote: >Allow the user to get and set configuration of Embedded SYNC feature >on the ice driver dpll pins. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski >--- > drivers/net/ethernet/intel/ice/ice_dpll.c

Re: [Intel-wired-lan] [PATCH net-next v1 1/2] dpll: add Embedded SYNC feature for a pin

2024-08-08 Thread Jiri Pirko
Thu, Aug 08, 2024 at 01:20:12PM CEST, arkadiusz.kubalew...@intel.com wrote: >Implement and document new pin attributes for providing Embedded SYNC >capabilities to the DPLL subsystem users through a netlink pin-get >do/dump messages. Allow the user to set Embedded SYNC frequency with >pin-set do ne

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Add support for fw health report

2024-07-16 Thread Jiri Pirko
Mon, Jul 15, 2024 at 09:11:48PM CEST, kh...@redhat.com wrote: >Add support for reporting fw status via the devlink health report. > >Example: > # devlink health show pci/:02:00.0 reporter fw > pci/:02:00.0: > reporter fw > state healthy error 0 recover 0 > # devlink health diagnose pc

Re: [Intel-wired-lan] [PATCH net v3] ice: use proper macro for testing bit

2024-06-18 Thread Jiri Pirko
sensor") >Acked-by: Ivan Vecera >Reviewed-by: Alexander Lobakin >Signed-off-by: Petr Oros Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: Add support for devlink local_forwarding param.

2024-06-03 Thread Jiri Pirko
Mon, Jun 03, 2024 at 02:31:46PM CEST, wojciech.dre...@intel.com wrote: >From: Pawel Kaminski > >Add support for driver-specific devlink local_forwarding param. >Supported values are "enabled", "disabled" and "prioritized". >Default configuration is set to "enabled". > >Add documentation in network

Re: [Intel-wired-lan] [iwl-next v4 05/15] ice: allocate devlink for subfunction

2024-06-03 Thread Jiri Pirko
Mon, Jun 03, 2024 at 11:50:15AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Make devlink allocation function generic to use it for PF and for SF. > >Add function for SF devlink port creation. It will be used in next >patch. > >Create header file for subfunction device

Re: [Intel-wired-lan] [iwl-next v2 03/15] ice: add basic devlink subfunctions support

2024-05-14 Thread Jiri Pirko
Mon, May 13, 2024 at 01:44:14PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Mon, May 13, 2024 at 01:04:23PM +0200, Jiri Pirko wrote: >> Mon, May 13, 2024 at 10:37:23AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >> [...] >> >> >>

Re: [Intel-wired-lan] [iwl-next v2 03/15] ice: add basic devlink subfunctions support

2024-05-13 Thread Jiri Pirko
Mon, May 13, 2024 at 10:37:23AM CEST, michal.swiatkow...@linux.intel.com wrote: [...] >+int ice_devlink_create_sf_port(struct ice_dynamic_port *dyn_port) >+{ >+ struct devlink_port_attrs attrs = {}; >+ struct devlink_port *devlink_port; >+ struct devlink *devlink; >+ struct

Re: [Intel-wired-lan] [iwl-next v1 00/14] ice: support devlink subfunction

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:24:48AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:18:29PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >Hi, >> > >> >Current

Re: [Intel-wired-lan] [iwl-next v1 14/14] ice: allow to activate and deactivate subfunction

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:33:54AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:36:13PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:15PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > >

Re: [Intel-wired-lan] [iwl-next v1 08/14] ice: create port representor for SF

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:31:15AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:16:05PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:09PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >Store subfunction and VF pointer in port

Re: [Intel-wired-lan] [iwl-next v1 06/14] ice: base subfunction aux driver

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:20:51AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:13:55PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:07PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > >

Re: [Intel-wired-lan] [iwl-next v1 03/14] ice: add basic devlink subfunctions support

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:13:51AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:06:52PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:04PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > &g

Re: [Intel-wired-lan] [iwl-next v1 14/14] ice: allow to activate and deactivate subfunction

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:15PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Use previously implemented SF aux driver. It is probe during SF >activation and remove after deactivation. > >Signed-off-by: Piotr Raczynski >Signed-off-by: Michal Swiatkowski >--- > .../eth

Re: [Intel-wired-lan] [iwl-next v1 00/14] ice: support devlink subfunction

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkow...@linux.intel.com wrote: >Hi, > >Currently ice driver does not allow creating more than one networking >device per physical function. The only way to have more hardware backed >netdev is to use SR-IOV. > >Following patchset adds support for dev

Re: [Intel-wired-lan] [iwl-next v1 11/14] ice: netdevice ops for SF representor

2024-05-09 Thread Jiri Pirko
Subject does not have verb. Please add it. Otherwise, the patch looks ok. Reviewed-by: Jiri Pirko Tue, May 07, 2024 at 01:45:12PM CEST, michal.swiatkow...@linux.intel.com wrote: >Subfunction port representor needs the basic netdevice ops to work >correctly. Create them. > >

Re: [Intel-wired-lan] [iwl-next v1 08/14] ice: create port representor for SF

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:09PM CEST, michal.swiatkow...@linux.intel.com wrote: >Store subfunction and VF pointer in port representor structure as an >union. Add port representor type to distinguish between each of them. > >Keep the same flow of port representor creation, but instead of general >at

Re: [Intel-wired-lan] [iwl-next v1 06/14] ice: base subfunction aux driver

2024-05-09 Thread Jiri Pirko
dcast filter is added to allow traffic to pass. > >Store subfunction pointer in VSI struct. The same is done for VF >pointer. Make union of subfunction and VF pointer as only one of them >can be set with one VSI. > >Reviewed-by: Jiri Pirko >Signed-off-by: Piotr Raczynski >S

Re: [Intel-wired-lan] [iwl-next v1 03/14] ice: add basic devlink subfunctions support

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:04PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Implement devlink port handlers responsible for ethernet type devlink >subfunctions. Create subfunction devlink port and setup all resources >needed for a subfunction netdev to operate. Config

Re: [Intel-wired-lan] [iwl-next v2 0/4] ice: prepare representor for SF support

2024-05-06 Thread Jiri Pirko
ate function is called. > >The code for this patchset was split from (too big) patchset [1]. > >v1 --> v2 [2]: > * add returns for kdoc in ice_eswitch_cfg_vsi Looks ok. set- Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-29 Thread Jiri Pirko
Sat, Apr 27, 2024 at 12:25:44AM CEST, jacob.e.kel...@intel.com wrote: > > >On 4/26/2024 6:43 AM, Jiri Pirko wrote: >> Fri, Apr 26, 2024 at 02:49:40PM CEST, przemyslaw.kits...@intel.com wrote: >>> On 4/26/24 13:19, Jiri Pirko wrote: >>>> Wed, Apr 24,

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Jiri Pirko
Fri, Apr 26, 2024 at 02:49:40PM CEST, przemyslaw.kits...@intel.com wrote: >On 4/26/24 13:19, Jiri Pirko wrote: >> Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: >> > >> > >> > On 4/24/2024 8:07 AM, Jiri Pirko wrote: >> > > W

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Jiri Pirko
Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: > > >On 4/24/2024 8:07 AM, Jiri Pirko wrote: >> Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel...@intel.com wrote: >>> >>> >>> On 4/23/2024 6:14 AM, Jiri Pirko wrote: >>>>

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-24 Thread Jiri Pirko
Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel...@intel.com wrote: > > >On 4/23/2024 6:14 AM, Jiri Pirko wrote: >> Tue, Apr 23, 2024 at 01:56:55PM CEST, sergey.temerkha...@intel.com wrote: >>> >>> >>>> -----Original Message- >>>> Fro

Re: [Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device

2024-04-24 Thread Jiri Pirko
Wed, Apr 24, 2024 at 03:49:09PM CEST, piotr.kwapulin...@intel.com wrote: >>>-Original Message- >>>From: Jiri Pirko >>>Sent: Monday, April 22, 2024 4:26 PM >>>To: Kwapulinski, Piotr >>>Cc: intel-wired-...@lists.osuosl.org; net...@vger.kerne

Re: [Intel-wired-lan] [PATCH] igb: cope with large MAX_SKB_FRAGS.

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 03:54:05PM CEST, vinsc...@redhat.com wrote: >Hi Jiri, > >On Apr 23 13:26, Jiri Pirko wrote: >> Tue, Apr 23, 2024 at 12:24:46PM CEST, vinsc...@redhat.com wrote: >> >From: Paolo Abeni >> > >> >Sabrina reports that the igb driver does

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 01:56:55PM CEST, sergey.temerkha...@intel.com wrote: > > >> -Original Message----- >> From: Jiri Pirko >> Sent: Tuesday, April 23, 2024 1:36 PM >> To: Temerkhanov, Sergey >> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 11:14:59AM CEST, sergey.temerkha...@intel.com wrote: >Include segment/domain number in the device name to distinguish >between PCI devices located on different root complexes in >multi-segment configurations. Naming is changed from >ptp___clk to ptpclk I don't understand

Re: [Intel-wired-lan] [PATCH] igb: cope with large MAX_SKB_FRAGS.

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 12:24:46PM CEST, vinsc...@redhat.com wrote: >From: Paolo Abeni > >Sabrina reports that the igb driver does not cope well with large >MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload >corruption on TX. > >The root cause of the issue is that the driver does not tak

Re: [Intel-wired-lan] [PATCH] igb: cope with large MAX_SKB_FRAGS.

2024-04-23 Thread Jiri Pirko
Dubroca >Tested-by: Sabrina Dubroca >Tested-by: Corinna Vinschen >Signed-off-by: Paolo Abeni Reviewed-by: Jiri Pirko Next time, please indicate target tree (net) in [patch] brackets. >--- > drivers/net/ethernet/intel/igb/igb_main.c | 1 + > 1 file changed, 1 insertion(+) > &g

Re: [Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device

2024-04-22 Thread Jiri Pirko
Mon, Apr 22, 2024 at 03:06:11PM CEST, piotr.kwapulin...@intel.com wrote: [...] >diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h >b/drivers/net/ethernet/intel/ixgbe/ixgbe.h >index 559b443..ea6df1e 100644 >--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h >+++ b/drivers/net/ethernet/intel/ixgb

Re: [Intel-wired-lan] [iwl-next v1 0/4] ice: prepare representor for SF support

2024-04-22 Thread Jiri Pirko
Fri, Apr 19, 2024 at 07:13:32PM CEST, michal.swiatkow...@linux.intel.com wrote: >Hi, > >This is a series to prepare port representor for supporting also >subfunctions. We need correct devlink locking and the possibility to >update parent VSI after port representor is created. > >Refactor how devlin

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Thu, Apr 18, 2024 at 06:11:38PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Apr 18, 2024 at 05:43:25PM +0200, Jiri Pirko wrote: >> Thu, Apr 18, 2024 at 04:46:23PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Thu, Apr 18, 2024 at 03:02:49PM

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Thu, Apr 18, 2024 at 04:46:23PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Apr 18, 2024 at 03:02:49PM +0200, Jiri Pirko wrote: >> Thu, Apr 18, 2024 at 02:48:53PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Thu, Apr 18, 2024 at 02:04:21PM

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Thu, Apr 18, 2024 at 02:48:53PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Apr 18, 2024 at 02:04:21PM +0200, Jiri Pirko wrote: >> Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> &

Re: [Intel-wired-lan] [iwl-next v4 6/8] ice: base subfunction aux driver

2024-04-18 Thread Jiri Pirko
Wed, Apr 17, 2024 at 04:20:26PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski [...] >+static int ice_sf_dev_probe(struct auxiliary_device *adev, >+ const struct auxiliary_device_id *id) >+{ >+ struct ice_sf_dev *sf_dev = ice_adev_to_sf_dev(

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski [...] >+/** >+ * ice_allocate_sf - Allocate devlink and return SF structure pointer >+ * @dev: the device to allocate for >+ * >+ * Allocate a devlink instance for SF. >+ * >+ * Return: void po

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-16 Thread Jiri Pirko
Tue, Apr 16, 2024 at 08:16:17AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Tue, Apr 16, 2024 at 07:14:43AM +0200, Michal Swiatkowski wrote: >> On Mon, Apr 15, 2024 at 11:10:50AM +0200, Jiri Pirko wrote: >> > Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow.

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-15 Thread Jiri Pirko
Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri Pirko wrote: >> Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski

Re: [Intel-wired-lan] [iwl-next v1] ice: Remove ndo_get_phys_port_name

2024-04-12 Thread Jiri Pirko
Fri, Mar 08, 2024 at 11:58:42AM CET, dariusz.aftan...@linux.intel.com wrote: >ndo_get_phys_port_name is never actually used, as in switchdev >devklink is always being created. > >Reviewed-by: Michal Swiatkowski >Signed-off-by: Dariusz Aftanski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [iwl-next v3 4/7] ice: allocate devlink for subfunction

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:50AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Make devlink allocation function generic to use it for PF and for SF. > >Add function for SF devlink port creation. It will be used in next >patch. > >Create header file for subfunction device

Re: [Intel-wired-lan] [iwl-next v3 6/7] ice: implement netdev for subfunction

2024-04-12 Thread Jiri Pirko
>Signed-off-by: Piotr Raczynski >Signed-off-by: Michal Swiatkowski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [iwl-next v3 5/7] ice: base subfunction aux driver

2024-04-12 Thread Jiri Pirko
dcast filter is added to allow traffic to pass. > >Signed-off-by: Piotr Raczynski >Signed-off-by: Michal Swiatkowski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Implement devlink port handlers responsible for ethernet type devlink >subfunctions. Create subfunction devlink port and setup all resources >needed for a subfunction netdev to operate. Config

Re: [Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Jiri Pirko
Tue, Apr 02, 2024 at 03:57:35PM CEST, ksund...@redhat.com wrote: >On Tue, Apr 2, 2024 at 4:51 PM Jiri Pirko wrote: >> >> Tue, Apr 02, 2024 at 11:22:54AM CEST, ksund...@redhat.com wrote: >> >Changing the MAC address of the VFs is currently unsupported via devlink. >>

Re: [Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Jiri Pirko
Tue, Apr 02, 2024 at 11:22:54AM CEST, ksund...@redhat.com wrote: >Changing the MAC address of the VFs is currently unsupported via devlink. >Add the function handlers to set and get the HW address for the VFs. > >Signed-off-by: Karthik Sundaravel >--- > drivers/net/ethernet/intel/ice/ice_devlink.c

Re: [Intel-wired-lan] [PATCH v2 net] ice: Fix freeing uninitialized pointers

2024-03-21 Thread Jiri Pirko
ecessary devm_ usage") >Signed-off-by: Dan Carpenter Reviewed-by: Jiri Pirko >--- >v2: I missed a couple pointers in v1. > >The change to ice_update_link_info() isn't required because it's >assigned on the very next line... But I did that because it's ha

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

2024-03-18 Thread Jiri Pirko
Sat, Mar 16, 2024 at 10:44:40AM CET, dan.carpen...@linaro.org wrote: >Automatically cleaned up pointers need to be initialized before exiting >their scope. In this case, they need to be initialized to NULL before >any return statement. > >Fixes: 90f821d72e11 ("ice: avoid unnecessary devm_ usage")

  1   2   >